r22376 - trunk/TOOLS/checktree.sh
Author: ivo Date: Wed Feb 28 12:48:32 2007 New Revision: 22376 Modified: trunk/TOOLS/checktree.sh Log: fix printing of -(no)svn option Modified: trunk/TOOLS/checktree.sh ============================================================================== --- trunk/TOOLS/checktree.sh (original) +++ trunk/TOOLS/checktree.sh Wed Feb 28 12:48:32 2007 @@ -125,8 +125,8 @@ for i in "$@"; do echo printoption "color " "colored output" "$_color" printoption "head " "print heading for each test" "$_head" - printoption "svn " "use .svn/ to determine which files to " \ - "check" "$_svn" + printoption "svn " "use .svn/ to determine which files to check"\ + "$_svn" echo -e "\nIf no files are specified, the whole tree is traversed." echo -e "If there are, -(no)svn has no effect.\n" exit
Hello, On Wed, Feb 28, 2007 at 12:48:32PM +0100, ivo wrote:
Author: ivo Date: Wed Feb 28 12:48:32 2007 New Revision: 22376
Modified: trunk/TOOLS/checktree.sh
Log: fix printing of -(no)svn option
Modified: trunk/TOOLS/checktree.sh ============================================================================== --- trunk/TOOLS/checktree.sh (original) +++ trunk/TOOLS/checktree.sh Wed Feb 28 12:48:32 2007 @@ -125,8 +125,8 @@ for i in "$@"; do echo printoption "color " "colored output" "$_color" printoption "head " "print heading for each test" "$_head" - printoption "svn " "use .svn/ to determine which files to " \ - "check" "$_svn" + printoption "svn " "use .svn/ to determine which files to check"\ + "$_svn"
btw. -svn (which is the default) fails without any indication it did with svn version 1.4 Maybe a solution that does not rely on svn internals (e.g. using svn status) would be a good idea... Greetings, Reimar Döffinger
On Wednesday 28 February 2007 13:22, Reimar Döffinger wrote:
btw. -svn (which is the default) fails without any indication it did with svn version 1.4 Maybe a solution that does not rely on svn internals (e.g. using svn status) would be a good idea...
I'll look into it. I tried svn status -v once, but you cannot determine whether the item listed is a directory or a file, plus the first run it is pretty slow (much slower than -nosvn) and the point of using svn entries was to be faster and assure that only files in svn are checked :) But I agree that relying on svn internals is bad, so I'll see if I can find a better solution. --Ivo
On Wednesday 28 February 2007 14:12, Ivo wrote:
On Wednesday 28 February 2007 13:22, Reimar Döffinger wrote:
btw. -svn (which is the default) fails without any indication it did with svn version 1.4 Maybe a solution that does not rely on svn internals (e.g. using svn status) would be a good idea...
I'll look into it. I tried svn status -v once, but you cannot determine whether the item listed is a directory or a file, plus the first run it is pretty slow (much slower than -nosvn) and the point of using svn entries was to be faster and assure that only files in svn are checked :) But I agree that relying on svn internals is bad, so I'll see if I can find a better solution.
Hmm, the current -svn version wasn't faster than -nosvn anyway. I tried using svn ls -R but that's also very slow and stays slow after repeated runs (svn status becomes faster for the second run if stuff is still cached). The best solution seems to be svn info -R and parsing its output. It's faster than the current implementation and less likely to break with future updates of the svn tools (unless they reverse the order of the Path: and Node Kind: fields but that would be stupid :) ). --Ivo
Hello, On Wed, Feb 28, 2007 at 04:05:16PM +0100, Ivo wrote:
future updates of the svn tools (unless they reverse the order of the Path: and Node Kind: fields but that would be stupid :) ).
Well, not that it matters much, but it might be simpler to check the file type with shell functionality (e.g. "test -f" or similar). Greetings, Reimar Döffinger
participants (4)
-
ivo -
Ivo -
Reimar Doeffinger -
Reimar Döffinger