CVS: main/libmpdemux demux_mkv.c,1.9,1.10
CVS change done by Moritz Bunkus CVS Update of /cvsroot/mplayer/main/libmpdemux In directory mail:/var2/tmp/cvs-serv3236 Modified Files: demux_mkv.c Log Message: Parse comma separated language lists instead of comparing the complete language string. Patch by Loren Merritt <lorenm at u dot washington dot edu> Index: demux_mkv.c =================================================================== RCS file: /cvsroot/mplayer/main/libmpdemux/demux_mkv.c,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- demux_mkv.c 9 Feb 2004 19:21:08 -0000 1.9 +++ demux_mkv.c 18 Mar 2004 08:37:21 -0000 1.10 @@ -236,12 +236,19 @@ static mkv_track_t * demux_mkv_find_track_by_language (mkv_demuxer_t *d, char *language, int type) { - int i; + int i, len; - for (i=0; i < d->num_tracks; i++) - if (d->tracks[i] != NULL && d->tracks[i]->language != NULL && - d->tracks[i]->type == type && !strcmp(d->tracks[i]->language,language)) - return d->tracks[i]; + language += strspn(language,","); + while((len = strcspn(language,",")) > 0) + { + for (i=0; i < d->num_tracks; i++) + if (d->tracks[i] != NULL && d->tracks[i]->language != NULL && + d->tracks[i]->type == type && + !strncmp(d->tracks[i]->language, language, len)) + return d->tracks[i]; + language += len; + language += strspn(language,","); + } return NULL; }
Moin, On Thu, Mar 18, 2004 at 09:37:24AM +0100, Moritz Bunkus CVS wrote:
CVS change done by Moritz Bunkus CVS
Update of /cvsroot/mplayer/main/libmpdemux In directory mail:/var2/tmp/cvs-serv3236
Modified Files: demux_mkv.c Log Message: Parse comma separated language lists instead of comparing the complete language string. Patch by Loren Merritt <lorenm at u dot washington dot edu> + language += strspn(language,","); + while((len = strcspn(language,",")) > 0)
Wouldnt it be better to do here a case insensitive search ? IMHO it would be far more dwimy beside that one didnt need to care about whether the lang code in the file was upper or lower case. Attila Kinali
Hi,
Wouldnt it be better to do here a case insensitive search ?
The usual tools only allow lower case language codes (Matroska uses ISO639-2 langauge codes), so I didn't bother. But of course this could be improved. Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
participants (3)
-
attila -
Moritz Bunkus -
syncmail@mplayerhq.hu