r27484 - trunk/libmpdemux/demux_lavf.c
Author: aurel Date: Tue Aug 26 23:12:48 2008 New Revision: 27484 Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me. Modified: trunk/libmpdemux/demux_lavf.c Modified: trunk/libmpdemux/demux_lavf.c ============================================================================== --- trunk/libmpdemux/demux_lavf.c (original) +++ trunk/libmpdemux/demux_lavf.c Tue Aug 26 23:12:48 2008 @@ -183,6 +183,7 @@ static const char *preferred_list[] = { "mov,mp4,m4a,3gp,3g2,mj2", "mpc", "mpc8", + "matroska", NULL };
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there - the track output becomes a lot worse: instead of [mkv] Track ID 3: subtitles (S_TEXT/ASS) "KAA Styled Subs", -sid 0, -slang eng you get the almost completely useless [lavf] Subtitle stream found, -sid 0 - Making a long seek to beyond the end of file causes a long pause. I think the demuxer reads from the current position to end of file. I fixed a similar bug in the MPlayer demuxer once...
Uoti Urpala wrote:
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there
I've no idea of what you're talking about here. Bugreport somewhere ?
- the track output becomes a lot worse: instead of [mkv] Track ID 3: subtitles (S_TEXT/ASS) "KAA Styled Subs", -sid 0, -slang eng you get the almost completely useless [lavf] Subtitle stream found, -sid 0
Well, adding the -slang information might be useful (even though runtime subtitle switching with the 'j' key is much more user friendly). Other "information" are basically poor duplicate of the codec information printed by MPlayer below.
- Making a long seek to beyond the end of file causes a long pause. I think the demuxer reads from the current position to end of file. I fixed a similar bug in the MPlayer demuxer once...
Indeed. That's something that I can improve (should be quite easy). But I think this is far from a typical use case. Aurel
On Wed, 2008-08-27 at 01:47 +0200, Aurelien Jacobs wrote:
Uoti Urpala wrote:
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there
I've no idea of what you're talking about here. Bugreport somewhere ?
It was mentioned at least the last time using the lavf demuxer was discussed on mplayer-dev-eng (proposed by Evgeniy that time).
- the track output becomes a lot worse: instead of [mkv] Track ID 3: subtitles (S_TEXT/ASS) "KAA Styled Subs", -sid 0, -slang eng you get the almost completely useless [lavf] Subtitle stream found, -sid 0
Well, adding the -slang information might be useful (even though runtime subtitle switching with the 'j' key is much more user friendly). Other "information" are basically poor duplicate of the codec information printed by MPlayer below.
MPlayer does not print the track name later. And the information is useful to see what tracks are available for selection, so anything printed only _after_ selecting the track is too late. Cycling through the choices is not a good way to find out what is available.
- Making a long seek to beyond the end of file causes a long pause. I think the demuxer reads from the current position to end of file. I fixed a similar bug in the MPlayer demuxer once...
Indeed. That's something that I can improve (should be quite easy). But I think this is far from a typical use case.
It can happen easily enough if you use the Page Up key to move through the file (10 minutes is enough to cause a noticeable pause).
Uoti Urpala wrote:
On Wed, 2008-08-27 at 01:47 +0200, Aurelien Jacobs wrote:
Uoti Urpala wrote:
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there
I've no idea of what you're talking about here. Bugreport somewhere ?
It was mentioned at least the last time using the lavf demuxer was discussed on mplayer-dev-eng (proposed by Evgeniy that time).
The only thing I found in this thread is this: "I quickly tested the lavf demuxer and the first file already showed a missing subtitle at the start." Is that what you call a bug report, or did I missed something ? Sorry but I just run out of crystal ball... Aurel
On Wed, 2008-08-27 at 02:30 +0200, Aurelien Jacobs wrote:
The only thing I found in this thread is this:
"I quickly tested the lavf demuxer and the first file already showed a missing subtitle at the start."
Is that what you call a bug report, or did I missed something ?
There was more information in the thread.
On Wed, 27 Aug 2008 01:47:47 +0200 Aurelien Jacobs <aurel@gnuage.org> wrote:
Uoti Urpala wrote:
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there
I've no idea of what you're talking about here. Bugreport somewhere ?
- the track output becomes a lot worse: instead of [mkv] Track ID 3: subtitles (S_TEXT/ASS) "KAA Styled Subs", -sid 0, -slang eng you get the almost completely useless [lavf] Subtitle stream found, -sid 0
Well, adding the -slang information might be useful (even though runtime subtitle switching with the 'j' key is much more user friendly).
It is not so friendly now as the subtitle language is displayed as "unknown" on the OSD for all subtitles. Also, embedded VOBsubs have wrong Y-position for some reason. They are shifted to the bottom and only the top half of them seems to be visible. I can provide a sample if needed. Regards, -- Jindrich Makovicka
Jindrich Makovicka wrote:
On Wed, 27 Aug 2008 01:47:47 +0200 Aurelien Jacobs <aurel@gnuage.org> wrote:
Uoti Urpala wrote:
On Tue, 2008-08-26 at 23:12 +0200, aurel wrote:
Log: prefer libavformat to demux matroska files I can't spot any regression anymore. If you find one, please tell me.
- the timestamp bug causing lost/broken subtitles is still there
I've no idea of what you're talking about here. Bugreport somewhere ?
- the track output becomes a lot worse: instead of [mkv] Track ID 3: subtitles (S_TEXT/ASS) "KAA Styled Subs", -sid 0, -slang eng you get the almost completely useless [lavf] Subtitle stream found, -sid 0
Well, adding the -slang information might be useful (even though runtime subtitle switching with the 'j' key is much more user friendly).
It is not so friendly now as the subtitle language is displayed as "unknown" on the OSD for all subtitles.
Hum... I was sure this worked fine. In fact the bug is simply that MPlayer don't act the same way whether the lavf or lavfpref demuxer is used. It is now fixed.
Also, embedded VOBsubs have wrong Y-position for some reason. They are shifted to the bottom and only the top half of them seems to be visible.
I can't reproduce this. Sample welcome. Aurel
On Wed, 27 Aug 2008 13:32:49 +0200 Aurelien Jacobs <aurel@gnuage.org> wrote:
Jindrich Makovicka wrote:
Also, embedded VOBsubs have wrong Y-position for some reason. They are shifted to the bottom and only the top half of them seems to be visible.
I can't reproduce this. Sample welcome.
incoming/reddwarf-vobsub.mkv -- Jindrich Makovicka
participants (4)
-
aurel -
Aurelien Jacobs -
Jindrich Makovicka -
Uoti Urpala