r23154 - in trunk: DOCS/man/de/mplayer.1 DOCS/man/en/mplayer.1 cfg-mplayer.h libvo/aspect.c
Author: cehoyos Date: Sat Apr 28 01:16:45 2007 New Revision: 23154 Log: Make -monitorpixelaspect 0 the default. Patch by Onur Küçük <onur.--.-.delipenguen.net> Modified: trunk/cfg-mplayer.h trunk/libvo/aspect.c Changes in other areas also in this revision: Modified: trunk/DOCS/man/de/mplayer.1 trunk/DOCS/man/en/mplayer.1 Modified: trunk/cfg-mplayer.h ============================================================================== --- trunk/cfg-mplayer.h (original) +++ trunk/cfg-mplayer.h Sat Apr 28 01:16:45 2007 @@ -206,8 +206,8 @@ m_option_t mplayer_opts[]={ // Geometry string {"geometry", &vo_geometry, CONF_TYPE_STRING, 0, 0, 0, NULL}, // set aspect ratio of monitor - useful for 16:9 TVout - {"monitoraspect", &monitor_aspect, CONF_TYPE_FLOAT, CONF_RANGE, 0.2, 9.0, NULL}, - {"monitorpixelaspect", &monitor_pixel_aspect, CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 9.0, NULL}, + {"monitoraspect", &monitor_aspect, CONF_TYPE_FLOAT, CONF_RANGE, 0.0, 9.0, NULL}, + {"monitorpixelaspect", &monitor_pixel_aspect, CONF_TYPE_FLOAT, CONF_RANGE, 0.2, 9.0, NULL}, // video mode switching: (x11,xv,dga) {"vm", &vidmode, CONF_TYPE_FLAG, 0, 0, 1, NULL}, {"novm", &vidmode, CONF_TYPE_FLAG, 0, 1, 0, NULL}, Modified: trunk/libvo/aspect.c ============================================================================== --- trunk/libvo/aspect.c (original) +++ trunk/libvo/aspect.c Sat Apr 28 01:16:45 2007 @@ -19,8 +19,8 @@ float vo_panscanrange = 1.0; #include "video_out.h" -float monitor_aspect=4.0/3.0; -float monitor_pixel_aspect=0; +float monitor_aspect=0; +float monitor_pixel_aspect=1; extern float movie_aspect; static struct { @@ -55,7 +55,7 @@ void aspect_save_screenres(int scrw, int #endif aspdat.scrw = scrw; aspdat.scrh = scrh; - if (monitor_pixel_aspect) + if (!monitor_aspect) monitor_aspect = monitor_pixel_aspect * scrw / scrh; }
Hi! On 2007-04-27 23:16, cehoyos wrote:
Author: cehoyos Date: Sat Apr 28 01:16:45 2007 New Revision: 23154
Log: Make -monitorpixelaspect 0 the default.
Unfortunately, this patch broke -vo aa. The picture is too narrow now. Since I'm not sure how to fix it (and it's to late), I'd be happy if someone could make a suggestion. Carl Eugen
On Thu, 04 Oct 2007 02:57:43 +0200, Carl Eugen Hoyos scribed:
Hi!
On 2007-04-27 23:16, cehoyos wrote:
Author: cehoyos Date: Sat Apr 28 01:16:45 2007 New Revision: 23154
Log: Make -monitorpixelaspect 0 the default.
Unfortunately, this patch broke -vo aa. The picture is too narrow now.
does -monitorpixelaspect 1 workaround it? -compn
On Wed, Oct 03, 2007 at 09:51:27PM -0400, Compn wrote:
On Thu, 04 Oct 2007 02:57:43 +0200, Carl Eugen Hoyos scribed:
Hi!
On 2007-04-27 23:16, cehoyos wrote:
Author: cehoyos Date: Sat Apr 28 01:16:45 2007 New Revision: 23154
Log: Make -monitorpixelaspect 0 the default.
Unfortunately, this patch broke -vo aa. The picture is too narrow now.
does -monitorpixelaspect 1 workaround it?
-monitorpixelaspect 0 is hardly even documented (what does "disables" mean in the man page?!) and it's probably a bad default. Default should be 1. Rich
On Wed, 2007-10-03 at 22:58 -0400, Rich Felker wrote:
On Thu, 04 Oct 2007 02:57:43 +0200, Carl Eugen Hoyos scribed:
Log: Make -monitorpixelaspect 0 the default.
Unfortunately, this patch broke -vo aa. The picture is too narrow now.
-monitorpixelaspect 0 is hardly even documented (what does "disables" mean in the man page?!) and it's probably a bad default. Default should be 1.
If you'd checked the actual commit you'd seen that the log message is wrong and it actually makes -monitorpixelaspect 1 the default. Obviously this is not a good default for aa, but I'm not sure whether we should care...
Hello, On Thu, Oct 04, 2007 at 06:02:24AM +0300, Uoti Urpala wrote:
On Wed, 2007-10-03 at 22:58 -0400, Rich Felker wrote:
On Thu, 04 Oct 2007 02:57:43 +0200, Carl Eugen Hoyos scribed:
Log: Make -monitorpixelaspect 0 the default.
Unfortunately, this patch broke -vo aa. The picture is too narrow now.
-monitorpixelaspect 0 is hardly even documented (what does "disables" mean in the man page?!) and it's probably a bad default. Default should be 1.
If you'd checked the actual commit you'd seen that the log message is wrong and it actually makes -monitorpixelaspect 1 the default. Obviously this is not a good default for aa, but I'm not sure whether we should care...
The main problem is that aalib has a bug that makes it break as soon as we try to do aspect scaling. Unfortunately upstream seems to be quite dead... The right value for -monitorpixelaspect with aalib is of course something like 8/15, depending on the font. Greetings, Reimar Döffinger
Reimar wrote:
The main problem is that aalib has a bug that makes it break as soon as we try to do aspect scaling. Unfortunately upstream seems to be quite dead... The right value for -monitorpixelaspect with aalib is of course something like 8/15, depending on the font.
Would attached patch improve the situation IYO, or should I create a patch for man saying one has to supply monitorpixelaspect to make aa work? Carl Eugen Index: libvo/vo_aa.c =================================================================== --- libvo/vo_aa.c (Revision 24698) +++ libvo/vo_aa.c (Arbeitskopie) @@ -86,6 +86,8 @@ int aaopt_osdcolor = AA_SPECIAL; int aaopt_subcolor = AA_SPECIAL; +extern float monitor_pixel_aspect; + void resize(void){ /* @@ -94,6 +96,8 @@ * a little bit */ + monitor_pixel_aspect=8.0/15.0; + aa_resize(c); aspect_save_screenres(aa_imgwidth(c),aa_imgheight(c));
On Thu, Oct 04, 2007 at 11:15:34AM +0200, Carl Eugen Hoyos wrote:
Reimar wrote:
The main problem is that aalib has a bug that makes it break as soon as we try to do aspect scaling. Unfortunately upstream seems to be quite dead... The right value for -monitorpixelaspect with aalib is of course something like 8/15, depending on the font.
Would attached patch improve the situation IYO, or should I create a patch for man saying one has to supply monitorpixelaspect to make aa work?
The correct standard value is 8/16 or simply 0.5. 8/15 is very strange... Rich
participants (6)
-
Carl Eugen Hoyos -
cehoyos -
Compn -
Reimar Döffinger -
Rich Felker -
Uoti Urpala