r31858 - in branches/1.0rc4/libmpcodecs: vf_geq.c vf_qp.c
Author: siretart Date: Thu Jul 29 13:36:59 2010 New Revision: 31858 Log: Revert commit r31322 by cehoyos Modified: branches/1.0rc4/libmpcodecs/vf_geq.c branches/1.0rc4/libmpcodecs/vf_qp.c Modified: branches/1.0rc4/libmpcodecs/vf_geq.c ============================================================================== --- branches/1.0rc4/libmpcodecs/vf_geq.c Thu Jul 29 11:15:32 2010 (r31857) +++ branches/1.0rc4/libmpcodecs/vf_geq.c Thu Jul 29 13:36:59 2010 (r31858) @@ -34,7 +34,7 @@ #include "vf.h" #include "libavcodec/avcodec.h" -#include "libavutil/eval.h" +#include "libavcodec/eval.h" struct vf_priv_s { AVExpr * e[3]; @@ -116,7 +116,7 @@ static int put_image(struct vf_instance const_values[3]=y; for(x=0; x<w; x++){ const_values[2]=x; - dst[x + y * dst_stride] = av_eval_expr(vf->priv->e[plane], + dst[x + y * dst_stride] = ff_eval_expr(vf->priv->e[plane], const_values, vf); } } @@ -178,7 +178,7 @@ static int vf_open(vf_instance_t *vf, ch plane==0 ? lum : (plane==1 ? cb : cr), NULL }; - res = av_parse_expr(&vf->priv->e[plane], eq[plane], const_names, NULL, NULL, func2_names, func2, 0, NULL); + res = ff_parse_expr(&vf->priv->e[plane], eq[plane], const_names, NULL, NULL, func2_names, func2, 0, NULL); if (res < 0) { mp_msg(MSGT_VFILTER, MSGL_ERR, "geq: error loading equation `%s'\n", eq[plane]); Modified: branches/1.0rc4/libmpcodecs/vf_qp.c ============================================================================== --- branches/1.0rc4/libmpcodecs/vf_qp.c Thu Jul 29 11:15:32 2010 (r31857) +++ branches/1.0rc4/libmpcodecs/vf_qp.c Thu Jul 29 13:36:59 2010 (r31858) @@ -32,7 +32,7 @@ #include "libvo/fastmemcpy.h" #include "libavcodec/avcodec.h" -#include "libavutil/eval.h" +#include "libavcodec/eval.h" struct vf_priv_s { @@ -69,7 +69,7 @@ static int config(struct vf_instance *vf double temp_val; int res; - res= av_parse_and_eval_expr(&temp_val, vf->priv->eq, const_names, const_values, NULL, NULL, NULL, NULL, NULL, 0, NULL); + res= ff_parse_and_eval_expr(&temp_val, vf->priv->eq, const_names, const_values, NULL, NULL, NULL, NULL, NULL, 0, NULL); if (res < 0){ mp_msg(MSGT_VFILTER, MSGL_ERR, "qp: Error evaluating \"%s\" \n", vf->priv->eq);
On Thu, Jul 29, 2010 at 01:36:59PM +0200, siretart wrote:
Log: Revert commit r31322 by cehoyos
I find these commit messages non-informative and thus unacceptable. What was reverted and why? Why do I have to go through another level of indirection to find out? Diego
On Thu, Jul 29, 2010 at 06:51:06PM +0200, Diego Biurrun wrote:
On Thu, Jul 29, 2010 at 01:36:59PM +0200, siretart wrote:
Log: Revert commit r31322 by cehoyos
I find these commit messages non-informative and thus unacceptable. What was reverted and why? Why do I have to go through another level of indirection to find out?
I agree, in general i (and i recomand others too) do quote the whole commit log entry with author date and commit message that is being reverted + reson why it is being reverted [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact
participants (3)
-
Diego Biurrun -
Michael Niedermayer -
siretart