CVS: main configure,1.905,1.906
CVS change done by Diego Biurrun CVS Update of /cvsroot/mplayer/main In directory mail:/var2/tmp/cvs-serv14072 Modified Files: configure Log Message: Detect if the assembler supports receiving data through -pipe, patch by Gabucino. Index: configure =================================================================== RCS file: /cvsroot/mplayer/main/configure,v retrieving revision 1.905 retrieving revision 1.906 diff -u -r1.905 -r1.906 --- configure 25 Aug 2004 15:35:32 -0000 1.905 +++ configure 25 Aug 2004 15:40:06 -0000 1.906 @@ -1200,6 +1200,11 @@ fi +echocheck "assembler support of -pipe option" +cat > $TMPC << EOF +int main(void) { return 0; } +EOF +cc_check -pipe && _pipe="-pipe" && echores "yes" || echores "no" _prefix="/usr/local" _xvmclib="XvMCNVIDIA" @@ -4946,7 +4951,7 @@ fi # internal faad: check if our dear gcc is able to compile it... cp "`pwd`/libfaad2/cfft.c" $TMPC - if ( cc_check -c -O4 $_march $_mcpu -pipe -ffast-math -fomit-frame-pointer $_inc_faad ); then + if ( cc_check -c -O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer $_inc_faad ); then _faad_internal=yes else _faad_internal="no (broken gcc)" @@ -5964,7 +5969,7 @@ _stripbinaries=no elif test -z "$CFLAGS" ; then if test "$host_arch" != "mips" ; then - CFLAGS="-O4 $_march $_mcpu -pipe -ffast-math -fomit-frame-pointer" + CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer" else CFLAGS="-O4 $_march $_mcpu -ffast-math -fomit-frame-pointer" fi @@ -6154,7 +6159,7 @@ AWK = $_awk RANLIB = $_ranlib INSTALL = $_install -# OPTFLAGS = -O4 $_profile $_debug $_march $_mcpu -pipe -fomit-frame-pointer -ffast-math +# OPTFLAGS = -O4 $_profile $_debug $_march $_mcpu $_pipe -fomit-frame-pointer -ffast-math EXTRA_INC = $_inc_extra $_inc_gtk OPTFLAGS = -I../libvo -I../../libvo $_inc_x11 $CFLAGS \$(EXTRA_INC) STRIPBINARIES = $_stripbinaries
On Wednesday, 25 August 2004 at 17:40, Diego Biurrun CVS wrote:
CVS change done by Diego Biurrun CVS
Update of /cvsroot/mplayer/main In directory mail:/var2/tmp/cvs-serv14072
Modified Files: configure Log Message: Detect if the assembler supports receiving data through -pipe, patch by Gabucino. [...] @@ -5964,7 +5969,7 @@ _stripbinaries=no elif test -z "$CFLAGS" ; then if test "$host_arch" != "mips" ; then - CFLAGS="-O4 $_march $_mcpu -pipe -ffast-math -fomit-frame-pointer" + CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer" else CFLAGS="-O4 $_march $_mcpu -ffast-math -fomit-frame-pointer" fi
This could be simplified, then. The only difference between mips and non-mips here was the use of -pipe, so this check is no longer necessary, I think. R. -- MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
Dominik 'Rathann' Mierzejewski writes:
On Wednesday, 25 August 2004 at 17:40, Diego Biurrun CVS wrote:
CVS change done by Diego Biurrun CVS
Update of /cvsroot/mplayer/main In directory mail:/var2/tmp/cvs-serv14072
Modified Files: configure Log Message: Detect if the assembler supports receiving data through -pipe, patch by Gabucino. [...] @@ -5964,7 +5969,7 @@ _stripbinaries=no elif test -z "$CFLAGS" ; then if test "$host_arch" != "mips" ; then - CFLAGS="-O4 $_march $_mcpu -pipe -ffast-math -fomit-frame-pointer" + CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer" else CFLAGS="-O4 $_march $_mcpu -ffast-math -fomit-frame-pointer" fi
This could be simplified, then. The only difference between mips and non-mips here was the use of -pipe, so this check is no longer necessary, I think.
Well, remove it then :) Diego
On Wednesday, 25 August 2004 at 18:53, Diego Biurrun wrote:
Dominik 'Rathann' Mierzejewski writes:
On Wednesday, 25 August 2004 at 17:40, Diego Biurrun CVS wrote:
CVS change done by Diego Biurrun CVS
Update of /cvsroot/mplayer/main In directory mail:/var2/tmp/cvs-serv14072
Modified Files: configure Log Message: Detect if the assembler supports receiving data through -pipe, patch by Gabucino. [...] @@ -5964,7 +5969,7 @@ _stripbinaries=no elif test -z "$CFLAGS" ; then if test "$host_arch" != "mips" ; then - CFLAGS="-O4 $_march $_mcpu -pipe -ffast-math -fomit-frame-pointer" + CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer" else CFLAGS="-O4 $_march $_mcpu -ffast-math -fomit-frame-pointer" fi
This could be simplified, then. The only difference between mips and non-mips here was the use of -pipe, so this check is no longer necessary, I think.
Well, remove it then :)
Done. I checked for any recent news about problems with -pipe on MIPS and found none. It also appears that this check has been there since the first version of configure. I wonder why A'rpi put it there. R. -- MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
participants (3)
-
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
syncmail＠mplayerhq.hu