Author: cehoyos Date: Thu Nov 10 17:31:07 2011 New Revision: 34341 Log: Fix .qcp (raw QCELP) playback. Modified: trunk/libmpdemux/demux_lavf.c Modified: trunk/libmpdemux/demux_lavf.c ============================================================================== --- trunk/libmpdemux/demux_lavf.c Thu Nov 10 17:06:23 2011 (r34340) +++ trunk/libmpdemux/demux_lavf.c Thu Nov 10 17:31:07 2011 (r34341) @@ -220,6 +220,7 @@ static const char * const preferred_list "mxf", "ogg", "pva", + "qcp", "swf", "vqf", "w64",
On Thu, Nov 10, 2011 at 05:31:08PM +0100, cehoyos wrote:
Author: cehoyos Date: Thu Nov 10 17:31:07 2011 New Revision: 34341
Log: Fix .qcp (raw QCELP) playback.
Modified: trunk/libmpdemux/demux_lavf.c
Modified: trunk/libmpdemux/demux_lavf.c ============================================================================== --- trunk/libmpdemux/demux_lavf.c Thu Nov 10 17:06:23 2011 (r34340) +++ trunk/libmpdemux/demux_lavf.c Thu Nov 10 17:31:07 2011 (r34341) @@ -220,6 +220,7 @@ static const char * const preferred_list "mxf", "ogg", "pva", + "qcp",
This should never be necessary to fix playback, and except for corner cases we really should try to fix it properly. So can you point to a sample? In addition I'd like to point out that my personal process to add to this list involves verify that the probe function in lavf a) does not need a huge amount of data b) checks at least the equivalent of 64 bit. (qcp demuxer does fulfill those requirements though, so no complaint there).
Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
+ "qcp",
This should never be necessary to fix playback, and except for corner cases we really should try to fix it properly.
So can you point to a sample?
fate-suite/qcp Please explain how this should be done properly, thank you, Carl Eugen
On Thu, Nov 10, 2011 at 09:57:36PM +0000, Carl Eugen Hoyos wrote:
Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
+ "qcp",
This should never be necessary to fix playback, and except for corner cases we really should try to fix it properly.
So can you point to a sample?
fate-suite/qcp
Please explain how this should be done properly, thank you, Carl Eugen
I won't know before debugging why it failed before. I'd presume one of our native demuxers grabs it incorrectly. In that case it should be improved to not do that if easily possible. If not we might just leave it as-is though, since as said the probe function is quite fine.
On Fri, Nov 11, 2011 at 05:59:14PM +0100, Reimar Döffinger wrote:
On Thu, Nov 10, 2011 at 09:57:36PM +0000, Carl Eugen Hoyos wrote:
Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
+ "qcp",
This should never be necessary to fix playback, and except for corner cases we really should try to fix it properly.
So can you point to a sample?
fate-suite/qcp
Please explain how this should be done properly, thank you, Carl Eugen
I won't know before debugging why it failed before. I'd presume one of our native demuxers grabs it incorrectly.
Fixed, it seems the raw audio demuxer was unintentionally too aggressive. Feel free to either leave it or revert it, since the underlying bug is fixed I don't mind either way.
participants (3)
-
Carl Eugen Hoyos -
cehoyos -
Reimar Döffinger