r22607 - trunk/mp3lib/Makefile
Author: diego Date: Thu Mar 15 13:17:22 2007 New Revision: 22607 Modified: trunk/mp3lib/Makefile Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this. Modified: trunk/mp3lib/Makefile ============================================================================== --- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) SRCS_COMMON += dct64_altivec.c ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec endif endif
Hello, On Thu, Mar 15, 2007 at 01:17:22PM +0100, diego wrote:
Author: diego Date: Thu Mar 15 13:17:22 2007 New Revision: 22607
Modified: trunk/mp3lib/Makefile
Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
Modified: trunk/mp3lib/Makefile ============================================================================== --- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) SRCS_COMMON += dct64_altivec.c ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec endif endif
Why is only half of it removed? Comparing with ffmpeg configure, the -faltivec is for Apple and -maltivec -mabi=altivec is for vanilla gcc, so it should depends on gcc version which one is done, not on OS anyway... Greetings, Reimar Döffinger
On Thu, Mar 15, 2007 at 01:36:32PM +0100, Reimar D?ffinger wrote:
On Thu, Mar 15, 2007 at 01:17:22PM +0100, diego wrote:
Modified: trunk/mp3lib/Makefile
Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
--- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) SRCS_COMMON += dct64_altivec.c ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec endif endif
Why is only half of it removed? Comparing with ffmpeg configure, the -faltivec is for Apple and -maltivec -mabi=altivec is for vanilla gcc, so it should depends on gcc version which one is done, not on OS anyway...
I was planning to remove it (and have just done so), but I wanted to reboot into OS X to doublecheck first. Diego
Hi, On 3/15/07, Diego Biurrun <diego@biurrun.de> wrote:
On Thu, Mar 15, 2007 at 01:36:32PM +0100, Reimar D?ffinger wrote:
On Thu, Mar 15, 2007 at 01:17:22PM +0100, diego wrote:
Modified: trunk/mp3lib/Makefile
Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
--- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) SRCS_COMMON += dct64_altivec.c ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec endif endif
Why is only half of it removed? Comparing with ffmpeg configure, the -faltivec is for Apple and -maltivec -mabi=altivec is for vanilla gcc, so it should depends on gcc version which one is done, not on OS anyway...
I was planning to remove it (and have just done so), but I wanted to reboot into OS X to doublecheck first.
I just tested on 10.3.x and it works fine without it. You can safely remove it I guess. Guilaume
Hi, diego wrote:
Author: diego Date: Thu Mar 15 13:17:22 2007 New Revision: 22607
Modified: trunk/mp3lib/Makefile
Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
Modified: trunk/mp3lib/Makefile ============================================================================== --- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) SRCS_COMMON += dct64_altivec.c ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec
Are you sure this is a good idea? From what I'm seeing, you are tying to have CFLAGS always contain -maltivec if the processor supports it. Correct me if I'm wrong, but that is likely to break runtime CPU detection for ppl who build on G4 for G3 machines, as -maltivec allows the compiler to generate Altivec code whenever it feels like it (not just when it's fed with Altivec intrinsics). x264 had that problem and it's been fixed yesterday. In case you're interested, here's the diff: http://trac.videolan.org/x264/changeset/629 (there were other follow-up commits after this one as it broke other stuff, you can follow the discussions here: http://www.via.ecp.fr/via/ml/x264-devel/2007-03/index.html ) Guillaume
On Thu, Mar 15, 2007 at 02:49:45PM +0100, Guillaume Poirier wrote:
diego wrote:
Log: Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
--- trunk/mp3lib/Makefile (original) +++ trunk/mp3lib/Makefile Thu Mar 15 13:17:22 2007 @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes) ifeq ($(TARGET_OS),Darwin) CFLAGS += -faltivec -else -CFLAGS += -maltivec -mabi=altivec
Are you sure this is a good idea? From what I'm seeing, you are tying to have CFLAGS always contain -maltivec if the processor supports it.
No, I just don't want to have wild and unnecessary setting of CFLAGS in random Makefiles. It's configure's job and in this case, configure is already setting those flags. Whether it is wrong or right to do this is another issue. But if it is wrong, then it is even more fatal to override configure in the Makefile... Diego
participants (5)
-
diego -
Diego Biurrun -
Guillaume Poirier -
Guillaume POIRIER -
Reimar Döffinger