r22629 - trunk/Gui/Makefile
Author: diego Date: Fri Mar 16 01:02:28 2007 New Revision: 22629 Modified: trunk/Gui/Makefile Log: Remove useless -I./skin from CFLAGS. Modified: trunk/Gui/Makefile ============================================================================== --- trunk/Gui/Makefile (original) +++ trunk/Gui/Makefile Fri Mar 16 01:02:28 2007 @@ -2,7 +2,6 @@ include ../config.mak LIBNAME_MPLAYER = libgui.a -CFLAGS = -I./skin #CFLAGS += -DDEBUG CFLAGS-$(CONFIG_LIBAVUTIL) += -I../libavutil
2007/3/16, diego <subversion@mplayerhq.hu>:
Author: diego Date: Fri Mar 16 01:02:28 2007 New Revision: 22629
Modified: trunk/Gui/Makefile
Log: Remove useless -I./skin from CFLAGS.
Modified: trunk/Gui/Makefile ============================================================================== --- trunk/Gui/Makefile (original) +++ trunk/Gui/Makefile Fri Mar 16 01:02:28 2007 @@ -2,7 +2,6 @@ include ../config.mak
LIBNAME_MPLAYER = libgui.a
-CFLAGS = -I./skin #CFLAGS += -DDEBUG
CFLAGS-$(CONFIG_LIBAVUTIL) += -I../libavutil
Is there some special reason for this committing diarrhoea ? This is the 3'd commit in 2 hours, over same line in that file, each commit removing one word. Last 4 commits could have easily been merged into one, as they are logically linked. I guess same could be said for all your commits in the last 3 days. BTW, I think there would be another commit because r22628 removes the "../../" but doesn't set the directory "gui/"...
On Fri, Mar 16, 2007 at 02:49:47AM +0200, Ivan Kalvachev wrote:
2007/3/16, diego <subversion@mplayerhq.hu>:
Log: Remove useless -I./skin from CFLAGS.
--- trunk/Gui/Makefile (original) +++ trunk/Gui/Makefile Fri Mar 16 01:02:28 2007 @@ -2,7 +2,6 @@ include ../config.mak
-CFLAGS = -I./skin #CFLAGS += -DDEBUG
Is there some special reason for this committing diarrhoea ? This is the 3'd commit in 2 hours, over same line in that file, each commit removing one word.
Last 4 commits could have easily been merged into one, as they are logically linked. I guess same could be said for all your commits in the last 3 days.
I've split this into small pieces in order to make it easy to debug. This way I can verify with a recompile that my changes work and which small change exactly introduced a problem and requires further changes. Now I'd really appreciate if you could in the future send your trolling straight to /dev/null instead of bothering me, thank you. If you don't like the way I work, fork. EOT Diego
participants (3)
-
diego -
Diego Biurrun -
Ivan Kalvachev