11 Dec
2007
11 Dec
'07
8:40 p.m.
On Tue, Dec 11, 2007 at 09:32:21PM +0100, diego wrote:
Author: diego Date: Tue Dec 11 21:32:21 2007 New Revision: 25359
Log: Replace SYS_DARWIN condition by __APPLE__ || __DARWIN__.
I strongly prefer SYS_DARWIN. __APPLE__ and __DARWIN__ are not under our control and there is no guarantee that they won't change or be defined on another non-Darwin system. Preprocessor defines from the implementation should never be used directly in ifdefs in code for these reasons. When you start writing #if defined(__foo__) || defined(__bar__) || defined(__baz__) || ... you descend into the hell of "screen". (RTFS if you don't know what i mean...egrep ^.define.{50} *.[ch]...) Rich