Hello, On Thu, 30 Oct 2003, Alex Beregszaszi wrote:
- for(qscale=1; qscale<32; qscale++){ + for(qscale=qmin; qscale<qmax; qscale++){
[cut]
j->s->q_intra_matrix16, - j->s->q_intra_matrix16_bias, - j->s->intra_matrix, j->s->intra_quant_bias); + j->s->intra_matrix, j->s->intra_quant_bias, 1, 31); return j; Why not 1-32 as it was in the original version? I looked into it, and your suggestion to call convert_matrix(..., 8, 8) (just as in libavcodec/mpegvideo.c) was correct. I got blocks on the screen because of an off-by-one error in the convert_matrix() function in jpeg_enc.c. (and my quick fix was to mess with the last two parameters of convert_matrix to get the image to appear right on the TV)
A CVS commit will follow shortly. Greetings, Rik. -- Nothing is ever a total loss; it can always serve as a bad example.