Hi, On Mon, Jun 26, 2006 at 11:27:58PM +0200, ben wrote:
+#include <pthread.h>
Why is this here? I can't see it used anywhere. Anyway, it should have been under #ifdef HAVE_PTHREADS
+#include <netdb.h>
This belongs under the #ifndef as well. You can avoid these bugs by simply grepping for the headers you include and either use them in the same way or add a configure check.
Added: trunk/libmpdemux/librtsp/rtsp_rtp.h +#define _HAVE_RTSP_RTP_H_ + +#include <pthread.h>
Wow, that's the new definition of overkill.. including an unused header twice *g* Btw. I thought policy was to avoid including headers in headers? There is also a inet_pton somwhere without all the #ifndef HAVE_WINSOCK2 #ifdef USE_ATON stuff. And I thought "let's quickly test something here under windows...". IMHO if you can't get someone to test stuff, just disable it under that other OS. Greetings, Reimar Doeffinger