On Monday, 18. February 2002 17:09, Nick Kurshev wrote:
Hello, Felix!
On Sun, 17 Feb 2002 23:39:29 +0100 you wrote:
On Sunday, 17. February 2002 11:21, Nick Kurshev wrote:
Modified Files: ════════vo_vesa.c vosub_vidix.c Log Message: Screenshot on the fly
wouldn't it be better to use a more generic function for this, so code can be used from other vo drivers without duplicating code?
Indeed it's impossible. Because: my implementation is VESA specific stuff which uses yours vo_png. I guess that it woul dbe possible to imlpement such thing also for -vo_fbdev -vo_dga I don't know any other vo drivers which have access to RGB memory. Fix me please, if I'm wrong! For every other driver we could implement something like: mplayer.c: case 'S': case 's': if(video_out->control(VOCTRL_SCREENSHOT,NULL) == NOT_IMPLEMENT) { ... generic version for YV12 - YUY2 fourcc here ... }
yea looks ok.
Also I found out that vo_png can work only with RGB24-BGR24. Could you please expand your stuff to make it ready for any BPP? (It seems that libpng can work with other bpp too) hmm, wouldn't it be best thing to send all stuff through swscale, it would do needed conversions and output rgb/bgr24? Or do you want to save 16/15/etc. bpp png file?
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Best regards! Nick
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________