On Fri, Nov 24, 2006 at 08:42:00PM -0500, Nicolas Plourde wrote:
On 24-Nov-06, at 8:34 PM, Diego Biurrun wrote:
On Sat, Nov 25, 2006 at 02:22:20AM +0100, nplourde wrote:
Modified: trunk/Makefile trunk/loader/ext.c trunk/loader/ldt_keeper.c trunk/osdep/Makefile
Log: added mmap_anon to osdep lib. Used in loader for now
--- trunk/Makefile (original) +++ trunk/Makefile Sat Nov 25 02:22:20 2006 @@ -62,7 +62,6 @@ libvo/libosd.a \ - osdep/libosdep.a \
LIBS_MPLAYER = libvo/libvo.a \ libao2/libao2.a \ @@ -158,6 +157,8 @@ OBJS_MPLAYER += osdep/mplayer-rc.o endif
+COMMON_LIBS += osdep/libosdep.a +
WTH? Why this nonsense?
If you have any suggestion I'm listening. libloader have dependencies on libosdep.
Yes, sorry, I did not look closely. I'm looking into a more general solution, but it's tricky.
--- trunk/osdep/Makefile (original) +++ trunk/osdep/Makefile Sat Nov 25 02:22:20 2006 @@ -12,6 +12,7 @@ fseeko.c \ swab.c \ setenv.c \ + mmap_anon.c \ # timer.c \
IMO there should be a configure check and this should be conditionally compiled if no mmap is natively available. Or is there a good reason to use this one always?
it can be useful somewhere else, why add useless bloat to configure?
OK, looked at it again, probably makes sense. Diego