some cinepak and video driver bugs
hi. while trying to view some cinepak videos, i found some bugs (all with MPlayer CVS-020322-05:01-2.95.4, x 4.2.0 and a g400): - the native cinepak decoder has wrong colours when using the sdl video driver (all others i tried work). seems like red and blue got switched. - the vfw cinepak codec has some problems where it seems like some areas aren't updated properly. - the dga video output looked like it just writes the picture into memory without regard to the current resolution, and when doublebuffering was enabled it flickered and showed some random stuff from video memory - when pressing 'f' with the x11 driver mplayer looses focus, and killing it kills x completely (i think someone mentioned this already) - when moving the gl output window it dies with: X11 error: BadDrawable (invalid Pixmap or Window parameter) - the vesa and svga drivers had problems when run from x (though admittedly they don't really make sense there): svga didn't restore the terminal properly ('reset' fixed that) and vesa switched to textmode (fixed by switching to the console and back) - it would be nice if configure complained about unknown options bye christian ohm -- If you do not think about the future, you cannot have one. -- John Galsworthy
On Fri, Mar 22, 2002 at 09:37:48AM +0100, Christian Ohm wrote:
hi.
while trying to view some cinepak videos, i found some bugs (all with MPlayer CVS-020322-05:01-2.95.4, x 4.2.0 and a g400):
- the native cinepak decoder has wrong colours when using the sdl video driver (all others i tried work). seems like red and blue got switched.
Fixed. UV planes got swapped when direct rendering was used. [snip]
- when pressing 'f' with the x11 driver mplayer looses focus, and killing it kills x completely (i think someone mentioned this already)
I couldn't reproduce this one... Pressing 'f' goes to fullscreen and then when I press 'esc' I get back to my desktop, mplayer shutingdown as it should. [snip]
- it would be nice if configure complained about unknown options
It does. $ ./configure --foo Detected operating system: Linux Detected host architecture: i386 Checking for gcc version ... 2.95.4, ok Checking for CPU vendor ... GenuineIntel (6:7:3) Checking for CPU type ... Pentium III (Katmai) Checking for GCC & CPU optimization abilities ... i686 Checking for binutils ... yes Unknown parameter: --foo <---------------- Checking for assembler (as 2.11.92.0.12.3) ... ok ... Maybe it should be more visible though. / Fredrik
On Sat, 23 Mar 2002, Fredrik Kuivinen wrote:
- the native cinepak decoder has wrong colours when using the sdl video driver (all others i tried work). seems like red and blue got switched.
Fixed. UV planes got swapped when direct rendering was used.
Are you sure? I still have this bug when I use the xv target (but not the default xmga target). Thanks... -- -Mike Melanson
Hi,
On Sat, 23 Mar 2002, Fredrik Kuivinen wrote:
- the native cinepak decoder has wrong colours when using the sdl video driver (all others i tried work). seems like red and blue got switched .
Fixed. UV planes got swapped when direct rendering was used.
Are you sure? I still have this bug when I use the xv target (but not the default xmga target).
there are something broken with planar yuv modes since libmpcodecs migraton. but unfortunatelly i didn't have time to dig inti it yet :( it reminds me to the rgb vs bgr problem i had a year ago... we should select a reference codec, fix libvo for it and then fix other codec to match this u/v order. but which codec is ok to be reference? or i should use teh old xmga/xv for reference? A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Sat, 23 Mar 2002, Arpi wrote:
there are something broken with planar yuv modes since libmpcodecs migraton. but unfortunatelly i didn't have time to dig inti it yet :( it reminds me to the rgb vs bgr problem i had a year ago... we should select a reference codec, fix libvo for it and then fix other codec to match this u/v order. but which codec is ok to be reference?
or i should use teh old xmga/xv for reference?
I don't think I'm the best person to ask (not quite sure about the question). xmga/xv are video drivers, not codecs, so I don't see how you would use them as codec references. Our native Cinepak decoder strikes me as a good reference since, well, we know how it works. -- -Mike Melanson
Hi,
it reminds me to the rgb vs bgr problem i had a year ago... we should select a reference codec, fix libvo for it and then fix other codec to match this u/v order. but which codec is ok to be reference?
or i should use teh old xmga/xv for reference?
I don't think I'm the best person to ask (not quite sure about the question). xmga/xv are video drivers, not codecs, so I don't see how you would use them as codec references. Our native Cinepak decoder strikes me i didn't mean they are codec... but they could be good references, as they worked well before libmpcodecs stuff.
as a good reference since, well, we know how it works.
nope we don't know 100% sure which bytes are U and V values in the file... or do you have official file format specification for cvid, declaring which is u and which is v plane? anyway it comes from Mac world, which uses different byteorder... but mpeg 1/2 or mjpeg could be a good selection they are well documented. A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Sat, 23 Mar 2002, Arpi wrote:
as a good reference since, well, we know how it works.
nope we don't know 100% sure which bytes are U and V values in the file... or do you have official file format specification for cvid, declaring which is u and which is v plane? anyway it comes from Mac world, which uses different byteorder...
We can build a pretty good case based on empirical observation of which plane is U and which plane is V. I don't believe Cinepak "came" from the Mac world; it has always been available for many platforms. What are you spouting about byte order? Cinepak data is mostly bytewise. It packs 6 bytes together as a vector of 4 pixels, 1 for each Y value, 1 for the U value and 1 for the V value. I always get confused on the meanings, though. I'm assuming U=Cb and V=Cr. Are we on the same page there? Thanks... -- -Mike Melanson
Hi,
I always get confused on the meanings, though. I'm assuming U=Cb and V=Cr. Are we on the same page there?
hmm. you gave a really very good idea! i've searched the net, and all documents matching what you say: U = Cb = Blue-Luminance V = Cr = Red-Luminance So, by disabling one of U or V, we can verify libvo drivers and codecs! Now, the last question: do we agree on that plane 1 is U and plane 2 is V ? A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Sat, 23 Mar 2002, Arpi wrote:
So, by disabling one of U or V, we can verify libvo drivers and codecs!
Now, the last question: do we agree on that plane 1 is U and plane 2 is V ?
That's how I've been working it. Of course, my methodology is usually to twist and swap values around until it works...:) -- -Mike Melanson
On Sat, Mar 23, 2002 at 10:29:56PM +0100, Arpi wrote:
Hi,
I always get confused on the meanings, though. I'm assuming U=Cb and V=Cr. Are we on the same page there?
hmm. you gave a really very good idea! i've searched the net, and all documents matching what you say: U = Cb = Blue-Luminance V = Cr = Red-Luminance
So, by disabling one of U or V, we can verify libvo drivers and codecs!
Now, the last question: do we agree on that plane 1 is U and plane 2 is V ?
Doesn't that depend on the format? For example YV12 is, according to http://www.webartz.com/fourcc/fccyuv.htm#YV12, V then U and I420 is U then V. Or I am missing something? / Fredrik
Hi,
hmm. you gave a really very good idea! i've searched the net, and all documents matching what you say: U = Cb = Blue-Luminance V = Cr = Red-Luminance
So, by disabling one of U or V, we can verify libvo drivers and codecs!
Now, the last question: do we agree on that plane 1 is U and plane 2 is V ?
Doesn't that depend on the format? For example YV12 is, according to http://www.webartz.com/fourcc/fccyuv.htm#YV12, V then U and I420 is U then V.
Or I am missing something?
no, you are right... i thought yv12 is Y,U,V not Y,V,U... ok, stuff if hopefully fixed now. i had to fix libmpcodecs/vd.c, and libvo/xmga+xv drivers tell me if something still broken A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Sat, Mar 23, 2002 at 01:20:40PM -0700, Mike Melanson wrote:
On Sat, 23 Mar 2002, Fredrik Kuivinen wrote:
- the native cinepak decoder has wrong colours when using the sdl video driver (all others i tried work). seems like red and blue got switched.
Fixed. UV planes got swapped when direct rendering was used.
Are you sure? I still have this bug when I use the xv target (but not the default xmga target).
I only changed -vo sdl not -vo xv. / Fredrik
On Saturday, 23 March 2002 at 11:22, Fredrik Kuivinen wrote:
- when pressing 'f' with the x11 driver mplayer looses focus, and killing it kills x completely (i think someone mentioned this already)
I couldn't reproduce this one... Pressing 'f' goes to fullscreen and then when I press 'esc' I get back to my desktop, mplayer shutingdown as it should.
starting in fullscreen mode and pressing 'f' to switch to windowed
- it would be nice if configure complained about unknown options
It does. $ ./configure --foo Detected operating system: Linux Detected host architecture: i386 Checking for gcc version ... 2.95.4, ok Checking for CPU vendor ... GenuineIntel (6:7:3) Checking for CPU type ... Pentium III (Katmai) Checking for GCC & CPU optimization abilities ... i686 Checking for binutils ... yes Unknown parameter: --foo <---------------- Checking for assembler (as 2.11.92.0.12.3) ... ok ...
Maybe it should be more visible though.
yeah, like mentioning all unknown options at the end with a big 'WARNING' attached. bye christian ohm -- "It doesn't much signify whom one marries for one is sure to find out next morning it was someone else." -- Rogers
participants (4)
-
Arpi -
Christian Ohm -
Fredrik Kuivinen -
Mike Melanson