[BUG] Memory leak in vo_vesa with -fixed-vo
Hi, All I think, i have found memory leak in vo_vesa driver when mplayer is used with -fixed-vo. Reason: multiple call to vbeInit with LRMI_alloc_real inside it (one call per one playtree entry), but correspodding vbeDestroy with LRMI_free_real is called only once (at mplayer exit). Error happens only in fixed-vo mode, because in usual mode mplayer calls vbeDestroy for each playtree entry (and thus each vbeInit correspods to one vbeDestroy). Error is obvious after applying attached patch to vbe.c from vesautils. With memory leak i can play in fixed-vo mode only 103 or 126 etries from playlist (depending on used hardware). After playing last entry from above region mplayer shows "Out of DOS memory" error for each subsequent entries until playlist ends. If "-playlist" used together with "-loop 0" only "kill -9" helps me to restart mplayer (this is different issue, imho), "quit" slave through input fifo does not work. P.S. not patch, so bugreport posted here. -- Regards, Vladimir Voroshilov mailto:voroshil@gmail.com JID: voroshil@gmail.com, voroshil@jabber.ru ICQ: 95587719
On Sat, 16 Feb 2008 01:07:59 +0600, Vladimir Voroshilov wrote:
Hi, All
I think, i have found memory leak in vo_vesa driver when mplayer is used with -fixed-vo.
what is the status of vesa in mplayer? lrmi is required , but no one seems to have it installed. what about including lrmi in mplayer so more people can use vesa? i get a few questions about using mplayer without x in #mplayer per week. it would be nice to have another option besides svga/fb/cvidix . -compn
On Sat, Feb 16, 2008 at 12:04:52AM -0500, Compn wrote:
On Sat, 16 Feb 2008 01:07:59 +0600, Vladimir Voroshilov wrote:
Hi, All
I think, i have found memory leak in vo_vesa driver when mplayer is used with -fixed-vo.
what is the status of vesa in mplayer? lrmi is required , but no one seems to have it installed.
what about including lrmi in mplayer so more people can use vesa? i get
While I generally agree with importing essential libraries, lrmi is not only non-essential, but specific to a particular OS. Also, the vesa vo used to have no external dependencies, IIRC. The move to needing this external mess was apparently intentional; I think Alex did it but I may be misremembering.
a few questions about using mplayer without x in #mplayer per week. it would be nice to have another option besides svga/fb/cvidix .
Vesa really has very little value and great potential for instability. Vesafb+(fbdev/cvidix) should work on any system where -vo vesa works, and with a better privilege separation. I see no reason why vo_vesa isn't just deprecated.. Rich
On Sat, 16 Feb 2008 00:10:13 -0500, Rich Felker wrote:
Also, the vesa vo used to have no external dependencies, IIRC. The move to needing this external mess was apparently intentional; I think Alex did it but I may be misremembering.
iirc it was done so that other projects could use mplayer's libvesa... -compn
participants (3)
-
Compn -
Rich Felker -
Vladimir Voroshilov