On Thu, 28 Jul 2005, Ivo wrote:
Why use a switch statement? You can also do:
I thought that switches were more efficient. Brief googling informs me that in this case, they are not. I shall change the patch, recompile and send it along. OK. It works and is attached.
Same for the other switch. It's a lot shorter and also has no cosmetic changes (which are mostly forbidden, see DOCS/tech/patches.txt).
Well, you're going to need cosmetic changes to get rid of the goto statements eventually. ;-P
BTW It's better if you post your patches to mplayer-dev-eng.
I would, but I figured that this list would be better to ask about code efficiency and exception handling. Most coders couldn't care less about efficiency or exceptions. -- |Andrew A. Gill |I posted to Silent-Tristero and| |<superluser@frontiernet.net> |all I got was this stupid sig! | |alt.tv.simpsons CBG-FAQ author | | | (Report all obscene mail to Le Maitre Pots)| |Yet: <http://www.needsfoodbadly.com> Temporary sig: -- Why do you have those goto statements?