Re: [Mndiff-dev] [PATCH] mnzip: three small patches
Hi On Mon, Jun 18, 2007 at 12:44:00AM -0700, Corey Hickey wrote:
Interesting program. I have yet to start messing with it, but the benchmarks you posted are tantalizing. Here's a few simple fixes, since I don't understand the more complex stuff.
arg_check.diff This fixes a segfault when mnzip is called with insufficient arguments.
fopen_error.diff This fixes a segfault when the input file is inaccessible.
typo.diff I guess this is a typo, but I'm not sure what you had in mind.
all applied, and thanks alot for the patches, i was alraedy affraid noone would ever send one :) btw iam CCing mndiff-dev@mplayerhq.hu which is the correct ML for all the stuff in my personal repo on mphq [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you really think that XML is the answer, then you definitly missunderstood the question -- Attila Kinali
Michael Niedermayer wrote:
Hi
On Mon, Jun 18, 2007 at 12:44:00AM -0700, Corey Hickey wrote:
Interesting program. I have yet to start messing with it, but the benchmarks you posted are tantalizing. Here's a few simple fixes, since I don't understand the more complex stuff.
arg_check.diff This fixes a segfault when mnzip is called with insufficient arguments.
fopen_error.diff This fixes a segfault when the input file is inaccessible.
typo.diff I guess this is a typo, but I'm not sure what you had in mind.
all applied, and thanks alot for the patches, i was alraedy affraid noone would ever send one :)
Thanks. Sorry about the argc being wrong. I'm 100% sure that changed after I looked at the patch... :(
btw iam CCing mndiff-dev@mplayerhq.hu which is the correct ML for all the stuff in my personal repo on mphq
Ok; subscribed. I didn't know this list existed. Should it be mentioned on www.mplayerhq.hu? -Corey
Hi On Mon, Jun 18, 2007 at 05:17:38PM -0700, Corey Hickey wrote: [...]
btw iam CCing mndiff-dev@mplayerhq.hu which is the correct ML for all the stuff in my personal repo on mphq
Ok; subscribed.
I didn't know this list existed. Should it be mentioned on www.mplayerhq.hu?
yes it should ... [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus
participants (2)
-
Corey Hickey -
Michael Niedermayer