Re: [DVDnav-discuss] [MPlayer-dev-eng] libdvdread4 r1249 crashes DVD playback
On 11 Dec 2012, at 15:54, Ingo Brückl <ib@wupperonline.de> wrote:
Is this even the right place to report?
It should rather go to the dvdnav-discuss list. My best supicion is that info_length might be negative, otherwise I can't see why this exact revision would cause issues. Though I do think that that patch might make more sense if it calculated the length from the object count rather than the other way round, particularly since the count is only 16 bit which avoids a lot of potential integer overflow issues.
On Tuesday, 11 December 2012 at 16:53, Reimar Döffinger wrote:
On 11 Dec 2012, at 15:54, Ingo Brückl <ib@wupperonline.de> wrote:
Is this even the right place to report?
It should rather go to the dvdnav-discuss list. My best supicion is that info_length might be negative, otherwise I can't see why this exact revision would cause issues.
I'm pretty sure it was caused by r1244.
Though I do think that that patch might make more sense if it calculated the length from the object count rather than the other way round, particularly since the count is only 16 bit which avoids a lot of potential integer overflow issues.
Patch welcome. :) Regards, -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (2)
-
Dominik 'Rathann' Mierzejewski -
Reimar Döffinger