[PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 4: fix hack for reloading entire IFO)
Revision 4 fixes a HACK wherein the entire .IFO was reloaded, just to load the time map. This patch also reduces the error messages that were generated in the log output. Per recent request, I'm sending this patch uncompressed.
On Fri, Nov 18, 2011 at 09:57:43PM -0500, gnosygnu wrote:
Revision 4 fixes a HACK wherein the entire .IFO was reloaded, just to load the time map. This patch also reduces the error messages that were generated in the log output.
--- src/searching.c (revision 1243) +++ src/searching.c (working copy) @@ -654,3 +655,702 @@ + +/* Get an admap and admap_len */ +static vobu_admap_t* dvdnav_admap_get(dvdnav_t *this, dvd_state_t *state + , int32_t *admap_len) {
+ if (pgcN >= tmap_count) { + fprintf(MSG_OUT, "pgcN >= tmap_count; pgcN=%i tmap_count=%i" + , pgcN, tmap_count);
Starting lines with commas like this looks very weird. Please respect surrounding code style.
--- src/dvdnav/dvdnav.h (revision 1243) +++ src/dvdnav/dvdnav.h (working copy) @@ -388,6 +388,14 @@
/* + * Find the nearest vobu and jump to it + * + * Alternative to dvdnav_time_search + */ +dvdnav_status_t dvdnav_jump_to_sector_by_time(dvdnav_t *this, + uint64_t time_in_pts_ticks);
tabs, trailing whitespace Diego
Revision 4 fixes a HACK wherein the entire .IFO was reloaded, just to load the time map. So maybe the "caching" is no longer needed/not in there anymore? Just wondering.
This patch also reduces the error messages that were generated in the log output.
Sweet it does indeed. Now people won't be as scared to use my mplayer distro :) Thanks! -r
participants (3)
-
Diego Biurrun -
gnosygnu -
Roger Pack