packaging libdvdnav and libdvdread and [PATCH]
Hi. As some of you might know, I'm responsible for creating RPM packages of some of our software, for example FFmpeg and MPlayer. Some time ago I took over packaging libdvdread and libdvdnav, too. I've already switched to this fork for dvdnav and seeing how things are, I'm preparing to switch to this dvdread as well, when it's forked. Do you have any pointers for packaging? Which dvdnav version should I use, libdvdnav or libdvdnav2? Will there be a website with tarballs? One more thing: it's been brought to my attention that compiling C++ code that uses dvdnav.h header fails, because "this" is a reserved word in C++. Patch attached. Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
Dominik 'Rathann' Mierzejewski wrote:
Hi.
As some of you might know, I'm responsible for creating RPM packages of some of our software, for example FFmpeg and MPlayer. Some time ago I took over packaging libdvdread and libdvdnav, too. I've already switched to this fork for dvdnav and seeing how things are, I'm preparing to switch to this dvdread as well, when it's forked.
it's already forked
Do you have any pointers for packaging?
none
Which dvdnav version should I use, libdvdnav or libdvdnav2?
libdvdnav
Will there be a website with tarballs?
I'm not inclined to do so
One more thing: it's been brought to my attention that compiling C++ code that uses dvdnav.h header fails, because "this" is a reserved word in C++. Patch attached.
Regards, R.
------------------------------------------------------------------------
diff -up libdvdnav-20070503/src/dvdnav.h~ libdvdnav-20070503/src/dvdnav.h --- libdvdnav-20070503/src/dvdnav.h~ 2007-05-03 15:10:56.000000000 +0300 +++ libdvdnav-20070503/src/dvdnav.h 2007-06-08 21:23:33.000000000 +0300 @@ -364,7 +364,7 @@ dvdnav_status_t dvdnav_sector_search(dvd returns the current stream time in PTS ticks as reported by the IFO structures divide it by 90000 to get the current play time in seconds */ -int64_t dvdnav_get_current_time(dvdnav_t *this); +int64_t dvdnav_get_current_time(dvdnav_t *self);
/* * Stop playing the current position and start playback of the title
patch ok
On Sunday, 19 August 2007 at 18:29, Nico Sabbi wrote:
Dominik 'Rathann' Mierzejewski wrote:
Hi.
As some of you might know, I'm responsible for creating RPM packages of some of our software, for example FFmpeg and MPlayer. Some time ago I took over packaging libdvdread and libdvdnav, too. I've already switched to this fork for dvdnav and seeing how things are, I'm preparing to switch to this dvdread as well, when it's forked.
it's already forked
Well, src/dvdread is quite different from upstream dvdread. For example, it's missing cmd_print.[c|h] and the diff is 180K in size even if you don't count the missing files.
Which dvdnav version should I use, libdvdnav or libdvdnav2?
libdvdnav
But this one has internal dvdread, right?
Will there be a website with tarballs?
I'm not inclined to do so
One more thing: it's been brought to my attention that compiling C++ code that uses dvdnav.h header fails, because "this" is a reserved word in C++. Patch attached. [...] patch ok
Applied to both trunks. Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
Dominik 'Rathann' Mierzejewski wrote:
On Sunday, 19 August 2007 at 18:29, Nico Sabbi wrote:
Dominik 'Rathann' Mierzejewski wrote:
Hi.
As some of you might know, I'm responsible for creating RPM packages of some of our software, for example FFmpeg and MPlayer. Some time ago I took over packaging libdvdread and libdvdnav, too. I've already switched to this fork for dvdnav and seeing how things are, I'm preparing to switch to this dvdread as well, when it's forked.
it's already forked
Well, src/dvdread is quite different from upstream dvdread. For example, it's missing cmd_print.[c|h] and the diff is 180K in size even if you don't count the missing files.
indeed, but those files (like ifo_print.c) are needed only to dump the content of the metadata, not to actually play dvds. In any case patch welcome
Which dvdnav version should I use, libdvdnav or libdvdnav2?
libdvdnav
But this one has internal dvdread, right?
the internal dvdread that has been recently promoted by me :)
One more thing: it's been brought to my attention that compiling C++ code that uses dvdnav.h header fails, because "this" is a reserved word in C++. Patch attached.
[...]
patch ok
Applied to both trunks.
thanks
participants (2)
-
Dominik 'Rathann' Mierzejewski -
Nico Sabbi