[PATCH] hop_channel not reset when vm_reset is called
Hi, Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel field. This leads to "Error reading NAV packet." errors on some DVDs because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and read from a file which hasn't yet been opened. The attached patch resets the hop_channel field to zero. Regards, Richard.
On Mon, Jul 1, 2013 at 1:55 AM, Richard <peper03@yahoo.com> wrote:
Hi,
Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel field. This leads to "Error reading NAV packet." errors on some DVDs because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and read from a file which hasn't yet been opened.
The attached patch resets the hop_channel field to zero.
Maybe vm->hop_channel = 0;? Anyone else uncomfortable w/ hop_channel existing in vm_t and vm_position_t? On top of this there is a bunch of code that shows += HOP_SEEK and then hop_channel++. At first look these variables are difficult to understand. I do not see an issue w/ the proposed fix. Thanks E -- Erik Hovland erik@hovland.org http://hovland.org/
On 02/07/13 00:40, Erik Hovland wrote:
On Mon, Jul 1, 2013 at 1:55 AM, Richard <peper03@yahoo.com> wrote:
Hi,
Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel field. This leads to "Error reading NAV packet." errors on some DVDs because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and read from a file which hasn't yet been opened.
The attached patch resets the hop_channel field to zero.
Maybe vm->hop_channel = 0;?
Doh! Sorry, yes! I made the change in Myth's local copy of libdvdnav to ease testing. Obviously typed it out again rather than cut'n'paste. Regards, Richard.
On Tuesday, 02 July 2013 at 11:35, Richard wrote:
On 02/07/13 00:40, Erik Hovland wrote:
On Mon, Jul 1, 2013 at 1:55 AM, Richard <peper03@yahoo.com> wrote:
Hi,
Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel field. This leads to "Error reading NAV packet." errors on some DVDs because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and read from a file which hasn't yet been opened.
The attached patch resets the hop_channel field to zero.
Maybe vm->hop_channel = 0;?
Doh! Sorry, yes! I made the change in Myth's local copy of libdvdnav to ease testing. Obviously typed it out again rather than cut'n'paste.
Applied. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Erik Hovland -
Richard