First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.
On Friday, 13 November 2009 at 23:48, John Stebbins wrote:
First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know.
Nico: ping. Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Friday, 05 March 2010 at 00:27, Dominik 'Rathann' Mierzejewski wrote:
On Friday, 13 November 2009 at 23:48, John Stebbins wrote:
First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know.
Nico: ping.
Ping2. Maybe Erik could comment? Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Thu, Oct 6, 2011 at 5:50 AM, Dominik 'Rathann' Mierzejewski <dominik@greysector.net> wrote:
On Friday, 05 March 2010 at 00:27, Dominik 'Rathann' Mierzejewski wrote:
On Friday, 13 November 2009 at 23:48, John Stebbins wrote:
First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know.
Nico: ping.
Ping2. Maybe Erik could comment?
Great patch. I am pretty sure that MythTV would love to have it in and I am pretty sure that handbrake has been using it for a while. But I would not stick it in for this release unless we are sure we want this kind of change. But, I am more conservative then most. E -- Erik Hovland erik@hovland.org http://hovland.org/
On Thursday, 06 October 2011 at 21:04, Erik Hovland wrote:
On Thu, Oct 6, 2011 at 5:50 AM, Dominik 'Rathann' Mierzejewski <dominik@greysector.net> wrote:
On Friday, 05 March 2010 at 00:27, Dominik 'Rathann' Mierzejewski wrote:
On Friday, 13 November 2009 at 23:48, John Stebbins wrote:
First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know.
Nico: ping.
Ping2. Maybe Erik could comment?
Great patch. I am pretty sure that MythTV would love to have it in and I am pretty sure that handbrake has been using it for a while. But I would not stick it in for this release unless we are sure we want this kind of change. But, I am more conservative then most.
OK, let's skip it for this release, but I'll apply it soon afterwards. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Thursday, 06 October 2011 at 22:53, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 06 October 2011 at 21:04, Erik Hovland wrote:
On Thu, Oct 6, 2011 at 5:50 AM, Dominik 'Rathann' Mierzejewski <dominik@greysector.net> wrote:
On Friday, 05 March 2010 at 00:27, Dominik 'Rathann' Mierzejewski wrote:
On Friday, 13 November 2009 at 23:48, John Stebbins wrote:
First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know.
Nico: ping.
Ping2. Maybe Erik could comment?
Great patch. I am pretty sure that MythTV would love to have it in and I am pretty sure that handbrake has been using it for a while. But I would not stick it in for this release unless we are sure we want this kind of change. But, I am more conservative then most.
OK, let's skip it for this release, but I'll apply it soon afterwards.
Finally applied as r1244. I had to rebase it to current SVN, so please verify if I did it correctly. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Erik Hovland -
John Stebbins