[PATCH] Make sure we get nav packets for all cells in multi angle
Hi, This is a resend of an old patch that we still keep in xbmc's version of libdvdnav. The problem is that libdvdnav jumps over NAV packets when playing multi angle features. I don't remember all the exact details on this patch anymore since it was many years since i tracked it down. But it is very obvious in xbmc since we use nav packet end/start times to correct timestamps. Without the patch we git gaps in nav packets that doesn's exist in the streams. I think i still have a dvd sample that shows the issue. /Joakim
Is it possible to name the mask value used (0x5000)? Otherwise it is just another magic constant that someone will have to know if the check is ever called into question in the future. E On Mon, Oct 31, 2011 at 12:24 PM, Joakim Plate <elupus@ecce.se> wrote:
Hi,
This is a resend of an old patch that we still keep in xbmc's version of libdvdnav. The problem is that libdvdnav jumps over NAV packets when playing multi angle features.
I don't remember all the exact details on this patch anymore since it was many years since i tracked it down. But it is very obvious in xbmc since we use nav packet end/start times to correct timestamps.
Without the patch we git gaps in nav packets that doesn's exist in the streams. I think i still have a dvd sample that shows the issue.
/Joakim _______________________________________________ DVDnav-discuss mailing list DVDnav-discuss@mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss
-- Erik Hovland erik@hovland.org http://hovland.org/
ILVU flag and Unit_End flag from http://dvdnav.mplayerhq.hu/dvdinfo/dsi_pkt.html#ilvu Suppose that should be added to libdvdread in that case.
On Tue, 1 Nov 2011 02:16:41 +0100, Joakim Plate wrote:
ILVU flag and Unit_End flag from http://dvdnav.mplayerhq.hu/dvdinfo/dsi_pkt.html#ilvu
Suppose that should be added to libdvdread in that case.
Here's and updated patch with the flags named. The logic is starting to get back to me now too :) There can be multiple vob units for a single angle in a ILVU block. So dvdnav_get_vobu can't jump the gun and skip to the next ILVU before we have seen the last vobunit of that block. /Joakim
Here's and updated patch with the flags named. The logic is starting to get back to me now too :)
There can be multiple vob units for a single angle in a ILVU block. So dvdnav_get_vobu can't jump the gun and skip to the next ILVU before we have seen the last vobunit of that block.
Good work. This patch is highly likely to be accepted. I currently have it in my tree. Thanks E -- Erik Hovland erik@hovland.org http://hovland.org/
On Wednesday, 02 November 2011 at 23:27, Erik Hovland wrote:
Here's and updated patch with the flags named. The logic is starting to get back to me now too :)
There can be multiple vob units for a single angle in a ILVU block. So dvdnav_get_vobu can't jump the gun and skip to the next ILVU before we have seen the last vobunit of that block.
Good work. This patch is highly likely to be accepted. I currently have it in my tree.
Finally applied. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Erik Hovland -
Joakim Plate