If the start offset points past the last_byte (outside the region read) stop reading PTTs and adjust nr_of_srpts. Fixes Transformers 3 -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
On Thu, Nov 10, 2011 at 1:40 PM, John Stebbins <stebbins@jetheaddev.com> wrote:
If the start offset points past the last_byte (outside the region read) stop reading PTTs and adjust nr_of_srpts.
Fixes Transformers 3
Is there a way to do the patch so it is just the conditional and doesn't have the start declaration and assignment? E -- Erik Hovland erik@hovland.org http://hovland.org/
On 11/11/2011 01:33 PM, Erik Hovland wrote:
If the start offset points past the last_byte (outside the region read) stop reading PTTs and adjust nr_of_srpts.
Fixes Transformers 3 Is there a way to do the patch so it is just the conditional and doesn't have
On Thu, Nov 10, 2011 at 1:40 PM, John Stebbins <stebbins@jetheaddev.com> wrote: the start declaration and assignment?
E
The reason I did this is, in theory, the start offset that is out of range could be the beginning of a title PTT that one of the other offsets points to. We need to avoid modifying it with B2N_32. So I convert the offset, test it, then modify it if the offset is good. I didn't see a better way of doing this. Although one option would be to revert it with another B2N_32 inside the conditional. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
Is there a way to do the patch so it is just the conditional and doesn't have the start declaration and assignment?
E
The reason I did this is, in theory, the start offset that is out of range could be the beginning of a title PTT that one of the other offsets points to. We need to avoid modifying it with B2N_32. So I convert the offset, test it, then modify it if the offset is good. I didn't see a better way of doing this. Although one option would be to revert it with another B2N_32 inside the conditional.
Yeah, I see your point. As long as no one else complains, I will put this patch in my tree. Thanks E -- Erik Hovland http://hovland.org GPG key available by request
On 11/11/2011 05:45 PM, Erik Hovland wrote:
Is there a way to do the patch so it is just the conditional and doesn't have the start declaration and assignment?
E
The reason I did this is, in theory, the start offset that is out of range could be the beginning of a title PTT that one of the other offsets points to. We need to avoid modifying it with B2N_32. So I convert the offset, test it, then modify it if the offset is good. I didn't see a better way of doing this. Although one option would be to revert it with another B2N_32 inside the conditional. Yeah, I see your point. As long as no one else complains, I will put this patch in my tree.
FYI, I just got validation that this fixes Cars 2 as well. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
On Tuesday, 15 November 2011 at 01:28, John Stebbins wrote:
On 11/11/2011 05:45 PM, Erik Hovland wrote:
Is there a way to do the patch so it is just the conditional and doesn't have the start declaration and assignment?
The reason I did this is, in theory, the start offset that is out of range could be the beginning of a title PTT that one of the other offsets points to. We need to avoid modifying it with B2N_32. So I convert the offset, test it, then modify it if the offset is good. I didn't see a better way of doing this. Although one option would be to revert it with another B2N_32 inside the conditional. Yeah, I see your point. As long as no one else complains, I will put this patch in my tree.
FYI, I just got validation that this fixes Cars 2 as well.
Applied to SVN. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Erik Hovland -
John Stebbins