Re: [DVDnav-discuss] Fwd: [PATCH] destdir handling fix
Il Monday 07 April 2008 23:01:16 hai scritto:
---------- Messaggio inoltrato ---------- From: Dominik 'Rathann' Mierzejewski <dominik@greysector.net> To: dvdnav-discuss@mplayerhq.hu Date: Mon, 7 Apr 2008 00:59:12 +0200 Subject: [DVDnav-discuss] [PATCH] destdir handling fix Hi!
The attached patch needs to be applied. Otherwise if you use make DESTDIR=/some/path the specified path ends up in pkgconfig file, which is wrong. DESTDIR should only ever be used upon installing the files.
After it's applied, I'd like to propose making a new (4.1.2?) release. I'll prepare the tarball and write a news entry for MPlayer page if you like.
Regards, R.
it doesn't seem to work because of +DESTDIR = in configure2. If I remove it all is fine, otherwise [nico@xp libdvdnav]$ make install install -d /usr/local/lib install -s -m 755 obj/libdvdnav.so \ /usr/local/lib/libdvdnav.so.4.1.1 install: impossibile rimuovere `/usr/local/lib/libdvdnav.so.4.1.1': Permission denied make: *** [install-shared] Error 1 regardless if I set DESTDIR before or after running ./configure2
On Monday, 07 April 2008 at 23:07, Nico Sabbi wrote:
Il Monday 07 April 2008 23:01:16 hai scritto:
---------- Messaggio inoltrato ---------- From: Dominik 'Rathann' Mierzejewski <dominik@greysector.net> To: dvdnav-discuss@mplayerhq.hu Date: Mon, 7 Apr 2008 00:59:12 +0200 Subject: [DVDnav-discuss] [PATCH] destdir handling fix Hi!
The attached patch needs to be applied. Otherwise if you use make DESTDIR=/some/path the specified path ends up in pkgconfig file, which is wrong. DESTDIR should only ever be used upon installing the files.
After it's applied, I'd like to propose making a new (4.1.2?) release. I'll prepare the tarball and write a news entry for MPlayer page if you like.
Regards, R.
it doesn't seem to work because of
+DESTDIR =
in configure2. If I remove it all is fine, otherwise [nico@xp libdvdnav]$ make install install -d /usr/local/lib install -s -m 755 obj/libdvdnav.so \ /usr/local/lib/libdvdnav.so.4.1.1 install: impossibile rimuovere `/usr/local/lib/libdvdnav.so.4.1.1': Permission denied make: *** [install-shared] Error 1
regardless if I set DESTDIR before or after running ./configure2
Correct, sorry. I'll send an updated patch tonight. Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Tuesday, 08 April 2008 at 12:44, Dominik 'Rathann' Mierzejewski wrote: [...]
Correct, sorry. I'll send an updated patch tonight.
Sorry for the delay, attached. R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
Il Wednesday 09 April 2008 20:08:48 Dominik 'Rathann' Mierzejewski ha scritto:
On Tuesday, 08 April 2008 at 12:44, Dominik 'Rathann' Mierzejewski wrote: [...]
Correct, sorry. I'll send an updated patch tonight.
Sorry for the delay, attached.
R.
it looks coherent, but I have a doubt: if you run ./configure2 without parameters and then $ export DESTDIR=~/dvd $ make install the files will go in ~/dvd/usr/local/bin , ~/dvd/usr/local/lib and ~/dvd/usr/local/include If this is the intended behaviour (that I doubt) then feel free to commit the patch, but if instead the intended paths are (as I suppose) ~/dvd/bin , ~/dvd/lib and ~/dvd/include then the patch is wrong and I guess that it should include something like the following in Makefile: (mind that it's broken, I don't know the Makefile syntax) include config.mak ifneq ($(DESTDIR),"") PREFIX=$(DESTDIR) endif
On Wednesday, 09 April 2008 at 23:18, Nico Sabbi wrote:
Il Wednesday 09 April 2008 20:08:48 Dominik 'Rathann' Mierzejewski ha scritto:
On Tuesday, 08 April 2008 at 12:44, Dominik 'Rathann' Mierzejewski wrote: [...]
Correct, sorry. I'll send an updated patch tonight.
Sorry for the delay, attached.
R.
it looks coherent, but I have a doubt: if you run ./configure2 without parameters and then $ export DESTDIR=~/dvd $ make install the files will go in ~/dvd/usr/local/bin , ~/dvd/usr/local/lib and ~/dvd/usr/local/include If this is the intended behaviour (that I doubt) then feel free to commit the patch,
It's intended. DESTDIR, at least in every case I've seen, is only ever used when building binary packages. Compiled binaries need to be make install'd into a temporary buildroot from which a package is made, for example (used by rpm): make DESTDIR=/var/tmp/foo-1.0-1-root install DESTDIR is not something you use when compiling by hand.
but if instead the intended paths are (as I suppose) ~/dvd/bin , ~/dvd/lib and ~/dvd/include
That's what PREFIX is for.
then the patch is wrong and I guess that it should include something like the following in Makefile: (mind that it's broken, I don't know the Makefile syntax)
include config.mak ifneq ($(DESTDIR),"") PREFIX=$(DESTDIR) endif
I will probably commit the patch tonight, then. Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (2)
-
Dominik 'Rathann' Mierzejewski -
Nico Sabbi