Yesterday I updated dvdnav to r1041. my mplayer is also from yesterday, with --disable-dvdread-internal When playing an arbitrary DVD, with r1041 I get Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (unknown) language: unknown aid: 128. audio stream: 1 format: ac3 (unknown) language: unknown aid: 129. audio stream: 2 format: ac3 (unknown) language: unknown aid: 130. audio stream: 3 format: ac3 (unknown) language: unknown aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: unknown subtitle ( sid ): 1 language: unknown subtitle ( sid ): 2 language: unknown subtitle ( sid ): 3 language: unknown subtitle ( sid ): 4 language: unknown subtitle ( sid ): 5 language: unknown subtitle ( sid ): 6 language: unknown subtitle ( sid ): 7 language: unknown subtitle ( sid ): 8 language: unknown subtitle ( sid ): 9 language: unknown number of subtitles on disk: 10 No matching DVD subtitle language found! MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s) instead of Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (5.1) language: en aid: 128. audio stream: 1 format: ac3 (stereo) language: en aid: 129. audio stream: 2 format: ac3 (stereo) language: de aid: 130. audio stream: 3 format: ac3 (stereo) language: en aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: da subtitle ( sid ): 1 language: de subtitle ( sid ): 2 language: en subtitle ( sid ): 3 language: nl subtitle ( sid ): 4 language: no subtitle ( sid ): 5 language: fi subtitle ( sid ): 6 language: sv subtitle ( sid ): 7 language: en subtitle ( sid ): 8 language: de subtitle ( sid ): 9 language: en number of subtitles on disk: 10 Selected DVD subtitle channel: 2 language: en MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s) with r997 (Since I'm writing this from work, I cannot yet narrow it down to a specific version). Also, this title is a 4:3 full frame video, but is displayed at 16:9 with r1041, r997 plays it fine. And lastly, on one title, after a chapter break, the movie ends (with no chance of jumping further by either -chapter or using PgUp/Dn keys. -- cheers, Alex
On Thursday 15 May 2008 11:54:18 Alexander Roalter wrote:
Yesterday I updated dvdnav to r1041. my mplayer is also from yesterday, with --disable-dvdread-internal
When playing an arbitrary DVD, with r1041 I get
Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (unknown) language: unknown aid: 128. audio stream: 1 format: ac3 (unknown) language: unknown aid: 129. audio stream: 2 format: ac3 (unknown) language: unknown aid: 130. audio stream: 3 format: ac3 (unknown) language: unknown aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: unknown subtitle ( sid ): 1 language: unknown subtitle ( sid ): 2 language: unknown subtitle ( sid ): 3 language: unknown subtitle ( sid ): 4 language: unknown subtitle ( sid ): 5 language: unknown subtitle ( sid ): 6 language: unknown subtitle ( sid ): 7 language: unknown subtitle ( sid ): 8 language: unknown subtitle ( sid ): 9 language: unknown number of subtitles on disk: 10 No matching DVD subtitle language found! MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s)
instead of
Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (5.1) language: en aid: 128. audio stream: 1 format: ac3 (stereo) language: en aid: 129. audio stream: 2 format: ac3 (stereo) language: de aid: 130. audio stream: 3 format: ac3 (stereo) language: en aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: da subtitle ( sid ): 1 language: de subtitle ( sid ): 2 language: en subtitle ( sid ): 3 language: nl subtitle ( sid ): 4 language: no subtitle ( sid ): 5 language: fi subtitle ( sid ): 6 language: sv subtitle ( sid ): 7 language: en subtitle ( sid ): 8 language: de subtitle ( sid ): 9 language: en number of subtitles on disk: 10 Selected DVD subtitle channel: 2 language: en MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s)
with r997 (Since I'm writing this from work, I cannot yet narrow it down to a specific version).
Also, this title is a 4:3 full frame video, but is displayed at 16:9 with r1041, r997 plays it fine.
And lastly, on one title, after a chapter break, the movie ends (with no chance of jumping further by either -chapter or using PgUp/Dn keys.
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote:
On Thursday 15 May 2008 11:54:18 Alexander Roalter wrote:
Yesterday I updated dvdnav to r1041. my mplayer is also from yesterday, with --disable-dvdread-internal
When playing an arbitrary DVD, with r1041 I get
Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (unknown) language: unknown aid: 128. audio stream: 1 format: ac3 (unknown) language: unknown aid: 129. audio stream: 2 format: ac3 (unknown) language: unknown aid: 130. audio stream: 3 format: ac3 (unknown) language: unknown aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: unknown subtitle ( sid ): 1 language: unknown subtitle ( sid ): 2 language: unknown subtitle ( sid ): 3 language: unknown subtitle ( sid ): 4 language: unknown subtitle ( sid ): 5 language: unknown subtitle ( sid ): 6 language: unknown subtitle ( sid ): 7 language: unknown subtitle ( sid ): 8 language: unknown subtitle ( sid ): 9 language: unknown number of subtitles on disk: 10 No matching DVD subtitle language found! MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s)
instead of
Playing dvd://3. libdvdread: Using libdvdcss version 1.2.9 for DVD access There are 5 chapters in this DVD title. There are 17 titles on this DVD. There are 1 angles in this DVD title. audio stream: 0 format: ac3 (5.1) language: en aid: 128. audio stream: 1 format: ac3 (stereo) language: en aid: 129. audio stream: 2 format: ac3 (stereo) language: de aid: 130. audio stream: 3 format: ac3 (stereo) language: en aid: 131. number of audio channels on disk: 4. subtitle ( sid ): 0 language: da subtitle ( sid ): 1 language: de subtitle ( sid ): 2 language: en subtitle ( sid ): 3 language: nl subtitle ( sid ): 4 language: no subtitle ( sid ): 5 language: fi subtitle ( sid ): 6 language: sv subtitle ( sid ): 7 language: en subtitle ( sid ): 8 language: de subtitle ( sid ): 9 language: en number of subtitles on disk: 10 Selected DVD subtitle channel: 2 language: en MPEG-PS file format detected. VIDEO: MPEG2 720x576 (aspect 2) 25.000 fps 9800.0 kbps (1225.0 kbyte/s)
with r997 (Since I'm writing this from work, I cannot yet narrow it down to a specific version).
Also, this title is a 4:3 full frame video, but is displayed at 16:9 with r1041, r997 plays it fine.
And lastly, on one title, after a chapter break, the movie ends (with no chance of jumping further by either -chapter or using PgUp/Dn keys.
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
Thinking back about this, you should've done the reverse, i.e. rename libdvdread copy in MPlayer source tree instead of our new upstream fork. Since there have been no releases in-between, we can still go back. What do you think, Nico? Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Saturday, 26 July 2008 at 14:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote: [...]
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
Thinking back about this, you should've done the reverse, i.e. rename libdvdread copy in MPlayer source tree instead of our new upstream fork. Since there have been no releases in-between, we can still go back. What do you think, Nico?
*ping* Anyone else feel free to weigh in, too... Rationale is: we're the current upstream and we shouldn't break API just because MPlayer's internal copy clashes with upstream. It's MPlayer's copy that should be fixed, not the other way around. This renaming has already caused additional work for other people. If there are no objections, I intend to revert the renaming in two weeks. Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Tue, Aug 19, 2008 at 09:48:04PM +0200, Dominik 'Rathann' Mierzejewski wrote :
On Saturday, 26 July 2008 at 14:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote: [...]
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
Thinking back about this, you should've done the reverse, i.e. rename libdvdread copy in MPlayer source tree instead of our new upstream fork. Since there have been no releases in-between, we can still go back. What do you think, Nico? *ping* Anyone else feel free to weigh in, too... Well, I think I agree with you.
Rationale is: we're the current upstream and we shouldn't break API just because MPlayer's internal copy clashes with upstream. It's MPlayer's copy that should be fixed, not the other way around. This renaming has already caused additional work for other people.
Yes, for us (VLC) we had to change a bit one of our plugins to reflect that change... Best Regards, -- Jean-Baptiste Kempf http://www.jbkempf.com/
On Tue, Aug 19, 2008 at 09:48:04PM +0200, Dominik 'Rathann' Mierzejewski wrote:
Rationale is: we're the current upstream and we shouldn't break API just because MPlayer's internal copy clashes with upstream. It's MPlayer's copy that should be fixed, not the other way around. This renaming has already caused additional work for other people.
IMO: "obviously".
Il giorno mar, 19/08/2008 alle 21.48 +0200, Dominik 'Rathann' Mierzejewski ha scritto:
On Saturday, 26 July 2008 at 14:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote: [...]
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
Thinking back about this, you should've done the reverse, i.e. rename libdvdread copy in MPlayer source tree instead of our new upstream fork. Since there have been no releases in-between, we can still go back. What do you think, Nico?
*ping* Anyone else feel free to weigh in, too...
Rationale is: we're the current upstream and we shouldn't break API just because MPlayer's internal copy clashes with upstream. It's MPlayer's copy that should be fixed, not the other way around. This renaming has already caused additional work for other people.
If there are no objections, I intend to revert the renaming in two weeks.
Regards, R.
sorry, I missed or forgotten your post. Do you want to rename libdvdread as dvdread? why? dvdread is a LIBrary, I don't see why it shouldn't be called libdvdread. It's also another way to distinguish it from the old code. Or did I misunderstand what you mean?
On Wednesday, 20 August 2008 at 20:00, Nico Sabbi wrote:
Il giorno mar, 19/08/2008 alle 21.48 +0200, Dominik 'Rathann' Mierzejewski ha scritto:
On Saturday, 26 July 2008 at 14:55, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote: [...]
I guess it has something to do with the dvdread headers in mplayer's tree that are still defined badly and included instead of the right ones. I'll have to fix this problem renaming dvdread in libdvdread (in mplayer)
Thinking back about this, you should've done the reverse, i.e. rename libdvdread copy in MPlayer source tree instead of our new upstream fork. Since there have been no releases in-between, we can still go back. What do you think, Nico?
*ping* Anyone else feel free to weigh in, too...
Rationale is: we're the current upstream and we shouldn't break API just because MPlayer's internal copy clashes with upstream. It's MPlayer's copy that should be fixed, not the other way around. This renaming has already caused additional work for other people.
If there are no objections, I intend to revert the renaming in two weeks.
sorry, I missed or forgotten your post. Do you want to rename libdvdread as dvdread?
Rename the include path from libdvdread/*.h back to dvdread/*.h, yes. Note that libdvdnav similarly has dvdnav/*.h for public headers.
why? dvdread is a LIBrary, I don't see why it shouldn't be called libdvdread.
I'm not suggesting renaming the library itself.
It's also another way to distinguish it from the old code.
Why do you want to distinguish it from the old code? It's a fork, granted, but it's the only actively developed fork, which makes it upstream.
Or did I misunderstand what you mean?
Apparently, at least partially. So, do you agree to put the include path back to dvdread/*.h? Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Wednesday, 20 August 2008 at 21:03, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 20 August 2008 at 20:00, Nico Sabbi wrote: [...]
sorry, I missed or forgotten your post. Do you want to rename libdvdread as dvdread?
Rename the include path from libdvdread/*.h back to dvdread/*.h, yes. Note that libdvdnav similarly has dvdnav/*.h for public headers.
why? dvdread is a LIBrary, I don't see why it shouldn't be called libdvdread.
I'm not suggesting renaming the library itself.
It's also another way to distinguish it from the old code.
Why do you want to distinguish it from the old code? It's a fork, granted, but it's the only actively developed fork, which makes it upstream.
Or did I misunderstand what you mean?
Apparently, at least partially. So, do you agree to put the include path back to dvdread/*.h?
And here's the patch. If there are no objections, I'm going to apply this on Monday. Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
On Friday, 29 August 2008 at 23:25, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 20 August 2008 at 21:03, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 20 August 2008 at 20:00, Nico Sabbi wrote: [...]
sorry, I missed or forgotten your post. Do you want to rename libdvdread as dvdread?
Rename the include path from libdvdread/*.h back to dvdread/*.h, yes. Note that libdvdnav similarly has dvdnav/*.h for public headers.
why? dvdread is a LIBrary, I don't see why it shouldn't be called libdvdread.
I'm not suggesting renaming the library itself.
It's also another way to distinguish it from the old code.
Why do you want to distinguish it from the old code? It's a fork, granted, but it's the only actively developed fork, which makes it upstream.
Or did I misunderstand what you mean?
Apparently, at least partially. So, do you agree to put the include path back to dvdread/*.h?
And here's the patch. If there are no objections, I'm going to apply this on Monday.
As Nico agreed on the complementary change in MPlayer, I went ahead and applied this. Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (5)
-
Alexander Roalter -
Dominik 'Rathann' Mierzejewski -
Jean-Baptiste Kempf -
Nico Sabbi -
Reimar Doeffinger