[PATCH] Fix pthread check on OS/2
pthread check fails due to -no-undefined of LDFLAGS. gcc4 treats unknown flags as an error unlike gcc3. --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index af429b4..7d3f671 100644 --- a/configure.ac +++ b/configure.ac @@ -72,9 +72,6 @@ AC_C_BIGENDIAN AS_CASE([$host], [*mingw32* | *cygwin*], [AC_CHECK_FUNCS(gettimeofday)]) -AS_CASE([$host], - [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"]) - dnl --------------------------------------------- dnl threads dnl --------------------------------------------- @@ -112,6 +109,9 @@ dnl Check for doxygen (dynamic documentation generator) dnl --------------------------------------------- AC_CHECK_PROG(DOXYGEN, doxygen, doxygen, no) +AS_CASE([$host], + [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"]) + dnl --------------------------------------------- dnl Output configuration files dnl --------------------------------------------- -- 2.11.0
Hello, On Wed, 18 Jan 2017 15:43:07 +0900, KO Myung-Hun wrote:
+AS_CASE([$host], + [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"])
Please don't use *os2* as a wildcard. It matches not only the OS/2 operating system, but also the nios2 CPU architecture, which is completely unrelated. Maybe something like *-os2-* is more appropriate. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Hi/2. Thomas Petazzoni wrote:
Hello,
On Wed, 18 Jan 2017 15:43:07 +0900, KO Myung-Hun wrote:
+AS_CASE([$host], + [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"])
Please don't use *os2* as a wildcard. It matches not only the OS/2 operating system, but also the nios2 CPU architecture, which is completely unrelated. Maybe something like *-os2-* is more appropriate.
Ok, fixed. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
KO Myung-Hun wrote:
Hi/2.
Thomas Petazzoni wrote:
Hello,
On Wed, 18 Jan 2017 15:43:07 +0900, KO Myung-Hun wrote:
+AS_CASE([$host], + [*os2*], [LDFLAGS="$LDFLAGS -no-undefined"])
Please don't use *os2* as a wildcard. It matches not only the OS/2 operating system, but also the nios2 CPU architecture, which is completely unrelated. Maybe something like *-os2-* is more appropriate.
Ok, fixed.
Ping ? -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
On 01/18/2017 07:43 AM, KO Myung-Hun wrote:
pthread check fails due to -no-undefined of LDFLAGS. gcc4 treats unknown flags as an error unlike gcc3.
-no-undefined is a libtool flags, it should not be passed as-is to gcc Here is what I get with gcc 6.2: % gcc -no-undefined gcc: error: unrecognized command line option ‘-no-undefined’; did you mean ‘-Wno-undef’? What is the error you are getting?
Rafaël Carré wrote:
On 01/18/2017 07:43 AM, KO Myung-Hun wrote:
pthread check fails due to -no-undefined of LDFLAGS. gcc4 treats unknown flags as an error unlike gcc3.
-no-undefined is a libtool flags, it should not be passed as-is to gcc
Here is what I get with gcc 6.2:
% gcc -no-undefined gcc: error: unrecognized command line option ‘-no-undefined’; did you mean ‘-Wno-undef’?
What is the error you are getting?
With gcc335 which I used before: # gcc -no-undefined test.c && echo yes || echo no gcc: unrecognized option `-no-undefined' yes With gcc492 which I'm using nowadays: # gcc -no-undefined test.c && echo yes || echo no gcc: error: unrecognized command line option '-no-undefined' no gcc335 ignores unrecognized options, whereas gcc492 treats them as errors. -no-undefined is a libtool flag. However, when building, -no-undefined is passed to libtool not gcc, and libtool processes it first. As a result, -no-undefined is not passed to gcc. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
participants (3)
-
KO Myung-Hun -
Rafaël Carré -
Thomas Petazzoni