[PATCHES] libdvdread and libdvdnav patches
Hi team, First of all, thanks for your great work :) I am the maintainer of FreeBSD ports of libdvdread and libdvdnav and have small patches that you might be interested in, see : For libdvdread : * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread... This first patch adds support for libdatadir option, fixes incdir option and bigendian detection. Some chunks are FreeBSD-only an can be skipped (PREFIX comment, TMPD modification). * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread... This patch uses config.h instead of trying to re-detect endianness. For libdvdnav : * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdnav/... This patch adds support for libdatadir option and bigendian detection. Some chunks are still FreeBSD-only an can be skipped (PREFIX comment, TMPD). Best regards, -- Ganael LAPLANCHE <ganael.laplanche@martymac.org> http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
On 18/01/12 5:53 AM, Ganael LAPLANCHE wrote:
Hi team,
First of all, thanks for your great work :)
I am the maintainer of FreeBSD ports of libdvdread and libdvdnav and have small patches that you might be interested in, see :
For libdvdread :
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread...
This first patch adds support for libdatadir option, fixes incdir option and bigendian detection. Some chunks are FreeBSD-only an can be skipped (PREFIX comment, TMPD modification).
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread...
This patch uses config.h instead of trying to re-detect endianness.
For libdvdnav :
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdnav/...
This patch adds support for libdatadir option and bigendian detection. Some chunks are still FreeBSD-only an can be skipped (PREFIX comment, TMPD).
Thanks for the big endian patches. I ran into this breakage when updating from libdvdread 0.9.7 to the MPlayer projects fork for the OpenBSD ports. Could the relevant pieces in the 3 patches abovee for the big endian fixes please be commited to the SVN repo for each respective project? It's pretty bad this was broken by the MPlayer project. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread...
This first patch adds support for libdatadir option, fixes incdir option and bigendian detection. Some chunks are FreeBSD-only an can be skipped (PREFIX comment, TMPD modification).
I have incorporated the bigendian and incdir fix into my github repo. I will push them to svn soon. Please double check that they both work for you. The --libdatadir stuff is interesting. But if it is just pkgconfig, then that might be a better name for the argument (--pkgconfigdir or --pkg-config). If you submit that patch again against the github repo w/ that change, I am likely to accept it.
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdread...
This patch uses config.h instead of trying to re-detect endianness.
I have incorporated this patch into my github repo. I will push this up to svn soon.
* http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdnav/...
This patch adds support for libdatadir option and bigendian detection. Some chunks are still FreeBSD-only an can be skipped (PREFIX comment, TMPD).
I have incorporated the endian detection into my github repo. Please try it and double check I did it right. Same comment as about about libdatadir. Thanks again for some great patches and pointing out some bad bugs. E -- Erik Hovland erik@hovland.org http://hovland.org/
participants (3)
-
Brad Smith -
Erik Hovland -
Ganael LAPLANCHE