Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111 Log: remove unused #define Modified: trunk/libdvdnav/src/dvdnav.h Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Jul 13 15:17:35 2008 @@ -29,8 +29,6 @@ #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED -#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif
Il giorno dom, 13/07/2008 alle 15.17 +0200, rathann ha scritto:
Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111
Log: remove unused #define
Modified: trunk/libdvdnav/src/dvdnav.h
Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Jul 13 15:17:35 2008 @@ -29,8 +29,6 @@ #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED
-#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif
no, why??? It's needed to tell what version of dvdnav you are using. Please, restore it
On Sunday, 13 July 2008 at 17:20, Nico Sabbi wrote:
Il giorno dom, 13/07/2008 alle 15.17 +0200, rathann ha scritto:
Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111
Log: remove unused #define
Modified: trunk/libdvdnav/src/dvdnav.h
Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Jul 13 15:17:35 2008 @@ -29,8 +29,6 @@ #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED
-#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif
no, why??? It's needed to tell what version of dvdnav you are using.
Could you point me to a place where it is actually checked for? Neither libdvdnav nor MPlayer have any checks that depend on its existence.
Please, restore it
Is it really necessary? Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
Il giorno dom, 13/07/2008 alle 17.23 +0200, Dominik 'Rathann' Mierzejewski ha scritto:
On Sunday, 13 July 2008 at 17:20, Nico Sabbi wrote:
Il giorno dom, 13/07/2008 alle 15.17 +0200, rathann ha scritto:
Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111
Log: remove unused #define
Modified: trunk/libdvdnav/src/dvdnav.h
Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Jul 13 15:17:35 2008 @@ -29,8 +29,6 @@ #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED
-#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif
no, why??? It's needed to tell what version of dvdnav you are using.
Could you point me to a place where it is actually checked for? Neither libdvdnav nor MPlayer have any checks that depend on its existence.
Please, restore it
Is it really necessary?
Regards, R.
I can imagine a software that wants to check the capabilities of the installed dvdnav: in this case that macro is needed (and it doesn't really introduce some nasty hack or limitation)
On Sunday, 13 July 2008 at 18:12, Nico Sabbi wrote:
Il giorno dom, 13/07/2008 alle 17.23 +0200, Dominik 'Rathann' Mierzejewski ha scritto:
On Sunday, 13 July 2008 at 17:20, Nico Sabbi wrote:
Il giorno dom, 13/07/2008 alle 15.17 +0200, rathann ha scritto:
Author: rathann Date: Sun Jul 13 15:17:35 2008 New Revision: 1111
Log: remove unused #define
Modified: trunk/libdvdnav/src/dvdnav.h
Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Jul 13 15:17:35 2008 @@ -29,8 +29,6 @@ #ifndef DVDNAV_H_INCLUDED #define DVDNAV_H_INCLUDED
-#define MP_DVDNAV 1 - #ifdef __cplusplus extern "C" { #endif
no, why??? It's needed to tell what version of dvdnav you are using.
Could you point me to a place where it is actually checked for? Neither libdvdnav nor MPlayer have any checks that depend on its existence.
Please, restore it
Is it really necessary?
Regards, R.
I can imagine a software that wants to check the capabilities of the installed dvdnav: in this case that macro is needed (and it doesn't really introduce some nasty hack or limitation)
As you wish, reverted. Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
participants (3)
-
Dominik 'Rathann' Mierzejewski -
Nico Sabbi -
rathann