Oncaphillis <oncaphillis@snafu.de> wrote:
On 07/14/2012 02:46 PM, Fabian Keil wrote:
I attached the patches that seem to prevent these crashes for me. I'd appreciate comments on whether or not the skip conditions are reasonable, especially the one in patch 3.
Thanks for the effort, but vlc seems to behave the same when applying all three patches
Did you recreate your copies with a different padding strategy that doesn't cause "libdvdnav: demux error! 00 00 00 (should be 0x000001)" messages? Otherwise vlc's behaviour is not expected to be changed by the patches. I believe one way to improve vlc's behaviour without recreating the copies would be to let vlc's dvdnav module handle blocks with unexpected content more gracefully, for example by skipping them instead of rejecting the whole DVD. Letting libdvdnav return the content of a different block nearby behind vlc's back might work as well and could also help other programs. Fabian