September 2015 - DVDnav-discuss - lists.mplayerhq.hu

Fix crashes with some DVDs on describe_title
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 16:00:59 2015 +0200| [8a270d6dd40ac43c98c948fe9d10e5bcb4aa3d41] | committer: Jean-Baptiste Kempf Fix crashes with some DVDs on describe_title This is a stop-over, but the actual issue is not fixed > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=8a270d6dd40ac4… --- src/searching.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/searching.c b/src/searching.c index 70c0f85..f638b61 100644 --- a/src/searching.c +++ b/src/searching.c @@ -644,6 +644,11 @@ uint32_t dvdnav_describe_title_chapters(dvdnav_t *this, int32_t title, uint64_t if(!tmp) goto fail; + if(!ptt) { + printerr("ptt NULL"); + goto fail; + } + length = 0; for(i=0; i<parts; i++) { uint32_t cellnr, endcellnr;

1 0

Fix crashes with some DVDs on describe_title
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 16:00:59 2015 +0200| [25adbf7456a41454e47a0dcf4ed3f0a9fdcf8e20] | committer: Jean-Baptiste Kempf Fix crashes with some DVDs on describe_title This is a stop-over, but the actual issue is not fixed > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=25adbf7456a414… --- src/searching.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/searching.c b/src/searching.c index 70c0f85..4f422d6 100644 --- a/src/searching.c +++ b/src/searching.c @@ -647,6 +647,11 @@ uint32_t dvdnav_describe_title_chapters(dvdnav_t *this, int32_t title, uint64_t length = 0; for(i=0; i<parts; i++) { uint32_t cellnr, endcellnr; + if (ptt[i] == NULL) { + printerr("ptt NULL: %i %i.", i, parts ); + continue; + } + if (ptt[i].pgcn == 0 || ptt[i].pgcn > ifo->vts_pgcit->nr_of_pgci_srp) { printerr("PGCN out of bounds."); continue;

1 0

Fix crashes with some DVDs on describe_title
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 16:00:59 2015 +0200| [d88c77fa205efe880d922b1dd414eaa6d678751d] | committer: Jean-Baptiste Kempf Fix crashes with some DVDs on describe_title This is a stop-over, but the actual issue is not fixed > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=d88c77fa205efe… --- src/searching.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/searching.c b/src/searching.c index 70c0f85..4f422d6 100644 --- a/src/searching.c +++ b/src/searching.c @@ -647,6 +647,11 @@ uint32_t dvdnav_describe_title_chapters(dvdnav_t *this, int32_t title, uint64_t length = 0; for(i=0; i<parts; i++) { uint32_t cellnr, endcellnr; + if (ptt[i] == NULL) { + printerr("ptt NULL: %i %i.", i, parts ); + continue; + } + if (ptt[i].pgcn == 0 || ptt[i].pgcn > ifo->vts_pgcit->nr_of_pgci_srp) { printerr("PGCN out of bounds."); continue;

1 0

[PATCH] src/dvdread/ifo_types.h: fix structure cell_playback_t.
by sayurin 01 Sep '15

01 Sep '15

Structure cell_playback_t is broken because of wrong member size. diff --git a/src/dvdread/ifo_types.h b/src/dvdread/ifo_types.h index 33f0346..8682ab2 100644 --- a/src/dvdread/ifo_types.h +++ b/src/dvdread/ifo_types.h @@ -209,16 +209,16 @@ typedef uint8_t pgc_program_map_t; * Cell Playback Information. */ typedef struct { - unsigned int block_mode : 2; - unsigned int block_type : 2; - unsigned int seamless_play : 1; - unsigned int interleaved : 1; - unsigned int stc_discontinuity: 1; - unsigned int seamless_angle : 1; + unsigned char block_mode : 2; + unsigned char block_type : 2; + unsigned char seamless_play : 1; + unsigned char interleaved : 1; + unsigned char stc_discontinuity: 1; + unsigned char seamless_angle : 1; - unsigned int playback_mode : 1; /**< When set, enter StillMode after each VOBU */ - unsigned int restricted : 1; /**< ?? drop out of fastforward? */ - unsigned int unknown2 : 6; + unsigned char playback_mode : 1; /**< When set, enter StillMode after each VOBU */ + unsigned char restricted : 1; /**< ?? drop out of fastforward? */ + unsigned char unknown2 : 6; uint8_t still_time; uint8_t cell_cmd_nr; dvd_time_t playback_time; -- Kurata Sayuri

2 3

Remove undocumented MP_DVDNAV define
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 15:44:22 2015 +0200| [f7589528d6f60f89d5812db5fac8de9cb1098685] | committer: Jean-Baptiste Kempf Remove undocumented MP_DVDNAV define > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=f7589528d6f60f… --- src/dvdnav/dvdnav.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dvdnav/dvdnav.h b/src/dvdnav/dvdnav.h index 8894fe5..d3729ad 100644 --- a/src/dvdnav/dvdnav.h +++ b/src/dvdnav/dvdnav.h @@ -26,7 +26,6 @@ #ifndef LIBDVDNAV_DVDNAV_H #define LIBDVDNAV_DVDNAV_H -#define MP_DVDNAV 1 #ifdef __cplusplus extern "C" {

1 0

Add a DVDNAV_VERSION code
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 15:44:40 2015 +0200| [a452748d3b9a410bff4237e6d218cdebd463f21c] | committer: Jean-Baptiste Kempf Add a DVDNAV_VERSION code > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=a452748d3b9a41… --- src/dvdnav/dvdnav.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dvdnav/dvdnav.h b/src/dvdnav/dvdnav.h index d3729ad..8d68102 100644 --- a/src/dvdnav/dvdnav.h +++ b/src/dvdnav/dvdnav.h @@ -26,6 +26,7 @@ #ifndef LIBDVDNAV_DVDNAV_H #define LIBDVDNAV_DVDNAV_H +#define DVDNAV_VERSION 50400 #ifdef __cplusplus extern "C" {

1 0

Next update is 5.0.4
by git＠videolan.org 01 Sep '15

01 Sep '15

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Tue Sep 1 15:44:01 2015 +0200| [c9651ff16663d039b2fdf4a5989c5eea35919c2e] | committer: Jean-Baptiste Kempf Next update is 5.0.4 > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=c9651ff16663d0… --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index af3f4fa..af429b4 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ dnl These are defined in m4 so they can be passed to AC_INIT dnl -------------------------------------------------------------- m4_define([dvdnav_major], [5]) m4_define([dvdnav_minor], [0]) -m4_define([dvdnav_sub], [3]) +m4_define([dvdnav_sub], [4]) m4_define([dvdnav_pre], []) AC_INIT([libdvdnav], [dvdnav_major.dvdnav_minor.dvdnav_sub[]dvdnav_pre])

1 0