August 2014 - DVDnav-discuss - lists.mplayerhq.hu

Fix data race condition accessing this->cur_cell_time
by git＠videolan.org 04 Aug '14

04 Aug '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Mon Aug 4 19:32:32 2014 +0200| [866b12ecb085417075db9c003c92507d5b261401] | committer: Jean-Baptiste Kempf Fix data race condition accessing this->cur_cell_time > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=866b12ecb08541… --- src/searching.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/searching.c b/src/searching.c index 81155e3..5a63da6 100644 --- a/src/searching.c +++ b/src/searching.c @@ -1288,12 +1288,12 @@ dvdnav_status_t dvdnav_jump_to_sector_by_time(dvdnav_t *this, /* jump to sector */ sector_off = jump->sector - cell_data->bgn->sector; result = vm_jump_cell_block(this->vm, cell_data->idx, sector_off); + pthread_mutex_lock(&this->vm_lock); this->cur_cell_time = 0; - if (result) { - pthread_mutex_lock(&this->vm_lock); + if (result) { /* vm_jump_cell_block was sucessful */ this->vm->hop_channel += HOP_SEEK; - pthread_mutex_unlock(&this->vm_lock); } + pthread_mutex_unlock(&this->vm_lock); exit: return result;

1 0

Correctly return fails in dvdnav_jump_to_sector_by_time
by git＠videolan.org 04 Aug '14

04 Aug '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Mon Aug 4 19:30:42 2014 +0200| [42403a82415da3e3728cca2272727d2f357609a4] | committer: Jean-Baptiste Kempf Correctly return fails in dvdnav_jump_to_sector_by_time If vm_jump_cell_block failed, we should return fail to dvdnav_jump_to_sector_by_time() call > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=42403a82415da3… --- src/searching.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/searching.c b/src/searching.c index 2421847..81155e3 100644 --- a/src/searching.c +++ b/src/searching.c @@ -1287,12 +1287,12 @@ dvdnav_status_t dvdnav_jump_to_sector_by_time(dvdnav_t *this, /* jump to sector */ sector_off = jump->sector - cell_data->bgn->sector; + result = vm_jump_cell_block(this->vm, cell_data->idx, sector_off); this->cur_cell_time = 0; - if (vm_jump_cell_block(this->vm, cell_data->idx, sector_off)) { + if (result) { pthread_mutex_lock(&this->vm_lock); this->vm->hop_channel += HOP_SEEK; pthread_mutex_unlock(&this->vm_lock); - result = DVDNAV_STATUS_OK; } exit:

1 0

Fix integer overflow
by git＠videolan.org 04 Aug '14

04 Aug '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Mon Aug 4 19:26:30 2014 +0200| [30d3de4f70a8e4ca0a0fcb300630fd28135994cb] | committer: Jean-Baptiste Kempf Fix integer overflow > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=30d3de4f70a8e4… --- src/searching.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/searching.c b/src/searching.c index 0eaa116..2421847 100644 --- a/src/searching.c +++ b/src/searching.c @@ -1089,7 +1089,7 @@ static int32_t dvdnav_tmap_calc_time_for_tmap_entry(dvdnav_jump_args_t *args, } /* calc time of lo */ - time_adj = (uint64_t)((args->tmap_interval * vobu_pct) / 1000); + time_adj = ((uint64_t)args->tmap_interval * vobu_pct) / 1000; *out_time = pos->time - time_adj; return 1; }

1 0

Tag 5.0.0 : libdvdnav 5.0.0
by git＠videolan.org 02 Aug '14

02 Aug '14

[libdvdnav] [branch: refs/tags/5.0.0] Tag: 6ce30f72053d02345f6f0e3eb0200a3fe7136fe9 > http://git.videolan.org/gitweb.cgi/libdvdnav.git?a=tag;h=6ce30f72053d02345f… Tagger: Jean-Baptiste Kempf <jb(a)videolan.org> Date: Fri Aug 1 00:26:36 2014 +0200 libdvdnav 5.0.0 This release is a major version of libdvdnav. This is a very important release focused on cleaning the code, the buildsystem, and fixing potential crashes and security issues. It also adds support for Android and OS/2. It should stay API and ABI compatible with older releases.

1 0