August 2014 - DVDnav-discuss - lists.mplayerhq.hu

Bad Sector copy protection
by Yippee Three-eight 16 Aug '14

16 Aug '14

I've been told that I should post this here as a bug report. I'm running OpenSUSE 13.1, 64-bit as my HTPC. I've been using it for a while without problem. However, recently (after a bunch of package updates) I can no longer play DVDs that contain bad sector copy protection. I had been using VLC. Now, when I try to play one of these DVDs it only works if I go through the VLC menu, select "No disc menus", then I have to select the correct title. Of course, I have to find a way to play the DVD to find out what the title is first as it is a random title number. I've also tried using mplayer from the command line. I get DRI errors and no play. Does anybody have any suggestions on how to fix this? Mike

2 1

On the road to 5.0.1
by git＠videolan.org 15 Aug '14

15 Aug '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Sat Aug 16 01:06:33 2014 +0200| [79354a065eab2f3472253f09a2645d03565257a9] | committer: Jean-Baptiste Kempf On the road to 5.0.1 > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=79354a065eab2f… --- ChangeLog | 3 +++ configure.ac | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 0ca12a1..a8111f8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,6 @@ +libdvdnav (5.0.1) + + libdvdnav (5.0.0) * Android support * fixed numerous crashes, assertions and corruptions diff --git a/configure.ac b/configure.ac index 9f71946..3eff01a 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ dnl These are defined in m4 so they can be passed to AC_INIT dnl -------------------------------------------------------------- m4_define([dvdnav_major], [5]) m4_define([dvdnav_minor], [0]) -m4_define([dvdnav_sub], [0]) +m4_define([dvdnav_sub], [1]) m4_define([dvdnav_pre], []) AC_INIT([libdvdnav], [dvdnav_major.dvdnav_minor.dvdnav_sub[]dvdnav_pre])

1 0

Unknown Command=7
by Marcel J.E. Mol 15 Aug '14

15 Aug '14

Hi all, Got a dvd crashing with the following: libdvdnav: WARNING: Unknown Command=7 /.../git/src/vm/decoder.c:575: eval_command: Assertion `0' failed. I think the message should read 'Unknown Command Type' (posted a patch for it in the mean time), Is command type 7 illegal, or is it something unknown and dvdnav does not know how to cope with it? Kind regards, -Marcel -- ======-------- Marcel J.E. Mol MESA Consulting B.V. =======--------- ph. +31-(0)6-54724868 P.O. Box 112 =======--------- marcel(a)mesa.nl 2630 AC Nootdorp __==== www.mesa.nl ---____U_n_i_x______I_n_t_e_r_n_e_t____ The Netherlands ____ They couldn't think of a number, Linux user 1148 -- counter.li.org so they gave me a name! -- Rupert Hine -- www.ruperthine.com

2 3

Fix for Unknown command type handling
by git＠videolan.org 15 Aug '14

15 Aug '14

libdvdnav | branch: master | Marcel Mol <marcel(a)mesa.nl> | Sat Aug 16 00:36:01 2014 +0200| [298139d90b5736afef4bef4c7f4ae6a895e57bde] | committer: Jean-Baptiste Kempf Fix for Unknown command type handling Some DVDs seem to use command type 7 for something. But it will hit the 'Unknown command' check, resulting in asser(0). I.e. DVD refuses to play. By removing the assert() call the DVD seems to play fine. This patch removes the assert and corrects the error message (it is a 'command type', not a 'command') Signed-off-by: Marcel Mol <marcel(a)mesa.nl> Signed-off-by: Jean-Baptiste Kempf <jb(a)videolan.org> > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=298139d90b5736… --- src/vm/decoder.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/vm/decoder.c b/src/vm/decoder.c index 1e16a9c..bb95562 100644 --- a/src/vm/decoder.c +++ b/src/vm/decoder.c @@ -570,9 +570,8 @@ static int32_t eval_command(uint8_t *bytes, registers_t* registers, link_t *retu if(res) res = -1; break; - default: /* Unknown command */ - fprintf(MSG_OUT, "libdvdnav: WARNING: Unknown Command=%x\n", vm_getbits(&command, 63, 3)); - assert(0); + default: /* Unknown command type */ + fprintf(MSG_OUT, "libdvdnav: WARNING: Unknown Command Type=%x\n", vm_getbits(&command, 63, 3)); } /* Check if there are bits not yet examined */

1 0

Resolve compiler warning (admap_entries should be unsigned int)
by git＠videolan.org 15 Aug '14

15 Aug '14

libdvdnav | branch: master | gnosygnu <gnosygnu(a)gmail.com> | Thu Aug 14 23:01:42 2014 -0400| [7c10f2243c136eb7dfd67e35329b02331726de43] | committer: gnosygnu Resolve compiler warning (admap_entries should be unsigned int) > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=7c10f2243c136e… --- src/searching.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/searching.c b/src/searching.c index 1fd3807..f6e497e 100644 --- a/src/searching.c +++ b/src/searching.c @@ -74,7 +74,7 @@ static dvdnav_status_t dvdnav_scan_admap(dvdnav_t *this, int32_t domain, uint32_ if(admap) { uint32_t address = 0; uint32_t vobu_start, next_vobu = 0; - int admap_entries = (admap->last_byte + 1 - VOBU_ADMAP_SIZE)/VOBU_ADMAP_SIZE; + uint32_t admap_entries = (admap->last_byte + 1 - VOBU_ADMAP_SIZE)/VOBU_ADMAP_SIZE; /* Search through ADMAP for best sector */ vobu_start = SRI_END_OF_CELL;

1 0

Change FP_DOMAIN to DVD_DOMAIN_FirstPlay
by git＠videolan.org 15 Aug '14

15 Aug '14

libdvdnav | branch: master | gnosygnu <gnosygnu(a)gmail.com> | Thu Aug 14 22:44:20 2014 -0400| [da8a809a069c954872391acf7d6c97af1cdbc3a1] | committer: gnosygnu Change FP_DOMAIN to DVD_DOMAIN_FirstPlay > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=da8a809a069c95… --- src/vm/play.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vm/play.c b/src/vm/play.c index c338f1a..f48a199 100644 --- a/src/vm/play.c +++ b/src/vm/play.c @@ -48,7 +48,7 @@ link_t play_PGC(vm_t *vm) { #ifdef TRACE fprintf(MSG_OUT, "libdvdnav: play_PGC:"); - if((vm->state).domain != FP_DOMAIN) { + if((vm->state).domain != DVD_DOMAIN_FirstPlay) { fprintf(MSG_OUT, " (vm->state).pgcN (%i)\n", get_PGCN(vm)); } else { fprintf(MSG_OUT, " first_play_pgc\n"); @@ -88,7 +88,7 @@ link_t play_PGC_PG(vm_t *vm, int pgN) { #ifdef TRACE fprintf(MSG_OUT, "libdvdnav: play_PGC_PG:"); - if((vm->state).domain != FP_DOMAIN) { + if((vm->state).domain != DVD_DOMAIN_FirstPlay) { fprintf(MSG_OUT, " (vm->state).pgcN (%i)\n", get_PGCN(vm)); } else { fprintf(MSG_OUT, " first_play_pgc\n");

1 0

Resolve minor compiler warnings
by git＠videolan.org 15 Aug '14

15 Aug '14

libdvdnav | branch: master | gnosygnu <gnosygnu(a)gmail.com> | Thu Aug 14 22:21:11 2014 -0400| [03cb72be09295686cf1af0af5d8661ab8d35b537] | committer: gnosygnu Resolve minor compiler warnings > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=03cb72be092956… --- src/searching.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/searching.c b/src/searching.c index 5a63da6..1fd3807 100644 --- a/src/searching.c +++ b/src/searching.c @@ -753,7 +753,6 @@ static vobu_admap_t* dvdnav_admap_get(dvdnav_t *this, dvd_state_t *state, /* Get a tmap, tmap_len and tmap_interval */ static vts_tmap_t* dvdnav_tmap_get(dvdnav_t *this, dvd_state_t *state, int32_t *tmap_len, int32_t *tmap_interval) { - int32_t vts_idx = 0; int32_t domain; ifo_handle_t *ifo = NULL; vts_tmapt_t *tmapt = NULL; @@ -762,7 +761,6 @@ static vts_tmap_t* dvdnav_tmap_get(dvdnav_t *this, dvd_state_t *state, vts_tmap_t *tmap = NULL; int32_t result = 0; - vts_idx = state->vtsN; domain = state->domain; switch(domain) { case DVD_DOMAIN_FirstPlay: @@ -870,8 +868,10 @@ static int32_t dvdnav_admap_search(vobu_admap_t *admap, uint32_t admap_len, /* need to add 1 when prv_len == 3 (cur_len shoud go to 2, not 1) */ if (prv_len % 2 == 1) ++cur_len; cur_idx = prv_pos + (cur_len * adj); - if (cur_idx < 0) cur_idx = 0; - else if (cur_idx >= admap_len) cur_idx = admap_len - 1; + if (cur_idx < 0) + cur_idx = 0; + else if (cur_idx >= (int32_t)admap_len) + cur_idx = admap_len - 1; cur_sector = admap->vobu_start_sectors[cur_idx]; if (find_sector < cur_sector) adj = -1; @@ -908,8 +908,10 @@ static int32_t dvdnav_tmap_search(vts_tmap_t *tmap, uint32_t tmap_len, /* need to add 1 when prv_len == 3 (cur_len shoud go to 2, not 1) */ if (prv_len % 2 == 1) ++cur_len; cur_idx = prv_pos + (cur_len * adj); - if (cur_idx < 0) cur_idx = 0; - else if (cur_idx >= tmap_len) cur_idx = tmap_len - 1; + if (cur_idx < 0) + cur_idx = 0; + else if (cur_idx >= (int32_t)tmap_len) + cur_idx = tmap_len - 1; cur_sector = 0; result = dvdnav_tmap_get_entry(tmap, tmap_len, cur_idx, &cur_sector); if (!result) return 0; @@ -1039,7 +1041,7 @@ static int32_t dvdnav_admap_interpolate_vobu(dvdnav_jump_args_t *args, /* HACK: need to add +1, or else will land too soon (not sure why) */ vobu_adj++; vobu_idx = bgn->vobu_idx + vobu_adj; - if (vobu_idx >= args->admap_len) { + if ((int32_t)vobu_idx >= args->admap_len) { fprintf(MSG_OUT, "admap_interpolate: vobu_idx >= admap_len"); return 0; }

1 0

Bug report for specific DVD
by Michael Russo 13 Aug '14

13 Aug '14

I'd like to report a bug in libdvdnav (all versions I've tested up to and including 5.0.0) and I think this is where I should do it. :) I'm not sure how to go about having you guys reproduce it since I can only crash it with a DVD rip a specific movie (The Big Lebowski) and although I'm sure I could get you the ISO it's 8GB... but anyway perhaps you'll have enough info from the gdb crash report. First I compiled libdvdnav-5.0.0 and installed in /usr/local/lib, then set LD_PRELOAD and ran vlc under gdb. The crash happens as soon as it tries to open the ISO file: mike@ossy:/mymedia/Disk Sets/Movies$ export LD_PRELOAD=/usr/local/lib/libdvdnav.so mike@ossy:/mymedia/Disk Sets/Movies$ gdb vlc GNU gdb (Ubuntu 7.7-0ubuntu3.1) 7.7 Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html > This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from vlc...Reading symbols from /usr/lib/debug/.build-id/63/a2c2e7d5b12db4ad69cc38da86622492649af9.debug...done. done. (gdb) run ./THE_BIG_LEBOWSKI.iso Starting program: /usr/bin/vlc ./THE_BIG_LEBOWSKI.iso [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". VLC media player 2.1.4 Rincewind (revision 2.1.4-0-g2a072be) [New Thread 0x7fffec1f6700 (LWP 1123)] [New Thread 0x7ffff7fc3700 (LWP 1124)] [New Thread 0x7fffeb9f5700 (LWP 1125)] [New Thread 0x7fffe8be9700 (LWP 1126)] [0x605118] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface. [New Thread 0x7fffe86dd700 (LWP 1127)] [New Thread 0x7fffc7c12700 (LWP 1141)] [New Thread 0x7fffc7411700 (LWP 1142)] [New Thread 0x7fffbf4ec700 (LWP 1143)] [New Thread 0x7fffbeceb700 (LWP 1144)] [New Thread 0x7fffbe4ea700 (LWP 1145)] [New Thread 0x7fffa9dac700 (LWP 1147)] [Thread 0x7fffeb9f5700 (LWP 1125) exited] [Thread 0x7fffa9dac700 (LWP 1147) exited] [New Thread 0x7fffa9dac700 (LWP 1154)] "sni-qt/1024" WARN 15:03:25.851 void StatusNotifierItemFactory::connectToSnw() Invalid interface to SNW_SERVICE [Thread 0x7fffbe4ea700 (LWP 1145) exited] [New Thread 0x7fffeb9f5700 (LWP 1155)] libdvdnav: Using dvdnav version 5.0.0 libdvdnav: DVD disk reports itself with Region mask 0x00fe0000. Regions: 1 libdvdread: Attempting to retrieve all CSS keys libdvdread: This can take a _long_ time, please be patient libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x0000012d libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x00000df2 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x000042c4 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x001cb2be libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x00224970 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_0.VOB at 0x00229a09 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_1.VOB at 0x0022cedb libdvdread: Elapsed time 0 libdvdread: Found 4 VTS's libdvdread: Elapsed time 0 libdvdnav: Suspected RCE Region Protection!!! Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffeb9f5700 (LWP 1155)] vmEval_CMD (commands=0x7fffd8001200, num_commands=4, registers=registers@entry=0x7fffd8056568, return_values=return_values@entry=0x7fffeb8f6070) at src/vm/decoder.c:590 590 registers_t *registers, link_t *return_values) { (gdb) bt #0 vmEval_CMD (commands=0x7fffd8001200, num_commands=4, registers=registers@entry=0x7fffd8056568, return_values=return_values@entry=0x7fffeb8f6070) at src/vm/decoder.c:590 #1 0x00007ffff7bd0aaa in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:72 #2 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #3 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #4 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #5 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #6 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #7 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #8 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #9 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #10 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #11 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #12 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #13 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #14 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #15 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #16 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #17 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #18 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #19 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #20 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 #21 0x00007ffff7bd099a in play_PG (vm=<optimized out>) at src/vm/play.c:168 #22 0x00007ffff7bd0a79 in play_PGC (vm=vm@entry=0x7fffd8056550) at src/vm/play.c:83 #23 0x00007ffff7bd0b58 in play_PGC_post (vm=0x7fffd8056550) at src/vm/play.c:153 Anything you want me to try here lemme know. Thanks!

2 1

Releases tarballs
by Jean-Baptiste Kempf 05 Aug '14

05 Aug '14

Hello, Here are the tarballs of the releases... DVDnav 5.0.0 ftp://ftp.videolan.org/pub/videolan/libdvdnav/5.0.0/libdvdnav-5.0.0.tar.bz2 DVDread 5.0.0 ftp://ftp.videolan.org/pub/videolan/libdvdread/5.0.0/libdvdread-5.0.0.tar.b… libdvdcss ftp://ftp.videolan.org/pub/videolan/libdvdcss/1.3.0/libdvdcss-1.3.0.tar.bz2 With my kindest regards, -- Jean-Baptiste Kempf http://www.jbkempf.com/ - +33 672 704 734 Sent from my Electronic Device

1 0

libdvdnav / vlc filename parsing issue.
by Gundahar 04 Aug '14

04 Aug '14

I opened up a ticket on this over at videolan.org (#11836) which was promptly closed with only the statement that it was a libdvdnav problem. Issue is the vlc/libdvdnav does not appear to be clean in dealing with file names. If you have a single ISO such as: "Maoyu (2013)-D2.iso" No problems to bring up the menu. Change the name to: "Maoyū (2013)-D2.iso" VLC will refuse to play the file. Change it back and it works again. So it's purely up to the characters in the file name or path that borks the program.

3 4