May 2014 - DVDnav-discuss - lists.mplayerhq.hu

Can't watch DVD
by jan.maske＠abwesend.de 23 May '14

23 May '14

Hi I bought a new DVD, but can't watch it. Using libdvdread 4.2.0 lsdvd eats a lot of memory and gives the following messages: $ lsdvd libdvdread: Using libdvdcss version 1.2.13 for DVD access *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** With a more recent version from git it doesn't use that much memory and outputs just: $ lsdvd *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Can't open ifo 2! And mplayer produces: Playing dvd://2. There are 99 titles on this DVD. There are 1 angles in this DVD title. *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Cannot open the IFO file for DVD title 2. No stream found to handle url dvd://2 I tried it on different computers, so it is not a hardware problem. Only one Window Media Player could actually play it. Any help would be appreciated. Jan

5 6

[PATCH] configure: fix build on NIOS II platform
by Thomas Petazzoni 20 May '14

20 May '14

NIOS II is a CPU architecture from Altera, which uses 'nios2' as the architecture part of the tuple. Unfortunately, 'nios2' matches the current '*os2*' test done by libdvdread's configure script to detect the OS/2 operating system. This leads to build issues as the build process of libdvdread then tries to use OS/2 specific compiler options, that do not exist in the gcc used for Linux/NIOS2. To fix this, this patch makes the test for OS/2 a little bit more specific: in the case of the OS/2 operating system, the OS part of the tuple contains just 'os2' (confirmed by looking at config.guess and config.sub in the gnuconfig project). So using '*-os2-*' will properly match the OS/2 operating system but not the NIOS II architecture. Signed-off-by: Thomas Petazzoni <thomas.petazzoni(a)free-electrons.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9fa0a19..a50766f 100644 --- a/configure.ac +++ b/configure.ac @@ -56,7 +56,7 @@ AS_CASE([$host], [*mingw32* | *cygwin*], [AC_CHECK_FUNCS(gettimeofday)]) AS_CASE([$host], - [*os2*], LDFLAGS="-no-undefined -Zbin-files $LDFLAGS") + [*-os2-*], LDFLAGS="-no-undefined -Zbin-files $LDFLAGS") AC_ARG_WITH([libdvdcss], AS_HELP_STRING([--with-libdvdcss], [Link directly against libdvdcss @<:@default=no@:>@])) -- 1.9.3

3 3

[PATCH] Clean up order of variables, display of output.
by beandog＠gentoo.org 16 May '14

16 May '14

From: Steve Dibb <beandog(a)gentoo.org> Remove redundant check for video_attr. Rearrange checks for attributes to match same order as declarations. Move video unknown string to last displayed, similar to audio output, and use same naming scheme. --- src/ifo_print.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/ifo_print.c b/src/ifo_print.c index 7438aec..2f469dd 100644 --- a/src/ifo_print.c +++ b/src/ifo_print.c @@ -88,10 +88,9 @@ static void ifo_print_video_attributes(video_attr_t *attr) { && attr->video_format == 0 && attr->display_aspect_ratio == 0 && attr->permitted_df == 0 - && attr->unknown1 == 0 && attr->line21_cc_1 == 0 && attr->line21_cc_2 == 0 - && attr->video_format == 0 + && attr->unknown1 == 0 && attr->letterboxed == 0 && attr->film_mode == 0) { printf("-- Unspecified --"); @@ -149,9 +148,6 @@ static void ifo_print_video_attributes(video_attr_t *attr) { printf("(please send a bug report), "); } - printf("U%x, ", attr->unknown1); - /* assert(!attr->unknown1); */ - if(attr->line21_cc_1 || attr->line21_cc_2) { printf("NTSC CC "); if(attr->line21_cc_1) @@ -187,10 +183,13 @@ static void ifo_print_video_attributes(video_attr_t *attr) { } if(attr->film_mode) { - printf("film. "); + printf("film, "); } else { - printf("video. "); //camera + printf("video, "); //camera } + + printf("Unknown1: %x", attr->unknown1); + } static void ifo_print_audio_attributes(audio_attr_t *attr) { @@ -201,9 +200,9 @@ static void ifo_print_audio_attributes(audio_attr_t *attr) { && attr->application_mode == 0 && attr->quantization == 0 && attr->sample_frequency == 0 + && attr->unknown1 == 0 && attr->channels == 0 && attr->lang_extension == 0 - && attr->unknown1 == 0 && attr->unknown3 == 0) { printf("-- Unspecified --"); return; @@ -351,9 +350,9 @@ static void ifo_print_audio_attributes(audio_attr_t *attr) { static void ifo_print_subp_attributes(subp_attr_t *attr) { if(attr->type == 0 - && attr->lang_code == 0 && attr->zero1 == 0 && attr->zero2 == 0 + && attr->lang_code == 0 && attr->lang_extension== 0) { printf("-- Unspecified --"); return; -- 1.8.3.2

1 0

[PATCH] Remain consistent with earlier code in function
by Steve Dibb 15 May '14

15 May '14

From: Steve Dibb <beandog(a)gentoo.org> --- src/dvd_input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dvd_input.c b/src/dvd_input.c index d7e2252..e021098 100644 --- a/src/dvd_input.c +++ b/src/dvd_input.c @@ -321,6 +321,7 @@ int dvdinput_setup(void) fprintf(stderr, "libdvdread: Missing symbols in %s, " "this shouldn't happen !\n", CSS_LIB); dlclose(dvdcss_library); + dvdcss_library = NULL; } } #endif /* HAVE_DVDCSS_DVDCSS_H */ -- 1.8.3.2

1 0

Android contains pthread in the libc
by git＠videolan.org 14 May '14

14 May '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Wed May 14 11:23:10 2014 +0200| [4cc12c9e1ff1255b2703ef25a0c839d08d5800f0] | committer: Jean-Baptiste Kempf Android contains pthread in the libc > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=4cc12c9e1ff125… --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index f99db57..f83aedb 100644 --- a/configure.ac +++ b/configure.ac @@ -80,6 +80,8 @@ case $host in ;; *mingw32* | *cygwin*) ;; + *android*) + ;; *) AC_CHECK_LIB(pthread, pthread_create, [THREAD_LIBS="-lpthread"],

1 0

[PATCH] An IFO without a VTS TMAP is very common, remove warning
by Steve Dibb 13 May '14

13 May '14

Story mode: This error gets printed out a lot when opening DVDs: "libdvdread: No VTS_TMAPT available - skipping.". It's sent by ifoRead_VTS_TMAPT() which is only called on ifoOpen(). ifoOpen doesn't look for the return code of the function, it only uses it to populate data. I ran some tests to see how often something like this shows up. I have a lot of DVDs to run tests against, and am slowly going through my library and getting copies of the IFOs to make it easier. Of 180 DVDs, with a total of 974 IFOs, 245 of them didn't have a VTS TMAP. That's 25%, so it's safe to say that this is a common phenomenon. Patch removes the warning. Patch mode, and hopefully this fixes some previous issues with me sending them: From f598bbdf1a13784e49f5d80f7ecc29139df7e9a2 Mon Sep 17 00:00:00 2001 From: Steve Dibb <beandog(a)gentoo.org> Date: Mon, 12 May 2014 18:34:52 -0600 Subject: [PATCH] An IFO without a VTS TMAP is very common, remove warning --- src/ifo_read.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ifo_read.c b/src/ifo_read.c index 5a67dee..4659136 100644 --- a/src/ifo_read.c +++ b/src/ifo_read.c @@ -1452,9 +1452,8 @@ int ifoRead_VTS_TMAPT(ifo_handle_t *ifofile) { if(!ifofile->vtsi_mat) return 0; - if(ifofile->vtsi_mat->vts_tmapt == 0) { /* optional(?) */ + if(ifofile->vtsi_mat->vts_tmapt == 0) { ifofile->vts_tmapt = NULL; - fprintf(stderr,"libdvdread: No VTS_TMAPT available - skipping.\n"); return 1; } -- 1.8.3.2

1 0

[PATCH] libdvdread: src/ifo_read.c Fix off-by-one error on displaying IFO filename
by Steve Dibb 07 May '14

07 May '14

Fixes incorrect warning: libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). to: libdvdread: Invalid IFO for title 2 (VTS_02_0.BUP). diff --git a/src/ifo_read.c b/src/ifo_read.c index cc6edd7..5a67dee 100644 --- a/src/ifo_read.c +++ b/src/ifo_read.c @@ -305,11 +305,9 @@ ifo_handle_t *ifoOpen(dvd_reader_t *dvd, int title) { } if (title) - snprintf(ifo_filename, 12, "VTS_%02d_0.%s", title, bup_file_opened ? "BUP" : "IFO"); + snprintf(ifo_filename, 13, "VTS_%02d_0.%s", title, bup_file_opened ? "BUP" : "IFO"); else - snprintf(ifo_filename, 12, "VIDEO_TS.%s", bup_file_opened ? "BUP" : "IFO"); - - ifo_filename[12] = '\0'; + snprintf(ifo_filename, 13, "VIDEO_TS.%s", bup_file_opened ? "BUP" : "IFO"); if(!ifofile->file) { fprintf(stderr, "libdvdread: Can't open file %s.\n", ifo_filename); @@ -369,9 +367,9 @@ ifoOpen_try_bup: ifofile->file = DVDOpenFile(dvd, title, DVD_READ_INFO_BACKUP_FILE); if (title) - snprintf(ifo_filename, 12, "VTS_%02d_0.BUP", title); + snprintf(ifo_filename, 13, "VTS_%02d_0.BUP", title); else - strncpy(ifo_filename, "VIDEO_TS.BUP", 12); + strncpy(ifo_filename, "VIDEO_TS.BUP", 13); if (!ifofile->file) { fprintf(stderr, "libdvdread: Can't open file %s.\n", ifo_filename);

1 0

Fix distcheck
by git＠videolan.org 02 May '14

02 May '14

libdvdnav | branch: master | Jean-Baptiste Kempf <jb(a)videolan.org> | Fri May 2 20:17:39 2014 +0200| [f5f8701d386017310cc436ea329bd04a98ca8890] | committer: Jean-Baptiste Kempf Fix distcheck > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=f5f8701d386017… --- Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index fece58e..ddfb124 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,8 +5,6 @@ AM_CPPFLAGS = -I$(top_srcdir)/src $(THREAD_CFLAGS) $(DVDREAD_CFLAGS) dist_doc_DATA = AUTHORS ChangeLog COPYING README TODO EXTRA_DIST = msvc/ \ - src/README.MAP \ - src/FELLOWSHIP.map \ doc/doxy.conf \ doc/mainpage.cpp \ doc/tutorial.cpp \

1 0

Fix C++ compilation issue in the headers
by git＠videolan.org 02 May '14

02 May '14

libdvdnav | branch: master | Thorsten Wilmer <wilmer.thorsten(a)gmail.com> | Thu May 1 15:21:28 2014 +0530| [459b5729475fdc33fe63b2345d7472cb81380888] | committer: Jean-Baptiste Kempf Fix C++ compilation issue in the headers this is a keyword in C++, therefore ... dvdnav/dvdnav.h:93:43: error: expected ‘,’ or ‘...’ before ‘this’ Signed-off-by: Jean-Baptiste Kempf <jb(a)videolan.org> > http://git.videolan.org/gitweb.cgi/libdvdnav.git/?a=commit;h=459b5729475fdc… --- src/dvdnav/dvdnav.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dvdnav/dvdnav.h b/src/dvdnav/dvdnav.h index f9ded31..4254534 100644 --- a/src/dvdnav/dvdnav.h +++ b/src/dvdnav/dvdnav.h @@ -84,7 +84,7 @@ typedef int32_t dvdnav_status_t; dvdnav_status_t dvdnav_open(dvdnav_t **dest, const char *path); dvdnav_status_t dvdnav_dup(dvdnav_t **dest, dvdnav_t *src); -dvdnav_status_t dvdnav_free_dup(dvdnav_t *this); +dvdnav_status_t dvdnav_free_dup(dvdnav_t * _this); /* * Closes a dvdnav_t previously opened with dvdnav_open(), freeing any

1 0