April 2013 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] handle duplicate language units and pgc's more gracefully
by John Stebbins 05 Oct '13

05 Oct '13

This patch never got accepted (probably because it's touches a lot and made you nervous), but HandBrake has been applying this for 3 years now. Some discs have large numbers of repeated language units and pgc's that cause extreme memory consumption and file i/o issues. scanning all the titles on such discs is unusably slow. detect such repeats and ref-count the data structures to avoid reading and storing duplicate info.

6 15

[PATCH] do not close file twice
by Reimar Döffinger 05 Oct '13

05 Oct '13

There is another close further down that will always be reached. Current code will result in a double close. Index: vm/vm.c =================================================================== --- vm/vm.c (revision 1243) +++ vm/vm.c (working copy) @@ -176,7 +176,6 @@ off = lseek( fd, 32 * (off_t) DVD_VIDEO_LB_LEN, SEEK_SET ); if( off == ( 32 * (off_t) DVD_VIDEO_LB_LEN ) ) { off = read( fd, data, DVD_VIDEO_LB_LEN ); - close(fd); if (off == ( (off_t) DVD_VIDEO_LB_LEN )) { fprintf(MSG_OUT, "libdvdnav: DVD Title: "); for(i=25; i < 73; i++ ) {

5 13

[PATCH] fix dvdnav_convert_time to work for full range
by Reimar Döffinger 05 Oct '13

05 Oct '13

Hello, currently the calculation will use int and thus overflow for anything larger or equal to 20 hours. Not sure if this is the best/nicest way, personally I prefer to do this kind of thing with the result = hour >> 4; result *= 10; result += hour; result *= 6; result += minute >> 4; result *= 10; .... scheme, but this is the minimal change required. Index: dvdnav.c =================================================================== --- dvdnav.c (revision 1243) +++ dvdnav.c (working copy) @@ -203,7 +203,7 @@ int64_t result; int64_t frames; - result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000; + result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000ull; result += (time->hour & 0x0f) * 60 * 60 * 90000; result += (time->minute >> 4 ) * 10 * 60 * 90000; result += (time->minute & 0x0f) * 60 * 90000;

3 2

[patch] Fix SIGSEGV in dvdnav_describe_title_chapters
by Sylvain HENRY 05 Oct '13

05 Oct '13

Hi, Please consider checking and applying the attached patch. It fixes a segfault occuring with some DVDs. It seems to be the same problem as the one mentionned here: https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/934471 In my case, "cellnr" and "endcellnr" variables were set to 0 when the crash occured. Cheers Sylvain PS: I'm not registered on the mailing-list, please answer directly to me if necessary

3 8

Re: [DVDnav-discuss] Error in libdvdnav when reading iso images
by Fabian Keil 05 Oct '13

05 Oct '13

Oncaphillis wrote in http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2012-May/001722.html: > I used to create DVD iso images via k3b and played them via VLC. > With isos of relatively newly released DVD this stops to work and > VLC fails with the message > > libdvdnav: demux error! 00 00 00 (should be 0x000001) > > Playing directly from /dev/dvd still works > > The distro is Fedora16 > + k3b == 2.0.2 > + libdvdcss == 1.2.11 ( I also tested 1.2.12) > + vlc = 1.1.13 > + libdvdnav 4.1.4. I also tried the current SVN build > > I get the same error when playing with mplayer and > I also tried brasero for iso creation. > > Since direct play works it seems like brasero/k3b have > problems to create a proper iso and the problems sits > somewhere in the libs. The above message can be generated when the ripping program has generously padded regions with unreadable sectors with binary zeros and one of the padded blocks is actually referenced in the ifos. In this case it's not the result of a bug in the libs (assuming you meant libdvdnav or libdvdread) but the result of a limitation in the program that is using them in combination with companies that interpret the relevant standards somewhat liberal. I'm not familiar with k3b or brasero and thus don't know if this is the cause of the issue, but at least it would explain why the real disc works and the copy doesn't. I've never seen the issue with discs that haven't obviously been mastered incorrectly, but I suppose it can also happen if the disc is scratched. In my experience, copies of intentionally incorrectly mastered discs that cause this issue when padding with zeroes, can usually be played correctly with VLC when padding with other blocks from the region that have been read correctly instead. It's not perfect, but can be sufficient to solve the issue. I'm still experimenting with this, though. With some of those copies I can trigger at least four different crashes in libdvdnav 4.2.0's dvdnav_describe_title_chapters(), that aren't triggered when ripping with zero padding which lets VLC rejects the disc right away. Recent VLC versions use this function, but one can work around it by undefining HAVE_DVDNAV_DESCRIBE_TITLE_CHAPTERS. VLC 1.1.3 doesn't seem to use the function yet and thus correctly plays the copies out of the box (I only confirmed the latter). One of these issues has already been fixed after the libdvdnav 4.2.0 release (https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/934471) but as far as I can tell the others still exist, or at least don't seem to be fixed in https://github.com/microe/libdvdnav and I haven't seen them mentioned when crawling the archives either. I attached the patches that seem to prevent these crashes for me. I'd appreciate comments on whether or not the skip conditions are reasonable, especially the one in patch 3. Note that I ran into the issues with copies where I now know that the padding has been done somewhat sloppy. I haven't tested yet if these crashes can be reached by playing the original discs. If not, I suspect that with a fancier padding algorithms the copies might play correctly as well. Fabian

4 4

[PATCH] Sanitize PTT start offsets
by John Stebbins 05 Oct '13

05 Oct '13

If the start offset points past the last_byte (outside the region read) stop reading PTTs and adjust nr_of_srpts. Fixes Transformers 3 -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7

3 5

[PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 5: combined args to structs)
by gnosygnu 29 Jul '13

29 Jul '13

This revision includes the following changes: 1) combined multiple arguments into structures (See dvdnav_pos_data_t, dvdnav_cell_data_t, dvdnav_jump_args_t) 2) changed multi-line statements to remove leading commas 3) removed tabs/trailing whitespace 4) replaced "discontinuity tmap indexes" approach with simpler "use entry sector of current cell" to handle DVDs with initial dummy cells. Thanks to all who have read through the patch and/or offered comments. As far as I know, there are no other known pending changes/requests. I am hoping that this patch is at a near-final state. Please let me know what else should be done to get this patch accepted. Thanks.

3 19

r1257 - trunk/libdvdread/src/dvd_input.c
by diego 28 Apr '13

28 Apr '13

Author: diego Date: Sun Apr 28 21:10:07 2013 New Revision: 1257 Log: Add #define for DVDCSS_SEEK_KEY to allow compilation without dvdcss.h. Modified: trunk/libdvdread/src/dvd_input.c Modified: trunk/libdvdread/src/dvd_input.c ============================================================================== --- trunk/libdvdread/src/dvd_input.c Thu Mar 21 20:23:12 2013 (r1256) +++ trunk/libdvdread/src/dvd_input.c Sun Apr 28 21:10:07 2013 (r1257) @@ -61,6 +61,7 @@ static int (*DVDcss_close) (dvdcss_ static int (*DVDcss_seek) (dvdcss_t, int, int); static int (*DVDcss_read) (dvdcss_t, void *, int, int); static char * (*DVDcss_error) (dvdcss_t); +#define DVDCSS_SEEK_KEY (1 << 1) #endif /* The DVDinput handle, add stuff here for new input methods. */

1 0

[PATCH] ifo_read.c: DVDs created by LG RC590M violate `vmgi_mat->zero_3 == 0`
by Paul Menzel 28 Apr '13

28 Apr '13

Date: Sun, 28 Apr 2013 12:28:33 +0200 DVDs created with the VDR-to-DVD device LG RC590M display some warnings. $ dvdbackup -M -i /dev/sr0 -o /tmp libdvdread: Encrypted DVD support unavailable. ************************************************ ** ** ** No css library available. See ** ** /usr/share/doc/libdvdread4/README.css ** ** for more information. ** ** ** ************************************************ *** Zero check failed in ifo_read.c:570 for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000 *** Zero check failed in ifo_read.c:570 for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000 *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** […] Add a comment about the first warning to the source code. --- libdvdread/src/ifo_read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index 5c89831..0de9506 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -568,6 +568,8 @@ static int ifoRead_VMG(ifo_handle_t *ifofile) { CHECK_ZERO(vmgi_mat->zero_1); CHECK_ZERO(vmgi_mat->zero_2); + /* DVDs created by VDR-to-DVD device LG RC590M violate the following check with + * vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000. */ CHECK_ZERO(vmgi_mat->zero_3); CHECK_ZERO(vmgi_mat->zero_4); CHECK_ZERO(vmgi_mat->zero_5); -- 1.7.10.4

1 0

[PATCH] ifo_read.c: DVDs created by LG RC590M violate `n % 4 == 0`
by Paul Menzel 28 Apr '13

28 Apr '13

Date: Sun, 28 Apr 2013 12:25:38 +0200 DVDs created with the VDR-to-DVD device LG RC590M display some warnings. $ dvdbackup -M -i /dev/sr0 -o /tmp libdvdread: Encrypted DVD support unavailable. ************************************************ ** ** ** No css library available. See ** ** /usr/share/doc/libdvdread4/README.css ** ** for more information. ** ** ** ************************************************ *** Zero check failed in ifo_read.c:570 for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000 *** Zero check failed in ifo_read.c:570 for vmgi_mat->zero_3 = 0x00000000010000000000000000000000000000 *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1232 *** *** for n % 4 == 0 *** Add a comment about the second warning to the source code. --- To see how widespread that error is, maybe the value of `i` and `n` should be printed and the user be asked to report that to the dvdnav list? libdvdread/src/ifo_read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index c8f3194..5c89831 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -1211,6 +1211,7 @@ int ifoRead_VTS_PTT_SRPT(ifo_handle_t *ifofile) { Titles with 0 PTTs. */ if(n < 0) n = 0; + /* DVDs created by the VDR-to-DVD device LG RC590M violate the following requirement */ CHECK_VALUE(n % 4 == 0); vts_ptt_srpt->title[i].nr_of_ptts = n / 4; -- 1.7.10.4

1 0