March 2013 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH][libdvdread] remove needless _LIBC checks from libdvdread
by Erik Auerswald 31 Dec '13

31 Dec '13

Hi, the first attached patch removes preprocessor checks for _LIBC, because libdvdread is not GNU Libc and does never #define _LIBC. The compiled objects stay the same (checked with md5sum (without debugging info: ./configure2 --disable-debug)). I have tested this patch (that is, the md5.[ch] changes) with MPlayer from svn as well, works the same as before. I did not re-indent the nested #if construct in the 2nd and 3rd hunks of the src/md5.h changes to ease review. This should be done after applying this patch. You can use the second attached patch to do this (use patch -p1). Applying this patch results in cleaner code, which should help in maintaining it. Additionally, a -Wundef warning in MPlayer (from svn) compilation is fixed. This is a more comprehensive than my first proposed patch (see http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2013-January/001862.html) and replaces it. Thanks, Erik

2 3

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5

dvdnav SEGFAULT patch for broken DVD
by Vincent Mussard 12 Nov '13

12 Nov '13

Dear all Maybe it will be useful for someone. Please find attached a patch I made, gathering patch made by other people (especialy from Fabian Keil in an email from Sat, 14 Jul 2012). I added on it an additionnal check (ptt[i].pgcn-1 >= ifo->vts_pgcit->nr_of_pgci_srp) that helps reading one of my broken ripped DVD. Regards Vincent

3 2

[PATCH] workaround a crash.
by Ivan Kalvachev 11 Nov '13

11 Nov '13

A user came in irc #mplayer complaining that dvdnav crashes with a number of programs (VLC included). He did manage to provide a detailed backtrace. Here is a part of it: -- *** libdvdread: CHECK_VALUE failed in ifo_read.c:914 *** *** for pgc->program_map_offset != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:916 *** *** for pgc->cell_position_offset != 0 *** [...] dvdnav_describe_title_chapters (this=0x7fffd0006e00, title=<optimized out>, times= 0x7fffd7b0f018, duration=0x7fffd7b0f010) at searching.c:625 625 cellnr = pgc->program_map[ptt[i].pgn-1]; -- Thanks to that report I made quick workaround that seems to avoid the crash. Patch attached to the mail. I have asked the user to compare the .IFO and . BUP files in case the .IFO is intentionally broken as some DRM scheme, but they seem to have the same checksums. The user also provided the .BUP file and I can forward it off-list, in case somebody wants to investigate. The source seems to be original disk of "the dictator". Best Regards Ivan Kalvachev iive

2 1

[PATCH] Fix packed structures with mingw gcc >= 4.7
by John Stebbins 11 Nov '13

11 Nov '13

As of gcc 4.7, structures are packed in a "MS compatible" format by default. If you want the correct behavior, you must add -mno-ms-bitfields to CFLAGS :-\ --- configure.ac | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/configure.ac b/configure.ac index 30cab8d..fbd5fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -163,6 +163,15 @@ case $host in AC_SUBST(DYNAMIC_LD_LIBS) fi LDFLAGS="-no-undefined $LDFLAGS" + if test "$GCC" = "yes" ; then + gcc_version="`$CC -dumpversion`" + gcc_version_major=$(echo $gcc_version | cut -d"." -f1) + gcc_version_minor=$(echo $gcc_version | cut -d"." -f2) + gcc_version_patch=$(echo $gcc_version | cut -d"." -f3) + if test $gcc_version_major -ge 4 -a $gcc_version_minor -ge 7 ; then + CFLAGS="-mno-ms-bitfields $CFLAGS" + fi + fi ;; *cygwin*) LDFLAGS="-no-undefined $LDFLAGS" -- 1.7.11.7

4 6

[PATCH] Fix undefined variable warning in md5.h
by Erik Auerswald 06 Oct '13

06 Oct '13

Hi, the attached patch fixes a -Wundef warning when compiling the current svn version of libdvdread4 (as part of MPlayer) in the obvious way: $ make cc -MD -MP -Ilibdvdread4 -D_GNU_SOURCE -Ilibdvdcss -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I. -Iffmpeg -D_REENTRANT -I/usr/include/directfb -I/usr/include/ -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/dirac -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4 -c -o libdvdread4/dvd_reader.o libdvdread4/dvd_reader.c In file included from libdvdread4/dvd_reader.c:71:0: libdvdread4/md5.h:26:30: warning: "_LIBC" is not defined [-Wundef] cc -MD -MP -Ilibdvdread4 -D_GNU_SOURCE -Ilibdvdcss -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I. -Iffmpeg -D_REENTRANT -I/usr/include/directfb -I/usr/include/ -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/dirac -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4 -c -o libdvdread4/md5.o libdvdread4/md5.c In file included from libdvdread4/md5.c:28:0: libdvdread4/md5.h:26:30: warning: "_LIBC" is not defined [-Wundef] Please consider applying. Fix one warning every day. ;-) Thanks, Erik

2 1

[PATCH] Spelling
by Benjamin Kerensa 06 Oct '13

06 Oct '13

Index: src/ifo_print.c =================================================================== --- src/ifo_print.c (revision 1250) +++ src/ifo_print.c (working copy) @@ -1189,10 +1189,10 @@ if(ifohandle->menu_vobu_admap) { ifoPrint_VOBU_ADMAP(ifohandle->menu_vobu_admap); } else { - printf("No Menu VOBU address map present\n"); + printf("No Menu VOBU Address map present\n"); } - printf("\nCell Adress table\n"); + printf("\nCell Address table\n"); printf( "-----------------\n"); ifoPrint_C_ADT(ifohandle->vts_c_adt);

2 1

[PATCH] use newer dll name
by Roger Pack 06 Oct '13

06 Oct '13

For some reason on windows the dll name these days is almost always libdvdcss-2.dll instead of libdvdcss.dll (gstreamer, xbmc, etc.) This patch seems to work, and would make it to match, which seems better from my vantage. -roger-

5 7

assertion failure with certain DVD's
by Roger Pack 06 Oct '13

06 Oct '13

Hello all. I get the following assertion playing the "Tangled" DVD with mplayer and an up to date libdvdnav, on windows: Assertion failed: (vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0, file libdvdnav/vm/vm.c, line 1141 The weird part about this is that in mac/linux, I get this error message, and no failed assertion, and playing continues: libdvdnav: Invalid angle block I'd be happy to send more information, or a (legal) DVD to keep, for any developer that would like to tackle it. It appears that it happens with a few other (Disney?) DVD's, as well: http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-December/075458.html https://trac.handbrake.fr/ticket/125 https://forum.handbrake.fr/viewtopic.php?f=11&t=14189 So I'm guessing it's a libdvdnav bug. As a note, in VLC on windows, this causes playback to "loop" over - cellN=2 over and over, though it doesn't crash--I'm guessing it just swallows the assertion failure, or the failure isn't enabled with that build. Thanks. -roger-

4 8

[PATCH] fix dvdnav.h comment
by Roger Pack 06 Oct '13

06 Oct '13

I believe dvdnav_time_search *is* implemented, just somewhat inaccurately, so patch attempts to update comment in this regard. Thanks. -roger-

2 1