December 2013 - DVDnav-discuss - lists.mplayerhq.hu

Can't watch DVD
by jan.maske＠abwesend.de 23 May '14

23 May '14

Hi I bought a new DVD, but can't watch it. Using libdvdread 4.2.0 lsdvd eats a lot of memory and gives the following messages: $ lsdvd libdvdread: Using libdvdcss version 1.2.13 for DVD access *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** With a more recent version from git it doesn't use that much memory and outputs just: $ lsdvd *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Can't open ifo 2! And mplayer produces: Playing dvd://2. There are 99 titles on this DVD. There are 1 angles in this DVD title. *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Cannot open the IFO file for DVD title 2. No stream found to handle url dvd://2 I tried it on different computers, so it is not a hardware problem. Only one Window Media Player could actually play it. Any help would be appreciated. Jan

5 6

New release
by Timothy Gu 13 Feb '14

13 Feb '14

Hi all, It's quite some time before the last release. There are some critical security fixes in SVN now. I guess it should be time for a new release. Also, if possible, can someone back port changes in the VideoLAN's fork to the official one? Thanks. Timothy

7 20

[PATCH][libdvdread] remove needless _LIBC checks from libdvdread
by Erik Auerswald 31 Dec '13

31 Dec '13

Hi, the first attached patch removes preprocessor checks for _LIBC, because libdvdread is not GNU Libc and does never #define _LIBC. The compiled objects stay the same (checked with md5sum (without debugging info: ./configure2 --disable-debug)). I have tested this patch (that is, the md5.[ch] changes) with MPlayer from svn as well, works the same as before. I did not re-indent the nested #if construct in the 2nd and 3rd hunks of the src/md5.h changes to ease review. This should be done after applying this patch. You can use the second attached patch to do this (use patch -p1). Applying this patch results in cleaner code, which should help in maintaining it. Additionally, a -Wundef warning in MPlayer (from svn) compilation is fixed. This is a more comprehensive than my first proposed patch (see http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2013-January/001862.html) and replaces it. Thanks, Erik

2 3

libdvdread/libdvdnav 4.2.1 release candidate 2
by Dominik 'Rathann' Mierzejewski 24 Dec '13

24 Dec '13

Hello, I've just uploaded the second release candidate tarballs for 4.2.1 releases of libdvdread and libdvdnav: http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.1-rc2.tar.xz http://dvdnav.mplayerhq.hu/releases/libdvdread-4.2.1-rc2.tar.xz Please test and report back. If there are no issues, these will become the final releases in a few days. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 2

[ANNOUNCE] libdvdread/libdvdnav 4.2.1 release
by Dominik 'Rathann' Mierzejewski 24 Dec '13

24 Dec '13

Dear all, Just in time for Christmas, we are announcing a new release. We fixed memory leaks, playback issues and a lot of crashes on badly mastered or "copy protected" DVDs. I wish to thank all contributors who submitted patches and did the testing. Keep up the good work! We wish you a Merry Christmas and a Happy New Year! Download links for the 4.2.1 release are below: http://dvdnav.mplayerhq.hu/releases/libdvdread-4.2.1.tar.xz http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.1.tar.xz Enjoy! Best regards, Dominik Mierzejewski -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

5 6

r1292 - in trunk/libdvdnav: configure.ac configure2
by rathann 19 Dec '13

19 Dec '13

Author: rathann Date: Thu Dec 5 00:51:38 2013 New Revision: 1292 Log: check pkg-config before xxx-config Based on a patch by Mike Frysinger <vapier AT gentoo DOT org> configure2 equivalent by myself Modified: trunk/libdvdnav/configure.ac trunk/libdvdnav/configure2 Modified: trunk/libdvdnav/configure.ac ============================================================================== --- trunk/libdvdnav/configure.ac Thu Dec 5 00:02:01 2013 (r1291) +++ trunk/libdvdnav/configure.ac Thu Dec 5 00:51:38 2013 (r1292) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,25 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], [dnl User didn't specify program, search PATH AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) test "x$DVDREAD_CONFIG" = xno && \ AC_MSG_ERROR([dvdread-config required to link with libdvdread]) ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS]) Modified: trunk/libdvdnav/configure2 ============================================================================== --- trunk/libdvdnav/configure2 Thu Dec 5 00:02:01 2013 (r1291) +++ trunk/libdvdnav/configure2 Thu Dec 5 00:51:38 2013 (r1292) @@ -48,7 +48,8 @@ show_help(){ SHARED=yes STATIC=yes -DVDREAD_CONFIG=dvdread-config +DVDREAD_CONFIG="" +DVDREAD_PKG_CONFIG="pkg-config dvdread" PREFIX=/usr/local/ INSTALLSTRIP=-s USEDEBUG=-g @@ -104,8 +105,14 @@ test -z "$shlibdir" && shlibdir=$PREFIX/ test -z "$incdir" && incdir=$PREFIX/include/dvdnav dvdread=no +if test -z "$DVDREAD_CONFIG" ; then +DVDREAD_CONFIG="pkg-config dvdread" +$DVDREAD_CONFIG --exists >> /dev/null 2>&1 && dvdread=yes +fi +if test "$dvdread" != "yes" ; then +DVDREAD_CONFIG=dvdread-config $DVDREAD_CONFIG --prefix >> /dev/null 2>&1 && dvdread=yes -test "$dvdread" != "yes" && $DVDREAD_CONFIG --exists >> /dev/null 2>&1 && dvdread=yes +fi if test "$dvdread" != "yes" ; then echo "$DVDREAD_CONFIG returned an error. Can't proceed" exit 1

3 2

r1294 - trunk/libdvdnav/configure2
by rathann 19 Dec '13

19 Dec '13

Author: rathann Date: Thu Dec 19 22:43:15 2013 New Revision: 1294 Log: Allow specifying custom pkg-config. Use pkg-config by default, but allow override by setting PKG_CONFIG environment variable. Update --help output correspondigly. Based on an idea by Mike Frysinger <vapier AT gentoo DOT org>. Modified: trunk/libdvdnav/configure2 Modified: trunk/libdvdnav/configure2 ============================================================================== --- trunk/libdvdnav/configure2 Thu Dec 5 00:52:30 2013 (r1293) +++ trunk/libdvdnav/configure2 Thu Dec 19 22:43:15 2013 (r1294) @@ -5,6 +5,7 @@ dvdnav_sh_major=`echo $dvdnav_sh_version cc=gcc make=make +: ${PKG_CONFIG:=pkg-config} # find source path source_path="`dirname \"$0\"`" @@ -43,13 +44,15 @@ show_help(){ echo "Developer options:" echo " --disable-strip disable stripping of executables and shared libraries" echo " --disable-opts disable compiler optimizations" + echo "Environment variables:" + echo " PKG_CONFIG use specified pkg-config [$PKG_CONFIG]" exit 1 } SHARED=yes STATIC=yes DVDREAD_CONFIG="" -DVDREAD_PKG_CONFIG="pkg-config dvdread" +DVDREAD_PKG_CONFIG="${PKG_CONFIG} dvdread" PREFIX=/usr/local/ INSTALLSTRIP=-s USEDEBUG=-g @@ -106,7 +109,7 @@ test -z "$incdir" && incdir=$PREFIX/incl dvdread=no if test -z "$DVDREAD_CONFIG" ; then - DVDREAD_CONFIG="pkg-config dvdread" + DVDREAD_CONFIG=${DVDREAD_PKG_CONFIG} $DVDREAD_CONFIG --exists >> /dev/null 2>&1 && dvdread=yes fi if test "$dvdread" != "yes" ; then

1 0

dvdread patch for gcc 4.7+ and mingw
by Roger Pack 12 Dec '13

12 Dec '13

Hello. As a note, dvdread if compiled using mingw or cross compiled for windows, seems to fail with all sorts of failure messages. This patch (from the vlc team [1], thanks!) seems necessary there: https://raw.github.com/rdp/ffmpeg-windows-build-helpers/master/patches/dvdr… I'm not sure if it affects other OS's or not. I "think" the problem stems from gcc packing structures differently with 4.7+ though I'm not certain [2] . All I really know is that, for windows with gcc 4.8, it fails without this patch and works with it. Thank you, thought I'd mention it since there was a recent call for trivial patches. -roger- [1] https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/rules.mak#L… and https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/dvdread-win… [2] http://www.bttr-software.de/forum/mix_entry.php?id=11767 apparently -mms-bitfields became default with gcc 4.7

2 4

[PATCH] libdvdread/src/ifo_read.c: Format fraction as float and update error message
by Paul Menzel 05 Dec '13

05 Dec '13

Date: Mon, 18 Nov 2013 16:54:51 +0100 GCC 4.8.2 and Clang 3.4 both warn about a format mismatch. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -mno-ms-bitfields -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o ifo_read.c: In function 'ifoRead_TT_SRPT': ifo_read.c:1078:13: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=] info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); libtool: compile: clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o ifo_read.c:1078:13: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat] info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by actually displaying the float value and by updating the error message. --- libdvdread/src/ifo_read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index 36545ce..5640e0a 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -1074,8 +1074,8 @@ int ifoRead_TT_SRPT(ifo_handle_t *ifofile) { } if(tt_srpt->nr_of_srpts>info_length/sizeof(title_info_t)){ - fprintf(stderr,"libdvdread: data mismatch: info_length (%ld)!= nr_of_srpts (%d). Truncating.\n", - info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); + fprintf(stderr,"libdvdread: data mismatch: info_length/sizeof(title_info_t) (%f)!= nr_of_srpts (%d). Truncating.\n", + info_length * 1.0/sizeof(title_info_t),tt_srpt->nr_of_srpts); tt_srpt->nr_of_srpts=info_length/sizeof(title_info_t); } -- 1.8.4.3

3 3

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5