November 2013 - DVDnav-discuss - lists.mplayerhq.hu

Can't watch DVD
by jan.maske＠abwesend.de 23 May '14

23 May '14

Hi I bought a new DVD, but can't watch it. Using libdvdread 4.2.0 lsdvd eats a lot of memory and gives the following messages: $ lsdvd libdvdread: Using libdvdcss version 1.2.13 for DVD access *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** With a more recent version from git it doesn't use that much memory and outputs just: $ lsdvd *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Can't open ifo 2! And mplayer produces: Playing dvd://2. There are 99 titles on this DVD. There are 1 angles in this DVD title. *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Cannot open the IFO file for DVD title 2. No stream found to handle url dvd://2 I tried it on different computers, so it is not a hardware problem. Only one Window Media Player could actually play it. Any help would be appreciated. Jan

5 6

New release
by Timothy Gu 13 Feb '14

13 Feb '14

Hi all, It's quite some time before the last release. There are some critical security fixes in SVN now. I guess it should be time for a new release. Also, if possible, can someone back port changes in the VideoLAN's fork to the official one? Thanks. Timothy

7 20

[PATCH][libdvdread] remove needless _LIBC checks from libdvdread
by Erik Auerswald 31 Dec '13

31 Dec '13

Hi, the first attached patch removes preprocessor checks for _LIBC, because libdvdread is not GNU Libc and does never #define _LIBC. The compiled objects stay the same (checked with md5sum (without debugging info: ./configure2 --disable-debug)). I have tested this patch (that is, the md5.[ch] changes) with MPlayer from svn as well, works the same as before. I did not re-indent the nested #if construct in the 2nd and 3rd hunks of the src/md5.h changes to ease review. This should be done after applying this patch. You can use the second attached patch to do this (use patch -p1). Applying this patch results in cleaner code, which should help in maintaining it. Additionally, a -Wundef warning in MPlayer (from svn) compilation is fixed. This is a more comprehensive than my first proposed patch (see http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2013-January/001862.html) and replaces it. Thanks, Erik

2 3

dvdread patch for gcc 4.7+ and mingw
by Roger Pack 12 Dec '13

12 Dec '13

Hello. As a note, dvdread if compiled using mingw or cross compiled for windows, seems to fail with all sorts of failure messages. This patch (from the vlc team [1], thanks!) seems necessary there: https://raw.github.com/rdp/ffmpeg-windows-build-helpers/master/patches/dvdr… I'm not sure if it affects other OS's or not. I "think" the problem stems from gcc packing structures differently with 4.7+ though I'm not certain [2] . All I really know is that, for windows with gcc 4.8, it fails without this patch and works with it. Thank you, thought I'd mention it since there was a recent call for trivial patches. -roger- [1] https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/rules.mak#L… and https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/dvdread-win… [2] http://www.bttr-software.de/forum/mix_entry.php?id=11767 apparently -mms-bitfields became default with gcc 4.7

2 4

[PATCH] libdvdread/src/ifo_read.c: Format fraction as float and update error message
by Paul Menzel 05 Dec '13

05 Dec '13

Date: Mon, 18 Nov 2013 16:54:51 +0100 GCC 4.8.2 and Clang 3.4 both warn about a format mismatch. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -mno-ms-bitfields -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o ifo_read.c: In function 'ifoRead_TT_SRPT': ifo_read.c:1078:13: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=] info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); libtool: compile: clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o ifo_read.c:1078:13: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat] info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by actually displaying the float value and by updating the error message. --- libdvdread/src/ifo_read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index 36545ce..5640e0a 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -1074,8 +1074,8 @@ int ifoRead_TT_SRPT(ifo_handle_t *ifofile) { } if(tt_srpt->nr_of_srpts>info_length/sizeof(title_info_t)){ - fprintf(stderr,"libdvdread: data mismatch: info_length (%ld)!= nr_of_srpts (%d). Truncating.\n", - info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); + fprintf(stderr,"libdvdread: data mismatch: info_length/sizeof(title_info_t) (%f)!= nr_of_srpts (%d). Truncating.\n", + info_length * 1.0/sizeof(title_info_t),tt_srpt->nr_of_srpts); tt_srpt->nr_of_srpts=info_length/sizeof(title_info_t); } -- 1.8.4.3

3 3

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5

libdvdread/libdvdnav 4.2.1 release candidate
by Dominik 'Rathann' Mierzejewski 04 Dec '13

04 Dec '13

Hello, I've just uploaded the release candidate tarballs for 4.2.1 releases of libdvdread and libdvdnav: http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.1.tar.xz http://dvdnav.mplayerhq.hu/releases/libdvdread-4.2.1.tar.xz Please test and report back. If there are no issues, these will become the final releases in a few days. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 4

[PATCH] libdvdread/src/ifo_read.c: Use 0 instead of NULL in integer comparison
by Paul Menzel 04 Dec '13

04 Dec '13

Date: Mon, 18 Nov 2013 16:58:17 +0100 Both GCC 4.8.2 and Clang 3.4 warn about a format mismatch in a comparison. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -mno-ms-bitfields -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o […] ifo_read.c: In function 'ifoRead_PTL_MAIT': ifo_read.c:1313:34: warning: comparison between pointer and integer [enabled by default] if(ifofile->vmgi_mat->ptl_mait == NULL) libtool: compile: clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o […] ifo_read.c:1313:34: warning: comparison between pointer and integer ('uint32_t' (aka 'unsigned int') and 'void *') if(ifofile->vmgi_mat->ptl_mait == NULL) ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~ Fix this by using the integer 0 instead of `NULL`. --- libdvdread/src/ifo_read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index 5640e0a..f679bca 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -1310,7 +1310,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofile) { if(!ifofile->vmgi_mat) return 0; - if(ifofile->vmgi_mat->ptl_mait == NULL) + if(ifofile->vmgi_mat->ptl_mait == 0) return 1; if(!DVDFileSeek_(ifofile->file, ifofile->vmgi_mat->ptl_mait * DVD_BLOCK_LEN)) -- 1.8.4.3

2 1

[PATCH] src/ifo_read.c: Abort when PTT search table has zero entries
by Paul Menzel 04 Dec '13

04 Dec '13

Date: Mon, 18 Nov 2013 16:31:53 +0100 The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a possible allocation of size 0 in `libdvdread/src/ifo_read.c`. $ scan-build -o scan-build make $ scan-view scan-build/2013-11-18-155601-16168-1 When `vts_ptt_srpt->nr_of_srpts` is zero the allocation size is zero. vts_ptt_srpt->title = malloc(vts_ptt_srpt->nr_of_srpts * sizeof(ttu_t)); The manual of the function `malloc` writes the following. If size is 0, then malloc() returns either NULL, or a unique pointer value that can later be successfully passed to free(). So check for 0 and, if it is, abort by going to the label `fail`. --- libdvdread/src/ifo_read.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libdvdread/src/ifo_read.c b/libdvdread/src/ifo_read.c index d690e80..36545ce 100644 --- a/libdvdread/src/ifo_read.c +++ b/libdvdread/src/ifo_read.c @@ -1186,6 +1186,12 @@ int ifoRead_VTS_PTT_SRPT(ifo_handle_t *ifofile) { fprintf(stderr, "libdvdread: PTT search table too small.\n"); goto fail; } + + if(vts_ptt_srpt->nr_of_srpts == 0) { + fprintf(stderr, "libdvdread: Zero entries in PTT search table.\n"); + goto fail; + } + for(i = 0; i < vts_ptt_srpt->nr_of_srpts; i++) { /* Transformers 3 has PTT start bytes that point outside the SRPT PTT */ uint32_t start = data[i]; -- 1.8.4.3

2 2

Question regarding libdvdnav-4.2.0+20130225-3 mailing list and spin requests.
by amit kumar gupta 29 Nov '13

29 Nov '13

Hi, We are in the process of adding support for new arch (ppc64le) and as part of that we wanted to send patches for config.guess and configure as appropriate. libdvdnav-4.2.0+20130225-3 could not be built on ppc64le because it had an outdated configure/config.guess/sub. Since your pkg uses libtool and the latest tarball of your pkg didn't build on ppc64le due to outdated libtool present on your system. We wanted to request you to upgrade your libtool to the alpha release of libtool which has all the bits and pieces needed for ppc64le support. In that context, I wanted to confirm the below 1) Should we send patches to this mailing list or there is some other mailing list ? 2) New libtool alpha release which supports ppc64le arch is available, you may pick up the alpha release from either of the below : ftp://alpha.gnu.org/gnu/libtool/libtool-2.4.2.418.tar.gz (1.6MB) ftp://alpha.gnu.org/gnu/libtool/libtool-2.4.2.418.tar.xz (920KB) It would be great if you can install this new libtool which supports ppc64le, and spin the pkg and let us know the new tar availability. We can test it on ppc64le architecture for you. Please let me know if you are planning to release or spin newer version. Currently I used http://daniel-baumann.ch/files/debian.old/CURRENT/libdvdnav/4.2.0+20130225-… Which does not have ppc64le support. Your response is highly appreciated Thanks in advance, Amit

3 2