October 2013 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] use newer dll name
by Roger Pack 06 Oct '13

06 Oct '13

For some reason on windows the dll name these days is almost always libdvdcss-2.dll instead of libdvdcss.dll (gstreamer, xbmc, etc.) This patch seems to work, and would make it to match, which seems better from my vantage. -roger-

5 7

r1269 - trunk/libdvdread/src/dvd_input.c
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 23:13:57 2013 New Revision: 1269 Log: Use correct name of the libdvdcss DLL on Windows. Patch by Roger Pack. Modified: trunk/libdvdread/src/dvd_input.c Modified: trunk/libdvdread/src/dvd_input.c ============================================================================== --- trunk/libdvdread/src/dvd_input.c Sun Oct 6 22:54:43 2013 (r1268) +++ trunk/libdvdread/src/dvd_input.c Sun Oct 6 23:13:57 2013 (r1269) @@ -282,7 +282,7 @@ int dvdinput_setup(void) #ifdef __APPLE__ #define CSS_LIB "libdvdcss.2.dylib" #elif defined(WIN32) - #define CSS_LIB "libdvdcss.dll" + #define CSS_LIB "libdvdcss-2.dll" #elif defined(__OS2__) #define CSS_LIB "dvdcss.dll" #else

1 0

assertion failure with certain DVD's
by Roger Pack 06 Oct '13

06 Oct '13

Hello all. I get the following assertion playing the "Tangled" DVD with mplayer and an up to date libdvdnav, on windows: Assertion failed: (vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0, file libdvdnav/vm/vm.c, line 1141 The weird part about this is that in mac/linux, I get this error message, and no failed assertion, and playing continues: libdvdnav: Invalid angle block I'd be happy to send more information, or a (legal) DVD to keep, for any developer that would like to tackle it. It appears that it happens with a few other (Disney?) DVD's, as well: http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-December/075458.html https://trac.handbrake.fr/ticket/125 https://forum.handbrake.fr/viewtopic.php?f=11&t=14189 So I'm guessing it's a libdvdnav bug. As a note, in VLC on windows, this causes playback to "loop" over - cellN=2 over and over, though it doesn't crash--I'm guessing it just swallows the assertion failure, or the failure isn't enabled with that build. Thanks. -roger-

4 8

r1268 - trunk/libdvdnav/src/vm/vm.c
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 22:54:43 2013 New Revision: 1268 Log: Prevent general CPP macro from causing strange behavior. Roger Pack reported that when playing the DVD "Tangled" w/ mplayer and recent libdvdnav, mplayer crashes w/ the error message: Assertion failed: (vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0, file libdvdnav/vm/vm.c, line 1141 This line should only be triggered when a developer wants a "strict" build of the library. Most likely using the very general term STRICT to #ifdef this clause is what is causing this issue. This patch adds a DVDNAV_ in front of the strict to prevent the macro from being enabled accidentally. Patch by Erik Hovland. Modified: trunk/libdvdnav/src/vm/vm.c Modified: trunk/libdvdnav/src/vm/vm.c ============================================================================== --- trunk/libdvdnav/src/vm/vm.c Sun Oct 6 22:47:20 2013 (r1267) +++ trunk/libdvdnav/src/vm/vm.c Sun Oct 6 22:54:43 2013 (r1268) @@ -59,7 +59,7 @@ #endif /* -#define STRICT +#define DVDNAV_STRICT */ /* Local prototypes */ @@ -1128,7 +1128,7 @@ static link_t play_Cell(vm_t *vm) { case 1: /* Angle block */ /* Loop and check each cell instead? So we don't get outside the block? */ (vm->state).cellN += (vm->state).AGL_REG - 1; -#ifdef STRICT +#ifdef DVDNAV_STRICT assert((vm->state).cellN <= (vm->state).pgc->nr_of_cells); assert((vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0); assert((vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_type == 1);

1 0

[PATCH] fix dvdnav.h comment
by Roger Pack 06 Oct '13

06 Oct '13

I believe dvdnav_time_search *is* implemented, just somewhat inaccurately, so patch attempts to update comment in this regard. Thanks. -roger-

2 1

r1267 - trunk/libdvdnav/src/dvdnav/dvdnav.h
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 22:47:20 2013 New Revision: 1267 Log: Correct comment. dvdnav_time_search *is* implemented, just somewhat inaccurately. Patch by Roger Pack. Modified: trunk/libdvdnav/src/dvdnav/dvdnav.h Modified: trunk/libdvdnav/src/dvdnav/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav/dvdnav.h Fri Oct 4 01:15:54 2013 (r1266) +++ trunk/libdvdnav/src/dvdnav/dvdnav.h Sun Oct 6 22:47:20 2013 (r1267) @@ -382,7 +382,7 @@ int64_t dvdnav_get_current_time(dvdnav_t * Stop playing the current position and start playback of the title * from the specified timecode. * - * Currently unimplemented! + * Currently implemented using interpolation, which is slightly inaccurate. */ dvdnav_status_t dvdnav_time_search(dvdnav_t *self, uint64_t time);

1 0

[PATCH] handle duplicate language units and pgc's more gracefully
by John Stebbins 05 Oct '13

05 Oct '13

This patch never got accepted (probably because it's touches a lot and made you nervous), but HandBrake has been applying this for 3 years now. Some discs have large numbers of repeated language units and pgc's that cause extreme memory consumption and file i/o issues. scanning all the titles on such discs is unusably slow. detect such repeats and ref-count the data structures to avoid reading and storing duplicate info.

6 15

VLC segfault playing DVD
by dvdnav.cathy_mcdonald＠spamgourmet.com 05 Oct '13

05 Oct '13

Hi, I've tracked down a bug which is causing VLC to crash when playing the Jack Reacher DVD. Is this the right forum for submitting a patch? I checked out the source from svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdnav but I've also seen a later version of the file I want to change at https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/libdvdnav/prec… <https://bazaar.launchpad.net/%7Eubuntu-branches/ubuntu/precise/libdvdnav/pr…> so I'm confused about which is the latest version of the code and which repository is the source of truth for a start. I notice that the changes include a bunch of new sanity checks but not the one which fixes my issue. The bug I found produces a segfault in the dvdnav_describe_title_chapters function in searching.c. It fails at the line cellnr = pgc->program_map[ptt[i].pgn-1]; because for some reason pgc->program_map is NULL. When I add a check for this condition like if(pgc->program_map == NULL) { printerr("Program map missing."); continue; } the DVD will play. Thanks, Cathy

4 3

[PATCH] do not close file twice
by Reimar Döffinger 05 Oct '13

05 Oct '13

There is another close further down that will always be reached. Current code will result in a double close. Index: vm/vm.c =================================================================== --- vm/vm.c (revision 1243) +++ vm/vm.c (working copy) @@ -176,7 +176,6 @@ off = lseek( fd, 32 * (off_t) DVD_VIDEO_LB_LEN, SEEK_SET ); if( off == ( 32 * (off_t) DVD_VIDEO_LB_LEN ) ) { off = read( fd, data, DVD_VIDEO_LB_LEN ); - close(fd); if (off == ( (off_t) DVD_VIDEO_LB_LEN )) { fprintf(MSG_OUT, "libdvdnav: DVD Title: "); for(i=25; i < 73; i++ ) {

5 13

[PATCH] fix dvdnav_convert_time to work for full range
by Reimar Döffinger 05 Oct '13

05 Oct '13

Hello, currently the calculation will use int and thus overflow for anything larger or equal to 20 hours. Not sure if this is the best/nicest way, personally I prefer to do this kind of thing with the result = hour >> 4; result *= 10; result += hour; result *= 6; result += minute >> 4; result *= 10; .... scheme, but this is the minimal change required. Index: dvdnav.c =================================================================== --- dvdnav.c (revision 1243) +++ dvdnav.c (working copy) @@ -203,7 +203,7 @@ int64_t result; int64_t frames; - result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000; + result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000ull; result += (time->hour & 0x0f) * 60 * 60 * 90000; result += (time->minute >> 4 ) * 10 * 60 * 90000; result += (time->minute & 0x0f) * 60 * 90000;

3 2