October 2013 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] hop_channel not reset when vm_reset is called
by Richard 10 Nov '13

10 Nov '13

Hi, Calling vm_reset (via dvdnav_reset) does not currently reset the hop_channel field. This leads to "Error reading NAV packet." errors on some DVDs because dvdnav_get_next_cache_block tries to prepare a HOP_CHANNEL event and read from a file which hasn't yet been opened. The attached patch resets the hop_channel field to zero. Regards, Richard.

3 3

[PATCH] Add serialization support
by Richard Hulme 28 Oct '13

28 Oct '13

Hi, The attached patch adds serialization support to libdvdnav, which effectively allows DVD bookmarks to be saved and restored. The current VM state is converted to/from an ASCII string. This is a patch I created for MythTV, where it is currently in use. As I wrote in the submit description for MythTV: "The state snapshot code is borrowed/adapted from or inspired by XBMC and Ogle." Richard.

4 10

r1274 - trunk/libdvdnav/ChangeLog
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Mon Oct 7 00:35:16 2013 New Revision: 1274 Log: List interesting changes for next release. Modified: trunk/libdvdnav/ChangeLog Modified: trunk/libdvdnav/ChangeLog ============================================================================== --- trunk/libdvdnav/ChangeLog Mon Oct 7 00:27:16 2013 (r1273) +++ trunk/libdvdnav/ChangeLog Mon Oct 7 00:35:16 2013 (r1274) @@ -1,3 +1,11 @@ +libdvdnav (4.?.?) + * fixed failed assertion on menu-less DVDs + * fixed playback issues on multi-angle DVDs + * fixed crash when playing a DVD from different region than currently set + in the DVD drive + * fixed segfaults when reading certain DVDs (including "Jack Reacher", + "Ghost Protocol" and "Tangled") + libdvdnav (4.2.0) * OS/2 support * added dvdnav_get_serial_string() function

1 0

r1273 - trunk/libdvdread/ChangeLog
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Mon Oct 7 00:27:16 2013 New Revision: 1273 Log: List interesting changes for next release. Modified: trunk/libdvdread/ChangeLog Modified: trunk/libdvdread/ChangeLog ============================================================================== --- trunk/libdvdread/ChangeLog Sun Oct 6 23:56:26 2013 (r1272) +++ trunk/libdvdread/ChangeLog Mon Oct 7 00:27:16 2013 (r1273) @@ -1,3 +1,8 @@ +libdvdread (4.?.?) + * fix huge memory consumption when reading DVDs: "Up" and "Dark Knight" + * fix segfault when reading DVDs: "The Express", "Transformers 3" + and "Cars 2" + libdvdread (4.2.0) * added OS/2 support * fixed ARM memory alignment issue

1 0

[PATCH] Pass return value of vm_jump_up back
by Richard Hulme 06 Oct '13

06 Oct '13

Hi, dvdnav_go_up ignores the return value of vm_jump_up, and always returns DVDNAV_STATUS_OK, The calling code cannot therefore determine whether the jump was successful or not. The attached patch evaluates the return value from vm_jump_up and passes this back to the caller. Regards, Richard.

3 2

r1272 - trunk/libdvdnav/src/navigation.c
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 23:56:26 2013 New Revision: 1272 Log: Pass return value of vm_jump_up back to the caller. dvdnav_go_up ignores the return value of vm_jump_up, and always returns DVDNAV_STATUS_OK, the calling code cannot therefore determine whether the jump was successful or not. The attached patch evaluates the return value from vm_jump_up and passes this back to the caller. Patch by Richard Hulme. Modified: trunk/libdvdnav/src/navigation.c Modified: trunk/libdvdnav/src/navigation.c ============================================================================== --- trunk/libdvdnav/src/navigation.c Sun Oct 6 23:39:42 2013 (r1271) +++ trunk/libdvdnav/src/navigation.c Sun Oct 6 23:56:26 2013 (r1272) @@ -268,9 +268,11 @@ dvdnav_status_t dvdnav_stop(dvdnav_t *th dvdnav_status_t dvdnav_go_up(dvdnav_t *this) { /* A nice easy function... delegate to the VM */ + int32_t retval; + pthread_mutex_lock(&this->vm_lock); - vm_jump_up(this->vm); + retval = vm_jump_up(this->vm); pthread_mutex_unlock(&this->vm_lock); - return DVDNAV_STATUS_OK; + return retval ? DVDNAV_STATUS_OK : DVDNAV_STATUS_ERR; }

1 0

[PATCH] Fix undefined variable warning in md5.h
by Erik Auerswald 06 Oct '13

06 Oct '13

Hi, the attached patch fixes a -Wundef warning when compiling the current svn version of libdvdread4 (as part of MPlayer) in the obvious way: $ make cc -MD -MP -Ilibdvdread4 -D_GNU_SOURCE -Ilibdvdcss -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I. -Iffmpeg -D_REENTRANT -I/usr/include/directfb -I/usr/include/ -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/dirac -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4 -c -o libdvdread4/dvd_reader.o libdvdread4/dvd_reader.c In file included from libdvdread4/dvd_reader.c:71:0: libdvdread4/md5.h:26:30: warning: "_LIBC" is not defined [-Wundef] cc -MD -MP -Ilibdvdread4 -D_GNU_SOURCE -Ilibdvdcss -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I. -Iffmpeg -D_REENTRANT -I/usr/include/directfb -I/usr/include/ -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/dirac -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4 -c -o libdvdread4/md5.o libdvdread4/md5.c In file included from libdvdread4/md5.c:28:0: libdvdread4/md5.h:26:30: warning: "_LIBC" is not defined [-Wundef] Please consider applying. Fix one warning every day. ;-) Thanks, Erik

2 1

r1271 - trunk/libdvdread/src/md5.h
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 23:39:42 2013 New Revision: 1271 Log: Fix undefined variable warning in md5.h. Patch by Erik Auerswald. Modified: trunk/libdvdread/src/md5.h Modified: trunk/libdvdread/src/md5.h ============================================================================== --- trunk/libdvdread/src/md5.h Sun Oct 6 23:34:05 2013 (r1270) +++ trunk/libdvdread/src/md5.h Sun Oct 6 23:39:42 2013 (r1271) @@ -23,7 +23,7 @@ #include <stdio.h> -#if defined HAVE_LIMITS_H || _LIBC +#if defined HAVE_LIMITS_H || defined _LIBC # include <limits.h> #endif

1 0

[PATCH] Spelling
by Benjamin Kerensa 06 Oct '13

06 Oct '13

Index: src/ifo_print.c =================================================================== --- src/ifo_print.c (revision 1250) +++ src/ifo_print.c (working copy) @@ -1189,10 +1189,10 @@ if(ifohandle->menu_vobu_admap) { ifoPrint_VOBU_ADMAP(ifohandle->menu_vobu_admap); } else { - printf("No Menu VOBU address map present\n"); + printf("No Menu VOBU Address map present\n"); } - printf("\nCell Adress table\n"); + printf("\nCell Address table\n"); printf( "-----------------\n"); ifoPrint_C_ADT(ifohandle->vts_c_adt);

2 1

r1270 - trunk/libdvdread/src/ifo_print.c
by rathann 06 Oct '13

06 Oct '13

Author: rathann Date: Sun Oct 6 23:34:05 2013 New Revision: 1270 Log: Fix spelling errors. Patch by Benjamin Kerensa. Modified: trunk/libdvdread/src/ifo_print.c Modified: trunk/libdvdread/src/ifo_print.c ============================================================================== --- trunk/libdvdread/src/ifo_print.c Sun Oct 6 23:13:57 2013 (r1269) +++ trunk/libdvdread/src/ifo_print.c Sun Oct 6 23:34:05 2013 (r1270) @@ -1189,10 +1189,10 @@ void ifo_print(dvd_reader_t *dvd, int ti if(ifohandle->menu_vobu_admap) { ifoPrint_VOBU_ADMAP(ifohandle->menu_vobu_admap); } else { - printf("No Menu VOBU address map present\n"); + printf("No Menu VOBU Address map present\n"); } - printf("\nCell Adress table\n"); + printf("\nCell Address table\n"); printf( "-----------------\n"); ifoPrint_C_ADT(ifohandle->vts_c_adt);

1 0