October 2013 - DVDnav-discuss - lists.mplayerhq.hu

Can't watch DVD
by jan.maske＠abwesend.de 23 May '14

23 May '14

Hi I bought a new DVD, but can't watch it. Using libdvdread 4.2.0 lsdvd eats a lot of memory and gives the following messages: $ lsdvd libdvdread: Using libdvdcss version 1.2.13 for DVD access *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1980 *** *** for pgci_ut->nr_of_lus < 100 *** Please send bug report - no VTS_TMAPT ?? *** libdvdread: CHECK_VALUE failed in ifo_read.c:1251 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** With a more recent version from git it doesn't use that much memory and outputs just: $ lsdvd *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Can't open ifo 2! And mplayer produces: Playing dvd://2. There are 99 titles on this DVD. There are 1 angles in this DVD title. *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:1246 *** *** for vts_ptt_srpt->title[i].ptt[j].pgn != 0 *** libdvdread: Invalid IFO for title 2 (VTS_02_0.BU). Cannot open the IFO file for DVD title 2. No stream found to handle url dvd://2 I tried it on different computers, so it is not a hardware problem. Only one Window Media Player could actually play it. Any help would be appreciated. Jan

5 6

New release
by Timothy Gu 13 Feb '14

13 Feb '14

Hi all, It's quite some time before the last release. There are some critical security fixes in SVN now. I guess it should be time for a new release. Also, if possible, can someone back port changes in the VideoLAN's fork to the official one? Thanks. Timothy

7 20

[PATCH][libdvdread] remove needless _LIBC checks from libdvdread
by Erik Auerswald 31 Dec '13

31 Dec '13

Hi, the first attached patch removes preprocessor checks for _LIBC, because libdvdread is not GNU Libc and does never #define _LIBC. The compiled objects stay the same (checked with md5sum (without debugging info: ./configure2 --disable-debug)). I have tested this patch (that is, the md5.[ch] changes) with MPlayer from svn as well, works the same as before. I did not re-indent the nested #if construct in the 2nd and 3rd hunks of the src/md5.h changes to ease review. This should be done after applying this patch. You can use the second attached patch to do this (use patch -p1). Applying this patch results in cleaner code, which should help in maintaining it. Additionally, a -Wundef warning in MPlayer (from svn) compilation is fixed. This is a more comprehensive than my first proposed patch (see http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2013-January/001862.html) and replaces it. Thanks, Erik

2 3

dvdread patch for gcc 4.7+ and mingw
by Roger Pack 12 Dec '13

12 Dec '13

Hello. As a note, dvdread if compiled using mingw or cross compiled for windows, seems to fail with all sorts of failure messages. This patch (from the vlc team [1], thanks!) seems necessary there: https://raw.github.com/rdp/ffmpeg-windows-build-helpers/master/patches/dvdr… I'm not sure if it affects other OS's or not. I "think" the problem stems from gcc packing structures differently with 4.7+ though I'm not certain [2] . All I really know is that, for windows with gcc 4.8, it fails without this patch and works with it. Thank you, thought I'd mention it since there was a recent call for trivial patches. -roger- [1] https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/rules.mak#L… and https://github.com/videolan/vlc/blob/master/contrib/src/dvdread/dvdread-win… [2] http://www.bttr-software.de/forum/mix_entry.php?id=11767 apparently -mms-bitfields became default with gcc 4.7

2 4

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5

dvdnav SEGFAULT patch for broken DVD
by Vincent Mussard 12 Nov '13

12 Nov '13

Dear all Maybe it will be useful for someone. Please find attached a patch I made, gathering patch made by other people (especialy from Fabian Keil in an email from Sat, 14 Jul 2012). I added on it an additionnal check (ptt[i].pgcn-1 >= ifo->vts_pgcit->nr_of_pgci_srp) that helps reading one of my broken ripped DVD. Regards Vincent

3 2

Re: [DVDnav-discuss] [PATCH] Check for out-of-bounds values for pgcn.
by Bryce Harrington 12 Nov '13

12 Nov '13

Admittedly, this just papers over the real issue, and I'd appreciate advice on better ways to fix this. There is a sample IFO on the referenced bug report that reproduces the crash. Essentially, we're seeing pgcn values in the 30,000-32,000 range which is outside the bounds of the ifo->vts_pgcit->pgci_srp array, and thus crashes. I haven't found where these large values come from... suggestions for further study would be welcomed. Bryce On Mon, May 06, 2013 at 12:43:59PM -0700, Bryce Harrington wrote: > Fixes a crash in dvdnav_describe_title_chapters() with vlc, lsdvd, and > other video players caused by an invalid value for pgcn. This occurs > with the "Inside Man" DVD. > > Ref: https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/1094499 > > Signed-off-by: Bryce Harrington <bryce(a)canonical.com> > --- > src/searching.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/searching.c b/src/searching.c > index a9b4dc9..86d4d97 100644 > --- a/src/searching.c > +++ b/src/searching.c > @@ -641,6 +641,11 @@ uint32_t dvdnav_describe_title_chapters(dvdnav_t *this, int32_t title, uint64_t > length = 0; > for(i=0; i<parts; i++) { > uint32_t cellnr, endcellnr; > + /* This mimics pgcn checks in ifoRead_VTS_PTT_SRPT() */ > + if (ptt[i].pgcn > 1000 || ptt[i].pgcn < 0) { > + printerr("PGCN out of bounds."); > + continue; > + } > if (ifo->vts_pgcit->pgci_srp[ptt[i].pgcn-1].pgc_start_byte >= ifo->vts_pgcit->last_byte) { > printerr("PGC start out of bounds"); > continue; > -- > 1.7.9.5 ----- End forwarded message -----

3 3

[PATCH] workaround a crash.
by Ivan Kalvachev 11 Nov '13

11 Nov '13

A user came in irc #mplayer complaining that dvdnav crashes with a number of programs (VLC included). He did manage to provide a detailed backtrace. Here is a part of it: -- *** libdvdread: CHECK_VALUE failed in ifo_read.c:914 *** *** for pgc->program_map_offset != 0 *** *** libdvdread: CHECK_VALUE failed in ifo_read.c:916 *** *** for pgc->cell_position_offset != 0 *** [...] dvdnav_describe_title_chapters (this=0x7fffd0006e00, title=<optimized out>, times= 0x7fffd7b0f018, duration=0x7fffd7b0f010) at searching.c:625 625 cellnr = pgc->program_map[ptt[i].pgn-1]; -- Thanks to that report I made quick workaround that seems to avoid the crash. Patch attached to the mail. I have asked the user to compare the .IFO and . BUP files in case the .IFO is intentionally broken as some DRM scheme, but they seem to have the same checksums. The user also provided the .BUP file and I can forward it off-list, in case somebody wants to investigate. The source seems to be original disk of "the dictator". Best Regards Ivan Kalvachev iive

2 1

[PATCH] Fix packed structures with mingw gcc >= 4.7
by John Stebbins 11 Nov '13

11 Nov '13

As of gcc 4.7, structures are packed in a "MS compatible" format by default. If you want the correct behavior, you must add -mno-ms-bitfields to CFLAGS :-\ --- configure.ac | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/configure.ac b/configure.ac index 30cab8d..fbd5fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -163,6 +163,15 @@ case $host in AC_SUBST(DYNAMIC_LD_LIBS) fi LDFLAGS="-no-undefined $LDFLAGS" + if test "$GCC" = "yes" ; then + gcc_version="`$CC -dumpversion`" + gcc_version_major=$(echo $gcc_version | cut -d"." -f1) + gcc_version_minor=$(echo $gcc_version | cut -d"." -f2) + gcc_version_patch=$(echo $gcc_version | cut -d"." -f3) + if test $gcc_version_major -ge 4 -a $gcc_version_minor -ge 7 ; then + CFLAGS="-mno-ms-bitfields $CFLAGS" + fi + fi ;; *cygwin*) LDFLAGS="-no-undefined $LDFLAGS" -- 1.7.11.7

4 6

new release, call for patches
by Dominik 'Rathann' Mierzejewski 11 Nov '13

11 Nov '13

Hi All, as you no doubt noticed, I went through most of the long pending patches and committed the ones which were confirmed to fix segfaults, were obvious, trivial or non-controversial. I need someone to review the remaining ones. Erik, John, do you have any patches that you'd like to see in the next release? I'd like to have a new release in a week or two. From what I see in the commits since the last release, this should be a purely bugfix release, so it'll be called 4.2.1 most probably. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 3