June 2012 - DVDnav-discuss - lists.mplayerhq.hu

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5

[PATCH] use newer dll name
by Roger Pack 06 Oct '13

06 Oct '13

For some reason on windows the dll name these days is almost always libdvdcss-2.dll instead of libdvdcss.dll (gstreamer, xbmc, etc.) This patch seems to work, and would make it to match, which seems better from my vantage. -roger-

5 7

assertion failure with certain DVD's
by Roger Pack 06 Oct '13

06 Oct '13

Hello all. I get the following assertion playing the "Tangled" DVD with mplayer and an up to date libdvdnav, on windows: Assertion failed: (vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0, file libdvdnav/vm/vm.c, line 1141 The weird part about this is that in mac/linux, I get this error message, and no failed assertion, and playing continues: libdvdnav: Invalid angle block I'd be happy to send more information, or a (legal) DVD to keep, for any developer that would like to tackle it. It appears that it happens with a few other (Disney?) DVD's, as well: http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-December/075458.html https://trac.handbrake.fr/ticket/125 https://forum.handbrake.fr/viewtopic.php?f=11&t=14189 So I'm guessing it's a libdvdnav bug. As a note, in VLC on windows, this causes playback to "loop" over - cellN=2 over and over, though it doesn't crash--I'm guessing it just swallows the assertion failure, or the failure isn't enabled with that build. Thanks. -roger-

4 8

[PATCH] fix dvdnav.h comment
by Roger Pack 06 Oct '13

06 Oct '13

I believe dvdnav_time_search *is* implemented, just somewhat inaccurately, so patch attempts to update comment in this regard. Thanks. -roger-

2 1

[patch] Fix SIGSEGV in dvdnav_describe_title_chapters
by Sylvain HENRY 05 Oct '13

05 Oct '13

Hi, Please consider checking and applying the attached patch. It fixes a segfault occuring with some DVDs. It seems to be the same problem as the one mentionned here: https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/934471 In my case, "cellnr" and "endcellnr" variables were set to 0 when the crash occured. Cheers Sylvain PS: I'm not registered on the mailing-list, please answer directly to me if necessary

3 8

[PATCH] Sanitize PTT start offsets
by John Stebbins 05 Oct '13

05 Oct '13

If the start offset points past the last_byte (outside the region read) stop reading PTTs and adjust nr_of_srpts. Fixes Transformers 3 -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7

3 5

[PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 5: combined args to structs)
by gnosygnu 29 Jul '13

29 Jul '13

This revision includes the following changes: 1) combined multiple arguments into structures (See dvdnav_pos_data_t, dvdnav_cell_data_t, dvdnav_jump_args_t) 2) changed multi-line statements to remove leading commas 3) removed tabs/trailing whitespace 4) replaced "discontinuity tmap indexes" approach with simpler "use entry sector of current cell" to handle DVDs with initial dummy cells. Thanks to all who have read through the patch and/or offered comments. As far as I know, there are no other known pending changes/requests. I am hoping that this patch is at a near-final state. Please let me know what else should be done to get this patch accepted. Thanks.

3 19

[PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 6: add mode argument)
by gnosygnu 16 Dec '12

16 Dec '12

This revision features one minor change. It adds a new "mode" parameter to "dvdnav_jump_to_sector". As per the included comment: /* NOTE: Mode is currently unimplemented. Only 0 should be passed. */ /* 1 and -1 are for future implementation */ /* 0: Default. Jump to a time which may be either <> time_in_pts_ticks */ /* 1: After. Always jump to a time that is > time_in_pts_ticks */ /* -1: Before. Always jump to a time that is < time_in_pts_ticks */ dvdnav_status_t dvdnav_jump_to_sector_by_time(dvdnav_t *this, uint64_t time_in_pts_ticks, int32_t mode) ... The corresponding .h interface was also updated. My apologies for not implementing the new parameter, but as I detailed in another email, the change looks quite significant. As far as I know, there are no other known pending changes/requests. I am hoping that this patch is at a final state. Please let me know what else should be done to get this patch accepted. Thanks.

4 6

[PATCH] Fix out of array pointer access
by Bryce Harrington 10 Dec '12

10 Dec '12

This patch fixes a segmentation fault hit when reading the DVD 'The Express'. It prevents a read/write beyond end of an array due to using a length value taken from the DVD, which can exceed the allocated size. https://bugs.launchpad.net/ubuntu/+source/libdvdread/+bug/894170 The patch was originally written by rickyrockrat (sorry, I don't have his email address) for 4.1.3. I got the DVD and reproduced the segfault using 4.2.0 and verified the patch stops the segfault from happening. We're not confident this is the best fix though, so are posting it here for review. Signed-off-by: Bryce Harrington <bryce(a)canonical.com> diff -Nrup libdvdread-4.2.0//src/ifo_read.c libdvdread-4.2.0-working//src/ifo_read.c --- libdvdread-4.2.0//src/ifo_read.c 2011-12-13 20:24:16.000000000 -0800 +++ libdvdread-4.2.0-working//src/ifo_read.c 2011-12-13 21:21:53.915978130 -0800 @@ -1082,6 +1082,12 @@ int ifoRead_TT_SRPT(ifo_handle_t *ifofil return 0; } + if(tt_srpt->nr_of_srpts>info_length/sizeof(title_info_t)){ + fprintf(stderr,"libdvdread: data mismatch: info_length (%ld)!= nr_of_srpts (%d). Truncating.\n", + info_length/sizeof(title_info_t),tt_srpt->nr_of_srpts); + tt_srpt->nr_of_srpts=info_length/sizeof(title_info_t); + } + for(i = 0; i < tt_srpt->nr_of_srpts; i++) { B2N_16(tt_srpt->title[i].nr_of_ptts); B2N_16(tt_srpt->title[i].parental_id);

3 3

[PATCH] fix C++ compatibility broken in r1208
by Anssi Hannula 09 Dec '12

09 Dec '12

Revision 1208 ("Add dvdnav_program_play & dvdnav_current_title_program") added dvdnav_program_play function to dvdnav.h. However, unlike the other API functions, its first parameter is named 'this' instead of 'self'. 'this' is a C++ keyword and prevents compilation of C++ projects using libdvdnav. Restore C++ compatibility by renaming the parameter to 'self' like in the other functions. -- Anssi Hannula

3 2