April 2012 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] Make sure we get nav packets for all cells in multi angle
by Joakim Plate 09 Dec '12

09 Dec '12

Hi, This is a resend of an old patch that we still keep in xbmc's version of libdvdnav. The problem is that libdvdnav jumps over NAV packets when playing multi angle features. I don't remember all the exact details on this patch anymore since it was many years since i tracked it down. But it is very obvious in xbmc since we use nav packet end/start times to correct timestamps. Without the patch we git gaps in nav packets that doesn's exist in the streams. I think i still have a dvd sample that shows the issue. /Joakim

3 5

libdvdnav 4.1.4
by Jean-Jacques Sarton 09 Dec '12

09 Dec '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Fedora 14 totem and vlc end both with folowing message: libdvdread: Found 1 VTS's libdvdread: Elapsed time 0 libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: *** pgci_ut handle is NULL *** totem: /builddir/build/BUILD/libdvdnav-4.1.4/src/vm/vm.c:1772: get_ID: Assertion `pgcit != ((void *)0)' failed. Of course tje line totem:... is to be replaced withz vlc:... according to the used player The dvd contain no menu and contain a privat video. If I rename libdvdnav totem/vlc works. Regards, Jean-Jacques Sarton -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk0h3bAACgkQM9JbiR3CwQsEEgCggN7qJrKQXspNYBJbCGRh237R +joAn1pQaRWHFN+nASDqRbL6Jgj3CM5S =iNgb -----END PGP SIGNATURE-----

4 6

[PATCH] consuming all memory when scanning dvd "Up"
by John Stebbins 09 Dec '12

09 Dec '12

First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.

3 5

cross/mingw compilation (was assertion failure with certain DVD's)
by Roger Pack 18 Oct '12

18 Oct '12

>> $./configure2 >> ./configure2: line 95: cd: /usr/local/: No such file or directory # >> needs to be run in bash I believe > > Nope, you need to set the install prefix with --prefix=blabla Sweet that fixed it, as long as the prefix exists, otherwise same error message different path :) >> Checking if we're big-endian... ./configure2: line 113: mktemp: command not found This meant I didn't have msys installed, only mingw (my bad). >> Done, type 'make install' to build and install >> (appears to set HAVE_DLFCN_H in error) > > Without using autotools, dlfcn.h presence is not detected Is there a way to use autotools with libdvdread? I'm a bit lost, as is evident. though I can work around it for now. This actually makes me wonder how anybody is compiling it for their windows distros today. I know mplayer just uses the src directory and its own configs (which work), dunno about VLC/others. It seems like both msys and cross compiling don't work, or can somebody give me an example of how they do work, somehow? > ./msvc/config.h:#define HAVE_DLFCN_H 1 > > And it is assumed to exist (is this file made for Visual Studio?) I guess so, since it's under the msvc dir. >> Also as a note when it runs strip and ranlib, if it's being cross >> compiled, it would be helpful to call their equivalent: >> $ ./configure2 --cc=i586-mingw32msvc-gcc >> should eventually call i586-mingw32msvc-ranlib >> >> maybe it could use a new configure option for a prefix or what not. > > ./configure --host=i586-mingw32-msvc should work Yes I think it needs an option like that added (configure2 doesn't appear to have one as of yet). -roger-

2 11

[PATCHES] libdvdread and libdvdnav patches
by Ganael LAPLANCHE 30 Apr '12

30 Apr '12

Hi team, First of all, thanks for your great work :) I am the maintainer of FreeBSD ports of libdvdread and libdvdnav and have small patches that you might be interested in, see : For libdvdread : * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdrea… This first patch adds support for libdatadir option, fixes incdir option and bigendian detection. Some chunks are FreeBSD-only an can be skipped (PREFIX comment, TMPD modification). * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdrea… This patch uses config.h instead of trying to re-detect endianness. For libdvdnav : * http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/libdvdnav… This patch adds support for libdatadir option and bigendian detection. Some chunks are still FreeBSD-only an can be skipped (PREFIX comment, TMPD). Best regards, -- Ganael LAPLANCHE <ganael.laplanche(a)martymac.org> http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac <martymac(a)FreeBSD.org>, http://www.FreeBSD.org

3 2

[PATCH] Fix mount point -> device name on OSX
by Rafaël Carré 20 Apr '12

20 Apr '12

getfsent() only returns '/' entry on my system (10.8) I only have 10.7 around to test, but this bug was reported ages ago: https://trac.videolan.org/vlc/ticket/4069 I don't have a BSD, so I can't test it on BSD too but I don't see why this code couldn't be shared on all BSD.

3 2

Re: [DVDnav-discuss] [PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 5: combined args to structs)
by Roger Pack 20 Apr '12

20 Apr '12

> Ok. Thanks. I took a look at it. It seems like a US feature film (run > time of 2:10:56). Can you let me know the title/edition and I'll try > to find it in one of my libraries? I detail more below. Yeah it's National Treasure. I might be able to get it for you from amazon...if I'm lucky enough to find the exact DVD :) >> "jumping to 1310667" (15s I presume) it then finds itself at 14.8s, > Keep in mind that 1310667 is the Presentation Time Stamp number. > To convert to milliseconds, just divide by 90. > So, 1310667 / 90 = 14.985 > > Out of curiosity, how much control do you have over the 1310667 > number? I'm assuming you're not typing in "1310667" or "14.985". For > example, are you using a slider in mplayer's GUI and the slider > indicates "15" seconds, but it is changing it to 14.985? > > If I'm reading the output correctly, it jumped to either 14.848 (or > 14.833) ("14.833333, mpeg at 0.083417 after -> 29.97 14.848166") > > So, considering that the time request was 14.985, 14.848 is largely > "correct". It looks like in this (other) case: "EDL rel seek secs 2.962971 12.037029 [12.000000,15.000000] jumping to 1310667" It's jumping "forward 2.962971 secs" Actually now that you mention it, I guess mplayer's code for "relative seek" is currently based off "relative to the most recent NAV packet time" so it might not have been seeking forward with "more than NAV packet precision" I sent mplayer some patches to help them seek better, hopefully that will get committed this eon. After overcoming that, now I get this console output, when attempting to skip from "10 to 15" last NAV packet was 9.600000 ... using mpeg ts appears larger, 10.082091: EDL rel seek secs +4.917909 from pts:10.082091 last NAV packet was 9.600000, mpeg at 10.082091 adding MPEG difference since last nav of 0.258597 # this basically means that, because of my funky math, I'm skipping from "DVD time" 9.858597 4.917909s forward jumping to 1329885 ... A: 11.1 V: 15.16 A-V: -4.098 ct: -0.100 3/ 3 ??% ??% ??,?% 0 0 ... new NAV packet! 14.833333 ... so that's actually really close ( 9.858597 -> 14.833333 for a 4.92s skip) . If I try seeking to "15.2" then it seeks to the same 14.833 mark, as described previous, but at least I've figured out some more mplayer workaround code for that in the meantime :) Thanks for your tips I think it's working now. -roger-

1 0

libdvdread uses internal dlfcn on W32, unconditionally
by LRN 18 Apr '12

18 Apr '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On W32 libdvdread unconditionally uses msvc/contrib/dlfcn.c While this allows libdvdread to be compiled out of the box, it prevents it from linking to any other dlfcn implementation. Namely - to dlfcn-win32 [1] (which is somewhat more POSIX-compliant). The attached patch is very simplistic (i.e. it unconditionally requires a working libdl somewhere), but it works for me. For trunk i would suggest re-writing it like this: check for dlopen in -lc if that fails, check for dlopen in -ld if that fails AND host is mingw, modify CFLAGS to use internal dlfcn Note that LDFLAGS modification should go AFTER (!) all AC_CHECK_LIB calls, because -no-undefined is no longer valid as a compiler option. [1] http://code.google.com/p/dlfcn-win32/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPiFCkAAoJEOs4Jb6SI2Cwl1YH/0T2WtJHelUGJr4ne6BN+dAz fvRfThLqmWIg0c+KrMN7UYlKOiDBWraLXbzUTvmjnZGM3w0GrUIT1qSniYKog+f+ AEfa9b75dfSSpT1R1xBmr1YT9ka3CtRtbiA5pjCHNyNr/IcMOQGEn8pXEzJ7vXn7 Uo5IeqWaG2JfjJYFXouKgTAT/L4P9Uvhab2S+SBFyhYG7OHi1DbmelWvhIkBT6lB QWE69RprcIH4dueq9l2IMvkWqhqvI580S6r3RbxZIFyYESamuxRCgxdCpBdPbYPs +KU2EjqJdmohoS+Xp274l0aia2sBrvgYsC37MkyYawi2UhPtv2EnW6lIUIHczSU= =VUR/ -----END PGP SIGNATURE-----

3 2

[PATCH] ignore some build files
by Mike Frysinger 17 Apr '12

17 Apr '12

Signed-off-by: Mike Frysinger <vapier(a)gentoo.org> --- .gitignore | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..656736d --- /dev/null +++ b/.gitignore @@ -0,0 +1,14 @@ +*.a +*.la +*.lo +*.o + +*.diff +*.orig +*.patch +*.rej + +.deps +.libs + +Makefile.in -- 1.7.8.5

1 0

[PATCH] libdvdnavmini depends on libdvdread
by LRN 17 Apr '12

17 Apr '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch fixes the following error messages one might get when building libdvdnav on W32 using MinGW: libtool: link: gcc -shared .libs/libdvdnavmini-4.dll.def .libs/dvdnav.o .libs/read_cache.o .libs/navigation.o .libs/highlight.o .libs/searching.o .libs/settings.o .libs/remap.o -Wl,--whole-archive ../src/vm/.libs/libdvdvm.a -Wl,--no-whole-archive -O3 -march=i686 - -o .libs/libdvdnavmini-4.dll -Wl,--enable-auto-image-base -Xlinker - --out-implib -Xlinker .libs/libdvdnavmini.dll.a Creating library file: .libs/libdvdnavmini.dll.a.libs/dvdnav.o:dvdnav.c:(.text+0x27): undefined reference to `DVDCloseFile' .libs/dvdnav.o:dvdnav.c:(.text+0x3bc): undefined reference to `navRead_DSI' .libs/dvdnav.o:dvdnav.c:(.text+0x3ef): undefined reference to `navRead_PCI' .libs/dvdnav.o:dvdnav.c:(.text+0x556): undefined reference to `DVDOpenFile' .libs/dvdnav.o:dvdnav.c:(.text+0x60e): undefined reference to `DVDCloseFile' .libs/dvdnav.o:dvdnav.c:(.text+0xbb1): undefined reference to `DVDCloseFile' .libs/dvdnav.o:dvdnav.c:(.text+0xf1b): undefined reference to `DVDOpenFile' .libs/read_cache.o:read_cache.c:(.text+0xfa7): undefined reference to `DVDReadBlocks' .libs/read_cache.o:read_cache.c:(.text+0xff0): undefined reference to `DVDReadBlocks' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x990): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x99c): undefined reference to `ifoOpenVTSI' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x9ae): undefined reference to `ifoRead_VTS_PTT_SRPT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x9bc): undefined reference to `ifoRead_PGCIT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x9ce): undefined reference to `ifoRead_PGCI_UT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x9dc): undefined reference to `ifoRead_VOBU_ADMAP' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x9ee): undefined reference to `ifoRead_TITLE_VOBU_ADMAP' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xf33): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xf49): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xf5e): undefined reference to `DVDClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xfc3): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xfd9): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0xfee): undefined reference to `DVDClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x13d5): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x13eb): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1400): undefined reference to `DVDClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1418): undefined reference to `DVDOpen' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x142a): undefined reference to `ifoOpenVMGI' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x143d): undefined reference to `ifoRead_FP_PGC' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1450): undefined reference to `ifoRead_TT_SRPT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1463): undefined reference to `ifoRead_PGCI_UT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1476): undefined reference to `ifoRead_PTL_MAIT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1489): undefined reference to `ifoRead_VTS_ATRT' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x149c): undefined reference to `ifoRead_VOBU_ADMAP' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1792): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x1883): undefined reference to `ifoClose' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x4724): undefined reference to `ifoOpen' ../src/vm/.libs/libdvdvm.a(vm.o):vm.c:(.text+0x4731): undefined reference to `ifoClose -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPiEZgAAoJEOs4Jb6SI2CwmgMH/j2Cm7JKrQ6XdLmPBCU5f8gr mjPTKuUmxJ49t0Ps+yOi78yyRNMl+OnPyPl+IZY3B+0WoosmTp/UYE/6/s9KHgAE 4R7TKQc/Y81UhsFjqeiumnbnu8eJHx8lWtIfxSum1jhskeTxtY/rVBA502jPteO2 1CVl5gY63IlJ66KXo4bybMMLY1YRV5K48oHZqxV1ETwMWgCKFOPOSc0s8BxcfRO2 3mVTg+mNgDSh8Qx/IdOVVS/LEhgrqBE+TOqAV6i8ReQqBvi0RNXov2NwRq5RdHS4 1EmX/4CeDtHE/4DNvF/kg0HNHMORX16EWZK7mMUsk0ctaboEEfgChFlggjhC//0= =CTKO -----END PGP SIGNATURE-----

3 3