December 2012 - DVDnav-discuss - lists.mplayerhq.hu

[patch] check pkg-config before xxx-config scripts
by Mike Frysinger 04 Dec '13

04 Dec '13

it's easier to manage pkg-config when cross-compiling, and libdvdread installs .pc files, so check those first -mike --- configure.ac (revision 1243) +++ configure.ac (working copy) @@ -89,6 +89,7 @@ AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL AC_PROG_LN_S +PKG_PROG_PKG_CONFIG dnl -------------------------------------------------------------- dnl Libtool @@ -185,15 +186,26 @@ AC_ARG_WITH([dvdread-config], [AS_HELP_STRING([--with-dvdread-config=PROG], [dvdread-config program to use @<:@default=from PATH@:>@])], [DVDREAD_CONFIG="$withval"], - [dnl User didn't specify program, search PATH - AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) - test "x$DVDREAD_CONFIG" = xno && \ - AC_MSG_ERROR([dvdread-config required to link with libdvdread]) - ]) -DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ - AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) -DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ - AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) + [DVDREAD_CONFIG=""]) + +dnl by default, search pkg-config, and then fall back to dvdread-config +DVDREAD_PKG_CONFIG="no" +if test "x$DVDREAD_CONFIG" = "x"; then + PKG_CHECK_MODULES([DVDREAD], [dvdread], + [DVDREAD_PKG_CONFIG="yes"], + [dnl User didn't specify program, search PATH + AC_PATH_PROG([DVDREAD_CONFIG], [dvdread-config], [no]) + test "x$DVDREAD_CONFIG" = xno && \ + AC_MSG_ERROR([dvdread-config required to link with libdvdread]) + ]) +fi +if test "x$DVDREAD_PKG_CONFIG" != "xyes"; then + DVDREAD_CFLAGS=`$DVDREAD_CONFIG --cflags` || \ + AC_MSG_ERROR([Could not get libdvdread CFLAGS from $DVDREAD_CONFIG]) + DVDREAD_LIBS=`$DVDREAD_CONFIG --libs` || \ + AC_MSG_ERROR([Could not get libdvdread LIBS from $DVDREAD_CONFIG]) +fi + AC_SUBST([DVDREAD_CFLAGS]) AC_SUBST([DVDREAD_LIBS])

3 5

dvdnav SEGFAULT patch for broken DVD
by Vincent Mussard 12 Nov '13

12 Nov '13

Dear all Maybe it will be useful for someone. Please find attached a patch I made, gathering patch made by other people (especialy from Fabian Keil in an email from Sat, 14 Jul 2012). I added on it an additionnal check (ptt[i].pgcn-1 >= ifo->vts_pgcit->nr_of_pgci_srp) that helps reading one of my broken ripped DVD. Regards Vincent

3 2

[PATCH] use newer dll name
by Roger Pack 06 Oct '13

06 Oct '13

For some reason on windows the dll name these days is almost always libdvdcss-2.dll instead of libdvdcss.dll (gstreamer, xbmc, etc.) This patch seems to work, and would make it to match, which seems better from my vantage. -roger-

5 7

assertion failure with certain DVD's
by Roger Pack 06 Oct '13

06 Oct '13

Hello all. I get the following assertion playing the "Tangled" DVD with mplayer and an up to date libdvdnav, on windows: Assertion failed: (vm->state).pgc->cell_playback[(vm->state).cellN - 1].block_mode != 0, file libdvdnav/vm/vm.c, line 1141 The weird part about this is that in mac/linux, I get this error message, and no failed assertion, and playing continues: libdvdnav: Invalid angle block I'd be happy to send more information, or a (legal) DVD to keep, for any developer that would like to tackle it. It appears that it happens with a few other (Disney?) DVD's, as well: http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-December/075458.html https://trac.handbrake.fr/ticket/125 https://forum.handbrake.fr/viewtopic.php?f=11&t=14189 So I'm guessing it's a libdvdnav bug. As a note, in VLC on windows, this causes playback to "loop" over - cellN=2 over and over, though it doesn't crash--I'm guessing it just swallows the assertion failure, or the failure isn't enabled with that build. Thanks. -roger-

4 8

[PATCH] fix dvdnav.h comment
by Roger Pack 06 Oct '13

06 Oct '13

I believe dvdnav_time_search *is* implemented, just somewhat inaccurately, so patch attempts to update comment in this regard. Thanks. -roger-

2 1

[PATCH] handle duplicate language units and pgc's more gracefully
by John Stebbins 05 Oct '13

05 Oct '13

This patch never got accepted (probably because it's touches a lot and made you nervous), but HandBrake has been applying this for 3 years now. Some discs have large numbers of repeated language units and pgc's that cause extreme memory consumption and file i/o issues. scanning all the titles on such discs is unusably slow. detect such repeats and ref-count the data structures to avoid reading and storing duplicate info.

6 15

[PATCH] do not close file twice
by Reimar Döffinger 05 Oct '13

05 Oct '13

There is another close further down that will always be reached. Current code will result in a double close. Index: vm/vm.c =================================================================== --- vm/vm.c (revision 1243) +++ vm/vm.c (working copy) @@ -176,7 +176,6 @@ off = lseek( fd, 32 * (off_t) DVD_VIDEO_LB_LEN, SEEK_SET ); if( off == ( 32 * (off_t) DVD_VIDEO_LB_LEN ) ) { off = read( fd, data, DVD_VIDEO_LB_LEN ); - close(fd); if (off == ( (off_t) DVD_VIDEO_LB_LEN )) { fprintf(MSG_OUT, "libdvdnav: DVD Title: "); for(i=25; i < 73; i++ ) {

5 13

[PATCH] fix dvdnav_convert_time to work for full range
by Reimar Döffinger 05 Oct '13

05 Oct '13

Hello, currently the calculation will use int and thus overflow for anything larger or equal to 20 hours. Not sure if this is the best/nicest way, personally I prefer to do this kind of thing with the result = hour >> 4; result *= 10; result += hour; result *= 6; result += minute >> 4; result *= 10; .... scheme, but this is the minimal change required. Index: dvdnav.c =================================================================== --- dvdnav.c (revision 1243) +++ dvdnav.c (working copy) @@ -203,7 +203,7 @@ int64_t result; int64_t frames; - result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000; + result = (time->hour >> 4 ) * 10 * 60 * 60 * 90000ull; result += (time->hour & 0x0f) * 60 * 60 * 90000; result += (time->minute >> 4 ) * 10 * 60 * 90000; result += (time->minute & 0x0f) * 60 * 90000;

3 2

[patch] Fix SIGSEGV in dvdnav_describe_title_chapters
by Sylvain HENRY 05 Oct '13

05 Oct '13

Hi, Please consider checking and applying the attached patch. It fixes a segfault occuring with some DVDs. It seems to be the same problem as the one mentionned here: https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/934471 In my case, "cellnr" and "endcellnr" variables were set to 0 when the crash occured. Cheers Sylvain PS: I'm not registered on the mailing-list, please answer directly to me if necessary

3 8

Re: [DVDnav-discuss] Error in libdvdnav when reading iso images
by Fabian Keil 05 Oct '13

05 Oct '13

Oncaphillis wrote in http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2012-May/001722.html: > I used to create DVD iso images via k3b and played them via VLC. > With isos of relatively newly released DVD this stops to work and > VLC fails with the message > > libdvdnav: demux error! 00 00 00 (should be 0x000001) > > Playing directly from /dev/dvd still works > > The distro is Fedora16 > + k3b == 2.0.2 > + libdvdcss == 1.2.11 ( I also tested 1.2.12) > + vlc = 1.1.13 > + libdvdnav 4.1.4. I also tried the current SVN build > > I get the same error when playing with mplayer and > I also tried brasero for iso creation. > > Since direct play works it seems like brasero/k3b have > problems to create a proper iso and the problems sits > somewhere in the libs. The above message can be generated when the ripping program has generously padded regions with unreadable sectors with binary zeros and one of the padded blocks is actually referenced in the ifos. In this case it's not the result of a bug in the libs (assuming you meant libdvdnav or libdvdread) but the result of a limitation in the program that is using them in combination with companies that interpret the relevant standards somewhat liberal. I'm not familiar with k3b or brasero and thus don't know if this is the cause of the issue, but at least it would explain why the real disc works and the copy doesn't. I've never seen the issue with discs that haven't obviously been mastered incorrectly, but I suppose it can also happen if the disc is scratched. In my experience, copies of intentionally incorrectly mastered discs that cause this issue when padding with zeroes, can usually be played correctly with VLC when padding with other blocks from the region that have been read correctly instead. It's not perfect, but can be sufficient to solve the issue. I'm still experimenting with this, though. With some of those copies I can trigger at least four different crashes in libdvdnav 4.2.0's dvdnav_describe_title_chapters(), that aren't triggered when ripping with zero padding which lets VLC rejects the disc right away. Recent VLC versions use this function, but one can work around it by undefining HAVE_DVDNAV_DESCRIBE_TITLE_CHAPTERS. VLC 1.1.3 doesn't seem to use the function yet and thus correctly plays the copies out of the box (I only confirmed the latter). One of these issues has already been fixed after the libdvdnav 4.2.0 release (https://bugs.launchpad.net/ubuntu/+source/libdvdnav/+bug/934471) but as far as I can tell the others still exist, or at least don't seem to be fixed in https://github.com/microe/libdvdnav and I haven't seen them mentioned when crawling the archives either. I attached the patches that seem to prevent these crashes for me. I'd appreciate comments on whether or not the skip conditions are reasonable, especially the one in patch 3. Note that I ran into the issues with copies where I now know that the padding has been done somewhat sloppy. I haven't tested yet if these crashes can be reached by playing the original discs. If not, I suspect that with a fancier padding algorithms the copies might play correctly as well. Fabian

4 4