October 2011 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] fix a memory leak
by Rémi Duraffort 06 Oct '11

06 Oct '11

Hello, this patch fix a potential memory leak and a memory leak I found when playing with valgrind. Best regards -- Rémi Duraffort | ivoire

4 5

r1237 - trunk/libdvdread/src/ifo_read.c
by rathann 06 Oct '11

06 Oct '11

Author: rathann Date: Thu Oct 6 23:02:00 2011 New Revision: 1237 Log: Fix memory leaks. Patch by Rémi Duraffort ^ivoire#videolan*org! Modified: trunk/libdvdread/src/ifo_read.c Modified: trunk/libdvdread/src/ifo_read.c ============================================================================== --- trunk/libdvdread/src/ifo_read.c Thu Oct 6 19:23:06 2011 (r1236) +++ trunk/libdvdread/src/ifo_read.c Thu Oct 6 23:02:00 2011 (r1237) @@ -1896,6 +1896,7 @@ static int ifoRead_PGCIT_internal(ifo_ha ifoFree_PGC(pgcit->pgci_srp[j].pgc); free(pgcit->pgci_srp[j].pgc); } + free(pgcit->pgci_srp[i].pgc); goto fail; } } @@ -1911,7 +1912,10 @@ static void ifoFree_PGCIT_internal(pgcit if(pgcit) { int i; for(i = 0; i < pgcit->nr_of_pgci_srp; i++) + { ifoFree_PGC(pgcit->pgci_srp[i].pgc); + free(pgcit->pgci_srp[i].pgc); + } free(pgcit->pgci_srp); } }

1 0

r1236 - trunk/libdvdread/ChangeLog
by rathann 06 Oct '11

06 Oct '11

Author: rathann Date: Thu Oct 6 19:23:06 2011 New Revision: 1236 Log: Update ChangeLog. Modified: trunk/libdvdread/ChangeLog Modified: trunk/libdvdread/ChangeLog ============================================================================== --- trunk/libdvdread/ChangeLog Thu Oct 6 18:09:55 2011 (r1235) +++ trunk/libdvdread/ChangeLog Thu Oct 6 19:23:06 2011 (r1236) @@ -1,8 +1,20 @@ libdvdread (4.1.4) * added OS/2 support * fixed ARM memory alignment issue - * portability fixes for *BSD, Mac OS X and MINGW + * portability fixes for *BSD, Mac OS X, MINGW and OS/2 * added a missing DVDFileStat function + * exposed the dvd_stat_t struct in header + * fixed libdvdread closing stdin if it can't open the file/device + * fixed a segfault in UDFFileEntry on some badly mastered DVDs + * fixed big-endian builds + * Win32: large file support under Mingw to go over 2G limits + * configure: remove the special case test for uid=0 + * provide BUP file support for more issues + * move UDFReadBlocksRaw declaration to dvdread_internal.h + * fixed double free of parental management information + * configure2: Use a single = instead of == + * fixed crash when PTT is too short + * fixed segfault when reading certain DVDs, for example "Thor" libdvdread (4.1.3) * an embarassing amount of fixes regarding potential memory and resource leaks

3 3

r1235 - trunk/libdvdnav/ChangeLog
by rathann 06 Oct '11

06 Oct '11

Author: rathann Date: Thu Oct 6 18:09:55 2011 New Revision: 1235 Log: Update changelog. Modified: trunk/libdvdnav/ChangeLog Modified: trunk/libdvdnav/ChangeLog ============================================================================== --- trunk/libdvdnav/ChangeLog Thu Oct 6 14:10:01 2011 (r1234) +++ trunk/libdvdnav/ChangeLog Thu Oct 6 18:09:55 2011 (r1235) @@ -2,6 +2,13 @@ libdvdnav (4.1.4) * OS/2 support * added dvdnav_get_serial_string() function * fixed ifo leak in dvdnav_describe_chapters() + * added dvdnav_get_video_resolution() to retrieve video resolution + * added dvdnav_program_play() & dvdnav_current_title_program() for + more reliable playback + * fixed deadlock between dvdnav_reset() and dvd_clear() + * fixed pthread_mutex_destroy macro for Win32 + * fixed numerous assertion failures occuring when playing DVDs with + new "copy protection" schemes libdvdnav (4.1.3) * an embarassing amount of fixes regarding potential memory and resource leaks

1 0

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

Re: [DVDnav-discuss] dvdnav patches from handbrake project
by Erik Hovland 06 Oct '11

06 Oct '11

>> Jean - Do VLC folk have anything to say about the patches that the >> handbrake folk submitted to this list? If VLC is running w/ them it would >> help the patches case in getting committed. > Sorry, but do you have a link to them? I do! Huge invasive patch to consolidate memory: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001097.html Bug fix for crashing: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001102.html Follow up patch for same crashing issue: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-December/001114.html E -- Erik Hovland erik(a)hovland.org http://hovland.org/

8 47

r1234 - trunk/libdvdread/src/dvd_udf.c
by rathann 06 Oct '11

06 Oct '11

Author: rathann Date: Thu Oct 6 14:10:01 2011 New Revision: 1234 Log: Fix segfault when reading certain DVDs, for example "Thor". This results from a new anti-copy scheme where the real video_ts.ifo is hidden. Use of the decoy video_ts.ifo results in a unplayable DVD. Patch by Alexander Roalter \alex!roalter*it/. Verified by John Stebbins |stebbins%jethaddev&com|. Modified: trunk/libdvdread/src/dvd_udf.c Modified: trunk/libdvdread/src/dvd_udf.c ============================================================================== --- trunk/libdvdread/src/dvd_udf.c Sat Aug 13 19:28:48 2011 (r1233) +++ trunk/libdvdread/src/dvd_udf.c Thu Oct 6 14:10:01 2011 (r1234) @@ -329,16 +329,17 @@ static int SetUDFCache(dvd_reader_t *dev static int Unicodedecode( uint8_t *data, int len, char *target ) { int p = 1, i = 0; + int err = 0; if( ( data[ 0 ] == 8 ) || ( data[ 0 ] == 16 ) ) do { - if( data[ 0 ] == 16 ) p++; /* Ignore MSB of unicode16 */ + if( data[ 0 ] == 16 ) err |= data[p++]; /* character cannot be converted to 8bit, return error */ if( p < len ) { target[ i++ ] = data[ p++ ]; } } while( p < len ); target[ i ] = '\0'; - return 0; + return !err; } static int UDFDescriptor( uint8_t *data, uint16_t *TagID ) @@ -490,8 +491,9 @@ static int UDFFileIdentifier( uint8_t *d L_FI = GETN1(19); UDFLongAD(&data[20], FileICB); L_IU = GETN2(36); - if (L_FI) Unicodedecode(&data[38 + L_IU], L_FI, FileName); - else FileName[0] = '\0'; + if (L_FI) { + if (!Unicodedecode(&data[38 + L_IU], L_FI, FileName)) FileName[0] = 0; + } else FileName[0] = '\0'; return 4 * ((38 + L_FI + L_IU + 3) / 4); }

3 2

[PATCH] crash while processing mac the ripper "feature title extract" images
by John Stebbins 06 Oct '11

06 Oct '11

Mac the ripper's feature title extraction removes menus from the resulting image, but does not remove navigation instructions that attempt to jump to those menus. This patch checks that a menu exists before acting on such instructions. If the menu does not exist, the it puts the vm into the stopped state.

3 6

Libdvdread misses hidden files and causes segfaults to calling programs
by doug Springer 06 Oct '11

06 Oct '11

Package: libdvdread4 Version: 4.1.4-1219-2 and others No error message, but symptoms are usually segfault when reading, for example the Movie DVD Thor. This results from a new anti-copy scheme where the real video_ts.ifo is hidden. Use of the decoy video_ts.ifo results in a unplayable DVD. Discussion is here: http://ubuntuforums.org/showthread.php?p=11257764 Patch is here: diff -ru libdvdread-4.1.3/src/dvd_udf.c libdvdread-4.1.3.fixed/src/dvd_udf.c --- libdvdread-4.1.3/src/dvd_udf.c 2008-09-06 15:55:51.000000000 -0600 +++ libdvdread-4.1.3.fixed/src/dvd_udf.c 2011-09-16 14:07:04.000000000 -0600 @@ -331,21 +331,26 @@ /* This is wrong with regard to endianess */ #define GETN(p, n, target) memcpy(target,&data[p], n) -static int Unicodedecode( uint8_t *data, int len, char *target ) +static int Unicodedecode(uint8_t *data, int len, char *target) { - int p = 1, i = 0; + len--; + data++; + if (data[-1] == 8 ) + memcpy(target, data, len); + else if (data[-1] == 16) { + int i; - if( ( data[ 0 ] == 8 ) || ( data[ 0 ] == 16 ) ) do { - if( data[ 0 ] == 16 ) p++; /* Ignore MSB of unicode16 */ - if( p< len ) { - target[ i++ ] = data[ p++ ]; + for (i = 0; i< len; i++) { + if (data[i*2] == 0) + target[i] = data[i*2+1]; + else + target[i] = 0; } - } while( p< len ); + } + target[len] = '\0'; - target[ i ] = '\0'; return 0; } - static int UDFDescriptor( uint8_t *data, uint16_t *TagID ) { *TagID = GETN2(0);

9 15