October 2011 - DVDnav-discuss - lists.mplayerhq.hu

libdvdread/libdvdnav 4.2.0 release candidate
by Dominik 'Rathann' Mierzejewski 08 Oct '11

08 Oct '11

Hi all, the website is up at http://dvdnav.mplayerhq.hu/ and the 4.2.0 tarballs for libdvdread and libdvdnav have been uploaded to http://dvdnav.mplayerhq.hu/releases/ Please download and test. If there are no issues, I intend to post the release announcement on Monday. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

1 0

r1243 - in trunk: libdvdnav/ChangeLog libdvdread/ChangeLog
by rathann 08 Oct '11

08 Oct '11

Author: rathann Date: Sun Oct 9 00:04:05 2011 New Revision: 1243 Log: Update version number in changelogs. Modified: trunk/libdvdnav/ChangeLog trunk/libdvdread/ChangeLog Modified: trunk/libdvdnav/ChangeLog ============================================================================== --- trunk/libdvdnav/ChangeLog Sat Oct 8 23:49:29 2011 (r1242) +++ trunk/libdvdnav/ChangeLog Sun Oct 9 00:04:05 2011 (r1243) @@ -1,4 +1,4 @@ -libdvdnav (4.1.4) +libdvdnav (4.2.0) * OS/2 support * added dvdnav_get_serial_string() function * fixed ifo leak in dvdnav_describe_chapters() Modified: trunk/libdvdread/ChangeLog ============================================================================== --- trunk/libdvdread/ChangeLog Sat Oct 8 23:49:29 2011 (r1242) +++ trunk/libdvdread/ChangeLog Sun Oct 9 00:04:05 2011 (r1243) @@ -1,4 +1,4 @@ -libdvdread (4.1.4) +libdvdread (4.2.0) * added OS/2 support * fixed ARM memory alignment issue * portability fixes for *BSD, Mac OS X, MINGW and OS/2

1 0

r1242 - in trunk: libdvdnav/README libdvdread/README
by rathann 08 Oct '11

08 Oct '11

Author: rathann Date: Sat Oct 8 23:49:29 2011 New Revision: 1242 Log: Point project website URL to the new location. Modified: trunk/libdvdnav/README trunk/libdvdread/README Modified: trunk/libdvdnav/README ============================================================================== --- trunk/libdvdnav/README Fri Oct 7 22:20:59 2011 (r1241) +++ trunk/libdvdnav/README Sat Oct 8 23:49:29 2011 (r1242) @@ -26,7 +26,7 @@ from xine-dvdnav and went into the first Where is it now? ---------------- -libdvdnav is hosted on http://www.mplayerhq.hu/MPlayer/releases/dvdnav/ . +libdvdnav is hosted at http://dvdnav.mplayerhq.hu/ . Please report bugs to the developers mailinglist at mailto:dvdnav-discuss@mplayerhq.hu . Modified: trunk/libdvdread/README ============================================================================== --- trunk/libdvdread/README Fri Oct 7 22:20:59 2011 (r1241) +++ trunk/libdvdread/README Sat Oct 8 23:49:29 2011 (r1242) @@ -26,7 +26,7 @@ from xine-dvdnav and went into the first Where is it now? ---------------- -libdvdnav is hosted on http://www.mplayerhq.hu/MPlayer/releases/dvdnav/ . +libdvdnav is hosted on http://dvdnav.mplayerhq.hu/ . Please report bugs to the developers mailinglist at mailto:dvdnav-discuss@mplayerhq.hu .

1 0

Crashes when opening a .iso or .img that is incomplete
by Janton Koster 08 Oct '11

08 Oct '11

I sometimes use VLC to play .iso or .img files i download. Sometimes these files are not yet full downloaded but then VLC crashes, ok not so strainge because the file is incomplete... but it bothers me that it crashes. I will try to attach a small part of a incomplete iso/img. I hope it's simular, i used hjsplit to cut the first 10MB from a .iso . When i open this file VLC also crashes, so i think it's the simular problem. Ok i just uploaded the 10MB file here: http://www.2shared.com/file/ft-2xtP1/test.html Assertion failure in libdvdnav. I guess the problem is, libdvdnav want's to load a navigation menu that is not there (yet) If i remove libdvdnav.dll from VLC install directory, i can watch the content.. Perhaps the same thing happends in Mplayer? Is this something that could be fixed?

2 3

release
by Dominik 'Rathann' Mierzejewski 08 Oct '11

08 Oct '11

Dear all, as some of you had already guessed from the recent activity, I'm planning a release. I'm thinking of bumping the version to 4.2.0, since we have quite a lot of changes, including some new functions. Comments? If you can review the patches I bumped up (or need them resent), please do or say so. In the meantime, I'm working on setting up a project webpage at http://dvdnav.mplayerhq.hu/ . I'll try to post a preview version somewhere as soon as it's more or less up to date, but keep in mind that I'm no web designer, so help is welcome. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

2 2

r1241 - in trunk: libdvdnav/configure.ac libdvdnav/configure2 libdvdread/configure.ac libdvdread/configure2
by rathann 07 Oct '11

07 Oct '11

Author: rathann Date: Fri Oct 7 22:20:59 2011 New Revision: 1241 Log: Bump version to 4.2.0 for release. Modified: trunk/libdvdnav/configure.ac trunk/libdvdnav/configure2 trunk/libdvdread/configure.ac trunk/libdvdread/configure2 Modified: trunk/libdvdnav/configure.ac ============================================================================== --- trunk/libdvdnav/configure.ac Fri Oct 7 22:16:41 2011 (r1240) +++ trunk/libdvdnav/configure.ac Fri Oct 7 22:20:59 2011 (r1241) @@ -13,8 +13,8 @@ dnl dnl These are defined in m4 so they can be passed to AC_INIT dnl -------------------------------------------------------------- m4_define([dvdnav_major], [4]) -m4_define([dvdnav_minor], [1]) -m4_define([dvdnav_sub], [4]) +m4_define([dvdnav_minor], [2]) +m4_define([dvdnav_sub], [0]) m4_define([dvdnav_pre], []) AC_INIT([libdvdnav], [dvdnav_major.dvdnav_minor.dvdnav_sub[]dvdnav_pre]) Modified: trunk/libdvdnav/configure2 ============================================================================== --- trunk/libdvdnav/configure2 Fri Oct 7 22:16:41 2011 (r1240) +++ trunk/libdvdnav/configure2 Fri Oct 7 22:20:59 2011 (r1241) @@ -1,6 +1,6 @@ #!/bin/sh -dvdnav_sh_version=4.1.4 +dvdnav_sh_version=4.2.0 dvdnav_sh_major=`echo $dvdnav_sh_version | awk -F. '{print $1}'` cc=gcc Modified: trunk/libdvdread/configure.ac ============================================================================== --- trunk/libdvdread/configure.ac Fri Oct 7 22:16:41 2011 (r1240) +++ trunk/libdvdread/configure.ac Fri Oct 7 22:20:59 2011 (r1241) @@ -13,8 +13,8 @@ dnl dnl These are defined in m4 so they can be passed to AC_INIT dnl -------------------------------------------------------------- m4_define([dvdread_major], [4]) -m4_define([dvdread_minor], [1]) -m4_define([dvdread_sub], [4]) +m4_define([dvdread_minor], [2]) +m4_define([dvdread_sub], [0]) m4_define([dvdread_pre], []) AC_INIT([libdvdread], [dvdread_major.dvdread_minor.dvdread_sub[]dvdread_pre]) Modified: trunk/libdvdread/configure2 ============================================================================== --- trunk/libdvdread/configure2 Fri Oct 7 22:16:41 2011 (r1240) +++ trunk/libdvdread/configure2 Fri Oct 7 22:20:59 2011 (r1241) @@ -1,6 +1,6 @@ #!/bin/sh -dvdread_sh_version=4.1.4 +dvdread_sh_version=4.2.0 dvdread_sh_major=`echo $dvdread_sh_version | awk -F. '{print $1}'` cc=gcc

1 0

r1240 - trunk/libdvdnav/ChangeLog
by rathann 07 Oct '11

07 Oct '11

Author: rathann Date: Fri Oct 7 22:16:41 2011 New Revision: 1240 Log: Mention guaranteed forward seeks in the ChangeLog. Modified: trunk/libdvdnav/ChangeLog Modified: trunk/libdvdnav/ChangeLog ============================================================================== --- trunk/libdvdnav/ChangeLog Fri Oct 7 19:06:24 2011 (r1239) +++ trunk/libdvdnav/ChangeLog Fri Oct 7 22:16:41 2011 (r1240) @@ -9,6 +9,7 @@ libdvdnav (4.1.4) * fixed pthread_mutex_destroy macro for Win32 * fixed numerous assertion failures occuring when playing DVDs with new "copy protection" schemes + * fixed forward seeks to always move forward libdvdnav (4.1.3) * an embarassing amount of fixes regarding potential memory and resource leaks

1 0

r1239 - trunk/libdvdnav/src/searching.c
by erik 07 Oct '11

07 Oct '11

Author: erik Date: Fri Oct 7 19:06:24 2011 New Revision: 1239 Log: Always attempt to move forward on a seek >From John Stebbins original post (with pathc, Thanks!): libdvdnav has a problem in that it is difficult to gracefully recover from a read error and continue on to subsequent blocks on the disc. An application would like to seek forward past the current block after getting a read error in order to attempt to get past the bad block(s). But dvdnav_sector_search() does not guarantee that a requested forward seek will actually move the current position forward. It truncates down to the nearest VOBU which will almost always cause a forward seek request by a single block (or a small number of blocks) to move the current position backward. This behaviour puts the application into a loop of: read failure, attempted forward seek (which results in backward seek), read failure ... Modified: trunk/libdvdnav/src/searching.c Modified: trunk/libdvdnav/src/searching.c ============================================================================== --- trunk/libdvdnav/src/searching.c Fri Oct 7 18:56:02 2011 (r1238) +++ trunk/libdvdnav/src/searching.c Fri Oct 7 19:06:24 2011 (r1239) @@ -47,7 +47,7 @@ /* Return placed in vobu. */ /* Returns error status */ /* FIXME: Maybe need to handle seeking outside current cell. */ -static dvdnav_status_t dvdnav_scan_admap(dvdnav_t *this, int32_t domain, uint32_t seekto_block, uint32_t *vobu) { +static dvdnav_status_t dvdnav_scan_admap(dvdnav_t *this, int32_t domain, uint32_t seekto_block, int next, uint32_t *vobu) { vobu_admap_t *admap = NULL; #ifdef LOG_DEBUG @@ -89,7 +89,7 @@ static dvdnav_status_t dvdnav_scan_admap vobu_start = next_vobu; address++; } - *vobu = vobu_start; + *vobu = next ? next_vobu : vobu_start; return DVDNAV_STATUS_OK; } fprintf(MSG_OUT, "libdvdnav: admap not located\n"); @@ -160,7 +160,7 @@ dvdnav_status_t dvdnav_time_search(dvdna fprintf(MSG_OUT, "libdvdnav: Seeking to cell %i from choice of %i to %i\n", cell_nr, first_cell_nr, last_cell_nr); #endif - if (dvdnav_scan_admap(this, state->domain, target, &vobu) == DVDNAV_STATUS_OK) { + if (dvdnav_scan_admap(this, state->domain, target, 0, &vobu) == DVDNAV_STATUS_OK) { uint32_t start = state->pgc->cell_playback[cell_nr-1].first_sector; if (vm_jump_cell_block(this->vm, cell_nr, vobu - start)) { @@ -184,9 +184,13 @@ dvdnav_status_t dvdnav_time_search(dvdna dvdnav_status_t dvdnav_sector_search(dvdnav_t *this, uint64_t offset, int32_t origin) { uint32_t target = 0; + uint32_t current_pos; + uint32_t cur_sector; + uint32_t cur_cell_nr; uint32_t length = 0; uint32_t first_cell_nr, last_cell_nr, cell_nr; int32_t found; + int forward = 0; cell_playback_t *cell; dvd_state_t *state; dvdnav_status_t result; @@ -213,6 +217,10 @@ dvdnav_status_t dvdnav_sector_search(dvd fprintf(MSG_OUT, "libdvdnav: Before cellN=%u blockN=%u\n", state->cellN, state->blockN); #endif + current_pos = target; + cur_sector = this->vobu.vobu_start + this->vobu.blockN; + cur_cell_nr = state->cellN; + switch(origin) { case SEEK_SET: if(offset >= length) { @@ -244,6 +252,7 @@ dvdnav_status_t dvdnav_sector_search(dvd pthread_mutex_unlock(&this->vm_lock); return DVDNAV_STATUS_ERR; } + forward = target > current_pos; this->cur_cell_time = 0; if (this->pgc_based) { @@ -270,6 +279,27 @@ dvdnav_status_t dvdnav_sector_search(dvd } else { /* convert the target sector from Cell-relative to absolute physical sector */ target += cell->first_sector; + if (forward && (cell_nr == cur_cell_nr)) { + uint32_t vobu; + /* if we are seeking forward from the current position, make sure + * we move to a new position that is after our current position. + * simply truncating to the vobu will go backwards */ + if (dvdnav_scan_admap(this, state->domain, target, 0, &vobu) != DVDNAV_STATUS_OK) + break; + if (vobu <= cur_sector) { + if (dvdnav_scan_admap(this, state->domain, target, 1, &vobu) != DVDNAV_STATUS_OK) + break; + if (vobu > cell->last_sector) { + if (cell_nr == last_cell_nr) + break; + cell_nr++; + cell = &(state->pgc->cell_playback[cell_nr-1]); + target = cell->first_sector; + } else { + target = vobu; + } + } + } found = 1; break; } @@ -281,7 +311,7 @@ dvdnav_status_t dvdnav_sector_search(dvd fprintf(MSG_OUT, "libdvdnav: Seeking to cell %i from choice of %i to %i\n", cell_nr, first_cell_nr, last_cell_nr); #endif - if (dvdnav_scan_admap(this, state->domain, target, &vobu) == DVDNAV_STATUS_OK) { + if (dvdnav_scan_admap(this, state->domain, target, 0, &vobu) == DVDNAV_STATUS_OK) { int32_t start = state->pgc->cell_playback[cell_nr-1].first_sector; if (vm_jump_cell_block(this->vm, cell_nr, vobu - start)) {

1 0

[PATCH] libdvdread: segfault and patch to fix it (again)
by Frédéric Marchal 07 Oct '11

07 Oct '11

Hello, On July 11th, Morten Sjøgren reported a segfault due to the double free of a buffer in ifoFree_PTL_MAIT and provided a patch: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-July/066025.html The patch was taken into account by Dominik 'Rathann' Mierzejewski on September 2nd: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-September/066033.h… The patch is incomplete as ifoRead_PTL_MAIT can still return without resetting the pointer in ifofile->ptl_mait. In my case, I have two DVDs failing due an invalid seek offset passed to DVDFileSeek_(). The following patch set ifofile->ptl_mait to NULL (not 0 as in the original patch) before every return statement. Moreover, if the seek offset is obviously out of range, the loop over the countries is interrupted and the nr_of_countries is set to the index of the highest country that could be read. I'm not sure it is the proper action but without a test case to disprove it, it sound sensible as nr_of_countries doesn't seem to be used. Frederic

4 7

r1238 - trunk/libdvdread/src/ifo_read.c
by erik 07 Oct '11

07 Oct '11

Author: erik Date: Fri Oct 7 18:56:02 2011 New Revision: 1238 Log: Use NULL instead of 0 consistently. Since this is C and not C++, NULL is the stylistic choice for pointer assignments and checking. This patch, kindly submitted by Frederic Marchal <fmarchal AT perso DOT be> changes all of places were ptl_mait is used in ifo_read.c. Thanks! Modified: trunk/libdvdread/src/ifo_read.c Modified: trunk/libdvdread/src/ifo_read.c ============================================================================== --- trunk/libdvdread/src/ifo_read.c Thu Oct 6 23:02:00 2011 (r1237) +++ trunk/libdvdread/src/ifo_read.c Fri Oct 7 18:56:02 2011 (r1238) @@ -1291,7 +1291,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofi if(!ifofile->vmgi_mat) return 0; - if(ifofile->vmgi_mat->ptl_mait == 0) + if(ifofile->vmgi_mat->ptl_mait == NULL) return 1; if(!DVDFileSeek_(ifofile->file, ifofile->vmgi_mat->ptl_mait * DVD_BLOCK_LEN)) @@ -1305,7 +1305,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofi if(!(DVDReadBytes(ifofile->file, ptl_mait, PTL_MAIT_SIZE))) { free(ptl_mait); - ifofile->ptl_mait = 0; + ifofile->ptl_mait = NULL; return 0; } @@ -1324,7 +1324,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofi ptl_mait->countries = (ptl_mait_country_t *)malloc(info_length); if(!ptl_mait->countries) { free(ptl_mait); - ifofile->ptl_mait = 0; + ifofile->ptl_mait = NULL; return 0; } for(i = 0; i < ptl_mait->nr_of_countries; i++) { @@ -1336,7 +1336,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofi fprintf(stderr, "libdvdread: Unable to read PTL_MAIT.\n"); free(ptl_mait->countries); free(ptl_mait); - ifofile->ptl_mait = 0; + ifofile->ptl_mait = NULL; return 0; } } @@ -1415,7 +1415,7 @@ void ifoFree_PTL_MAIT(ifo_handle_t *ifof } free(ifofile->ptl_mait->countries); free(ifofile->ptl_mait); - ifofile->ptl_mait = 0; + ifofile->ptl_mait = NULL; } }

1 0