October 2011 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] Make sure we get nav packets for all cells in multi angle
by Joakim Plate 09 Dec '12

09 Dec '12

Hi, This is a resend of an old patch that we still keep in xbmc's version of libdvdnav. The problem is that libdvdnav jumps over NAV packets when playing multi angle features. I don't remember all the exact details on this patch anymore since it was many years since i tracked it down. But it is very obvious in xbmc since we use nav packet end/start times to correct timestamps. Without the patch we git gaps in nav packets that doesn's exist in the streams. I think i still have a dvd sample that shows the issue. /Joakim

3 5

libdvdnav 4.1.4
by Jean-Jacques Sarton 09 Dec '12

09 Dec '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Fedora 14 totem and vlc end both with folowing message: libdvdread: Found 1 VTS's libdvdread: Elapsed time 0 libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: Language 'en' not found, using '' instead libdvdnav: Menu Languages available: libdvdnav: *** pgci_ut handle is NULL *** totem: /builddir/build/BUILD/libdvdnav-4.1.4/src/vm/vm.c:1772: get_ID: Assertion `pgcit != ((void *)0)' failed. Of course tje line totem:... is to be replaced withz vlc:... according to the used player The dvd contain no menu and contain a privat video. If I rename libdvdnav totem/vlc works. Regards, Jean-Jacques Sarton -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk0h3bAACgkQM9JbiR3CwQsEEgCggN7qJrKQXspNYBJbCGRh237R +joAn1pQaRWHFN+nASDqRbL6Jgj3CM5S =iNgb -----END PGP SIGNATURE-----

4 6

[PATCH] consuming all memory when scanning dvd "Up"
by John Stebbins 09 Dec '12

09 Dec '12

First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.

3 5

[PATCH] Fix a package error
by KO Myung-Hun 17 Nov '11

17 Nov '11

Hi/2. I attach 3 patches to fix a package error. ----- dvdnav-remove-mkinstalldirs.diff This removes mkinstalldirs from Makefile.am. mkinstalldirs is really required ? ----- dvdread-remove-mkinstalldirs.diff Ditto. ----- dvdread-remove-absent-sources.diff dvd_udf.h and bitreader.h are not in src. Due to this, 'make distdir' fails. -- KO Myung-Hun Using Mozilla SeaMonkey 2.0.14 Under OS/2 Warp 4 for Korean with FixPak #15 On AMD ThunderBird 1GHz with 512 MB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr

3 4

OSD wrong decimal points with DVD/DVDNAV
by Roger Pack 16 Nov '11

16 Nov '11

Hello. I noticed the other day that the fraction timestamp gets "out of sync" in the OSD, when playing DVD/DVDNAV in mplayer, a la $ mplayer dvdnav:// -osdlevel 1 -osd-fractions 1 ex output (OSD outputs are the following): ... 00:00:04.24 00:00:04.27 00:00:04.30 ... 00:00:04.94 00:00:04.97 00:00:04.01 # lose a second 00:00:04.04 00:00:04.07 00:00:04.11 00:00:04.14 00:00:04.17 00:00:04.21 00:00:05.24 # regain it 00:00:05.27 00:00:05.31 ... It appears from a casual perusal that this is because the "second" pts count is being taken from demuxer_get_current_time (which returns the DVD's latest nav packet second, only updated maybe every 0.4s), but the numbers after the decimal point are being inferred from mpctx->sh_video->pts, the raw mpeg packet, which is slightly different. So it gets out of sync. So I'm assuming that a "good fix" for this would be to try to make dvdnav_get_current_time return a more precise timestamp, then passing that through and using only that for both the decimal and second counters. So...question: anybody know how to get "exact" DVD timing information within dvdnav? Any hints/clues? Any other words of advice before I dive in? Does my approach seem reasonable? I could also kind of hacky work-around it by remembering when the previous NAV packet was and calculating the time between then and now [1] but I'd guess that's not ideal... Also while looking at this, I noticed that 1) sometimes the mpeg video stream in DVD's starts about 0.28s "before" the NAV packets say the movie starts. 2) the NAV packets seems to not be off from this a bit. For example at second 0.70 they will say "it's second 0.5 now" anybody know why that might be? My guess is that they don't take that first 0.28 into consideration somehow...(which, coincidentally, when you rip it, it typically says that start second 0 is the same as DVD Vaguely related: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2010-June/001202.html http://forum.videolan.org/viewtopic.php?f=32&t=76308&p=315461#p315461 https://github.com/Kovensky/mplayer-kovensky/blob/master/stream/stream_dvd.… http://trac.videolan.org/vlc/ticket/4 et al. Thanks. -roger-

1 1

[ANNOUNCE] libdvdread/libdvdnav 4.2.0 release
by Dominik 'Rathann' Mierzejewski 15 Nov '11

15 Nov '11

Dear all, After a long break, we're happy to announce another release. We added some new features (e.g. OS/2 support, new APIs in libdvdnav), fixed a number of bugs and improved playback of badly mastered or "copy protected" DVDs. I wish to thank all contributors who submitted patches and did the testing. Keep up the good work! We also have a new project website at http://dvdnav.mplayerhq.hu/ . Big thanks to Arpi and Michael for providing the space and helping me set up the website. Download links for the 4.2.0 release are below: http://dvdnav.mplayerhq.hu/releases/libdvdread-4.2.0.tar.bz2 http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.0.tar.bz2 Enjoy! Best regards, Dominik Mierzejewski -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

2 2

old releases dir
by Roger Pack 26 Oct '11

26 Oct '11

Question. Noticed this release dir http://www.mplayerhq.hu/MPlayer/releases/dvdnav which appears out dated. Maybe something should be done? Just pointing it out in case it's not common knowledge. Thanks! -roger-

3 3

[PATCH] fix dvdnav multi-cell menus
by Steaphan Greene 20 Oct '11

20 Oct '11

As previously sent to mplayer-dev-eng, but with a separate version not including any white-space changes (both attached patches are otherwise identical): Many DVDs with long menus (interactive DVDs or DVD "games" often treat the entire "movie" as a menu) don't work correctly in mplayer's dvdnav. As soon as they change to a new cell, the DVD stops working - It just drops the audio and corrupts the video by, I believe, playing the previous video chunk over and over. The navigation controls continue to work, though. The problem seems to be that when a new cell is encountered, the dvdnav code indicates it should wait for sync with the application. However, the code does not actually advance to the next cell (it assumes this case is hit only with still frames, even though the condition also catches the case of cell-changes within menus). Also, once the code to advance to the next block is enabled, by fixing that condition, it still fails in the same way. This seems to be because the "wait_sync = 1;" is a terminal condition here. Again, it assumes this is for still frames only and is waiting for the next still frame to be selected (which sets sync_wait back to 0). The attached patch fixes both of these issues, and I have tested it extensively (always with my MPEG2 sync patch, of course) with both normal, and interactive DVDs, and including several examples of actual still frames. It seems to solve the problem and cause no other new ones that I can find. Of course, I could be wrong about all of this (but I don't think so). Thanks. -- Steaphan Greene <sgreene(a)cs.binghamton.edu> Lecturer, Computer Science, Binghamton University GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt

4 6

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

old libdvdread utilities
by Steve Dibb 10 Oct '11

10 Oct '11

Hi guys, Older versions of libdvdread (0.9.7) used to ship with a few small utilities in the src/ directory. Specifically: disc_id, filestat, ifo_dump, play_title and title_info. Is there any chance of getting these re-included in the package? They might need to be ported, I'm not sure. I looked in the SVN log and I didn't see any notice about them getting removed. The disc_id one is particularly helpful to me, and I've been using it in some scripts of mine. If you need an old copy of the archive, you can get it off Gentoo's distfiles mirror for now: http://distfiles.gentoo.org/distfiles/libdvdread-0.9.7.tar.gz Thanks, Steve

2 1