June 2010 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] consuming all memory when scanning dvd "Up"
by John Stebbins 09 Dec '12

09 Dec '12

First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.

3 5

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 11 Oct '11

11 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

Re: [DVDnav-discuss] dvdnav patches from handbrake project
by Erik Hovland 06 Oct '11

06 Oct '11

>> Jean - Do VLC folk have anything to say about the patches that the >> handbrake folk submitted to this list? If VLC is running w/ them it would >> help the patches case in getting committed. > Sorry, but do you have a link to them? I do! Huge invasive patch to consolidate memory: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001097.html Bug fix for crashing: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001102.html Follow up patch for same crashing issue: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-December/001114.html E -- Erik Hovland erik(a)hovland.org http://hovland.org/

8 47

[PATCH] crash while processing mac the ripper "feature title extract" images
by John Stebbins 06 Oct '11

06 Oct '11

Mac the ripper's feature title extraction removes menus from the resulting image, but does not remove navigation instructions that attempt to jump to those menus. This patch checks that a menu exists before acting on such instructions. If the menu does not exist, the it puts the vm into the stopped state.

3 6

Assertion failure in src/vm/vm.c:1102
by Dominik 'Rathann' Mierzejewski 24 Nov '10

24 Nov '10

Hi. I got a crash report from Fedora's new automated bugreporter. It happened in totem, but the crash came from a failed assertion: "totem: /builddir/build/BUILD/libdvdnav-4.1.4/src/vm/vm.c:1102: play_Cell: La declaracin `0' no se cumple.\n" I don't have any information on how to reproduce it, but maybe one of you has an idea why this might happen and how to fix it. The original bugreport is here: https://bugzilla.redhat.com/show_bug.cgi?id=539446 -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

2 1

libdvdnav: ifoOpenVTSI failed
by Rich E 19 Jul '10

19 Jul '10

Hi, I have been trying to sort this problem out that is occuring using both totem and vlc in ubuntu 10.04 (packages from apt). It seems to be a problem reading the encrypted title, wherin the player just opens and closes without showing any error. Running from the terminal produces: r@r-laptop:/usr/share/doc/libdvdnav4$ vlc VLC media player 1.0.6 Goldeneye [0x8be0148] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface. libdvdnav: Using dvdnav version 4.1.3 libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdnav: DVD Title: MOTORCYCLE_DIARIES libdvdnav: DVD Serial Number: 42536705___MVB__ libdvdnav: DVD Title (Alternative): libdvdnav: Unable to find map file '/home/r/.dvdnav/MOTORCYCLE_DIARIES.map' libdvdnav: DVD disk reports itself with Region mask 0x00f70000. Regions: 4 libdvdread: Attempting to retrieve all CSS keys libdvdread: This can take a _long_ time, please be patient libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x0000014e libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x000001ba libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x0000f475 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_0.VOB at 0x0001210b libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x00012158 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_0.VOB at 0x002cdca0 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x002cdced libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_0.VOB at 0x00308e7b libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_1.VOB at 0x00308ec8 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_05_0.VOB at 0x0032e4b8 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_05_1.VOB at 0x0032e505 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_06_0.VOB at 0x003958a6 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_06_1.VOB at 0x003958f3 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_07_0.VOB at 0x003b6bb9 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_07_1.VOB at 0x003b6c06 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_08_0.VOB at 0x003be3ba libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_08_1.VOB at 0x003be407 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_09_0.VOB at 0x003d25bb libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_09_1.VOB at 0x003d2608 libdvdread: Elapsed time 0 libdvdread: Found 9 VTS's libdvdread: Elapsed time 0 libdvdread: Invalid IFO for title 1 (VTS_01_0.IFO). libdvdnav: ifoOpenVTSI failed vlc: /build/buildd/libdvdnav-4.1.3/src/vm/vm.c:1485: process_command: Assertion `0' failed. Aborted I also just tried installed mplayer from source and I get a similar problem. Here is the output of that: r@r-laptop:~/Downloads/mplayer-export-2010-06-22$ mplayer dvdnav://1 MPlayer SVN-r31525-snapshot-4.4.3 (C) 2000-2010 MPlayer Team Playing dvdnav://1. libdvdnav: Using dvdnav version MPlayer-custom libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdnav: DVD Title: MOTORCYCLE_DIARIES libdvdnav: DVD Serial Number: 42536705___MVB__ libdvdnav: DVD Title (Alternative): libdvdnav: Unable to find map file '/home/r/.dvdnav/MOTORCYCLE_DIARIES.map' libdvdnav: DVD disk reports itself with Region mask 0x00f70000. Regions: 4 libdvdread: Attempting to retrieve all CSS keys libdvdread: This can take a _long_ time, please be patient libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x0000014e libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x000001ba libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x0000f475 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_0.VOB at 0x0001210b libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x00012158 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_0.VOB at 0x002cdca0 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x002cdced libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_0.VOB at 0x00308e7b libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_04_1.VOB at 0x00308ec8 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_05_0.VOB at 0x0032e4b8 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_05_1.VOB at 0x0032e505 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_06_0.VOB at 0x003958a6 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_06_1.VOB at 0x003958f3 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_07_0.VOB at 0x003b6bb9 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_07_1.VOB at 0x003b6c06 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_08_0.VOB at 0x003be3ba libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_08_1.VOB at 0x003be407 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_09_0.VOB at 0x003d25bb libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_09_1.VOB at 0x003d2608 libdvdread: Elapsed time 0 libdvdread: Found 9 VTS's libdvdread: Elapsed time 0 libdvdread: Invalid IFO for title 1 (VTS_01_0.IFO). libdvdnav: ifoOpenVTSI failed mplayer: libdvdnav/vm/vm.c:1512: process_command: Assertion `0' failed. MPlayer interrupted by signal 6 in module: open_stream - MPlayer crashed. This shouldn't happen. It can be a bug in the MPlayer code _or_ in your drivers _or_ in your gcc version. If you think it's MPlayer's fault, please read DOCS/HTML/en/bugreports.html and follow the instructions there. We can't and won't help unless you provide this information when reporting a possible bug. r@r-laptop:~/Downloads/mplayer-export-2010-06-22$ Any help or suggestions are greatly appreciated! Please let me know if I can help at all, too. Thanks, Rich

3 8

dvdnav stream read error
by Rich E 06 Jul '10

06 Jul '10

Hi, Sorry to lay on the problems, but I just tried my only _other_ dvd and had another failure: r@r-laptop:~/Downloads/mplayer-export-2010-06-22/libdvdnav$ mplayer dvdnav://1 MPlayer SVN-r31525-snapshot-4.4.3 (C) 2000-2010 MPlayer Team Playing dvdnav://1. libdvdnav: Using dvdnav version MPlayer-custom libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdnav: DVD Title: BEING_JOHN_MALKOVICH libdvdnav: DVD Serial Number: 28f241a2 libdvdnav: DVD Title (Alternative): libdvdnav: Unable to find map file '/home/r/.dvdnav/BEING_JOHN_MALKOVICH.map' libdvdnav: DVD disk reports itself with Region mask 0x00f50000. Regions: 2 4 libdvdread: Attempting to retrieve all CSS keys libdvdread: This can take a _long_ time, please be patient libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x00000132 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x00000624 libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_01_0.VOB (0x00000624) libdvdread: Elapsed time 3 libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x0000bf79 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_0.VOB at 0x0032072c libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_02_0.VOB (0x0032072c) libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x00320731 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_0.VOB at 0x0035cbe0 libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_03_0.VOB (0x0035cbe0) libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x0035cbe5 libdvdread: Elapsed time 0 libdvdread: Found 3 VTS's libdvdread: Elapsed time 3 audio stream: 0 format: ac3 (5.1) language: en aid: 128. audio stream: 1 format: ac3 (5.1) language: de aid: 129. audio stream: 2 format: ac3 (5.1) language: fr aid: 130. subtitle ( sid ): 0 language: en subtitle ( sid ): 1 language: fr subtitle ( sid ): 2 language: de subtitle ( sid ): 3 language: nl subtitle ( sid ): 4 language: fr subtitle ( sid ): 5 language: de INIT ERROR: couldn't get init pos New position not yet determined. Remember to disable MPlayer's cache when playing dvdnav:// streams (adding -nocache to your command line) DVDNAV, switched to title: 1 audio stream: 0 format: ac3 (5.1) language: en aid: 128. audio stream: 1 format: ac3 (5.1) language: de aid: 129. audio stream: 2 format: ac3 (5.1) language: fr aid: 130. subtitle ( sid ): 0 language: en subtitle ( sid ): 1 language: fr subtitle ( sid ): 2 language: de subtitle ( sid ): 3 language: nl subtitle ( sid ): 4 language: fr subtitle ( sid ): 5 language: de DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! DVDNAV stream read error! Exiting... (End of file) r@r-laptop:~/Downloads/mplayer-export-2010-06-22/libdvdnav$ I can file a bug report if anyone thinks that I could, also if I knew the correct place to file it. Cheers, Rich

5 14

Re: [DVDnav-discuss] Suggesting new method to accurately set position by time
by gnosy gnu 21 Jun '10

21 Jun '10

>Please, first explain what's wrong with dvdnav_time_search() >(that currently first uses the TMAP and the ADMAP to get to the >closest block) dvdnav_time_search() uses interpolation to get the sector. This interpolation is inaccurate. The comments for the function indicate as much: /* FIXME: right now, this function does not use the time tables but interpolates only the cell times */ /* FIXME: there must be a better way than interpolation */ time_search uses the ADMAP only after it gets the target sector by (inaccurate) interpolation. As far as I see, it doesn't use TMAP. >and next explain how you want to fix is. A quick explanation of my fix: - use TMAP and ADMAP to get sector from time (handles approximately 95% of dvds) - if TMAP is corrupt, use ADMAP only (handles approximately 5% of dvds) - if ADMAP is corrupt, fall back on interpolation (handles any outliers) I detail the TMAP and ADMAP approach in my first email. I can resummarize again if you feel it was too verbose. Finally, please note I chose not to "fix" time_search b/c the fix was complicated. I thought it would be better to leave the current behavior of time_search as is (someone may be depending on the inaccurate interpolation). >The dvdnavmini is a different issue and belongs to a different thread. >It's also a thing of the past in many respects. I mentioned it because I wanted to explain why I modified my final search.diff. In retrospect, no one else probably would have noticed so I should have omitted it entirely.

2 1

frustration with rip-protected DVDs
by bryanh＠giraffe-data.com 17 Jun '10

17 Jun '10

I have what is probably a pretty stupid, but at least easy, question. I have wanted for many years to build a DVD player (primarily for the purpose of having one without user control restrictions), and my attempts have been unsuccessful so far. I joined the dvdnav-discuss list about two years ago when I was trying to get Mplayer to work with libdvdnav (just for me -- I'm not an Mplayer developer). With a few small fixes to Mplayer, I succeeded at getting the dvdnav: stream to work, menus and all, for me, but the resulting playback was too jerky to watch. Figuring that fixing a timing problem would be way too hard for me, and that lots of people were playing DVDs on Linux systems without doing any coding at all, I decided to start over with all new hardware and software and see what developed. I installed Debian 5, including every DVD playing and ripping package I could find (about six, I think, half of them using libdvdnav), and every single one of them crashed and burned on a Sony movie DVD from 2003 (which works fine, albeit jerky, in my original system). Error messages were mostly unhelpful, but seemed consistent with a failure to navigate around bad sectors put there for rip protection. So here's the question: Is it plausible that nothing in Debian 5 is capable of reading a 2003 Sony movie DVD? And: can someone give me names and version numbers of something - anything - that has been seen to work on rip-protected DVDs so I can continue my quest? Web search for this kind of thing is difficult because it has changed over time. -- Bryan Henderson San Jose, California

5 11