December 2010 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] consuming all memory when scanning dvd "Up"
by John Stebbins 09 Dec '12

09 Dec '12

First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.

3 5

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] libdvdread: segfault and patch to fix it (again)
by Frédéric Marchal 07 Oct '11

07 Oct '11

Hello, On July 11th, Morten Sjøgren reported a segfault due to the double free of a buffer in ifoFree_PTL_MAIT and provided a patch: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-July/066025.html The patch was taken into account by Dominik 'Rathann' Mierzejewski on September 2nd: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-September/066033.h… The patch is incomplete as ifoRead_PTL_MAIT can still return without resetting the pointer in ifofile->ptl_mait. In my case, I have two DVDs failing due an invalid seek offset passed to DVDFileSeek_(). The following patch set ifofile->ptl_mait to NULL (not 0 as in the original patch) before every return statement. Moreover, if the seek offset is obviously out of range, the loop over the countries is interrupted and the nr_of_countries is set to the index of the highest country that could be read. I'm not sure it is the proper action but without a test case to disprove it, it sound sensible as nr_of_countries doesn't seem to be used. Frederic

4 7

[PATCH] fix a memory leak
by Rémi Duraffort 06 Oct '11

06 Oct '11

Hello, this patch fix a potential memory leak and a memory leak I found when playing with valgrind. Best regards -- Rémi Duraffort | ivoire

4 5

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

Re: [DVDnav-discuss] dvdnav patches from handbrake project
by Erik Hovland 06 Oct '11

06 Oct '11

>> Jean - Do VLC folk have anything to say about the patches that the >> handbrake folk submitted to this list? If VLC is running w/ them it would >> help the patches case in getting committed. > Sorry, but do you have a link to them? I do! Huge invasive patch to consolidate memory: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001097.html Bug fix for crashing: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-November/001102.html Follow up patch for same crashing issue: http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-December/001114.html E -- Erik Hovland erik(a)hovland.org http://hovland.org/

8 47

[PATCH] crash while processing mac the ripper "feature title extract" images
by John Stebbins 06 Oct '11

06 Oct '11

Mac the ripper's feature title extraction removes menus from the resulting image, but does not remove navigation instructions that attempt to jump to those menus. This patch checks that a menu exists before acting on such instructions. If the menu does not exist, the it puts the vm into the stopped state.

3 6

[PATCH] do not rely on _WIN32 #define
by Diego Biurrun 10 Feb '11

10 Feb '11

Newer versions of Cygwin no longer set the _WIN32 #define. This is causing some problems that we worked around locally in MPlayer. I have replaced it with WIN32, which is used in other places in libdvdread, but possibly using __MINGW32__ and __CYGWIN__ is even better and makes the intent clearer. I'd appreciate if somebody could test this since I have no Windows system. I think libdvdread is supposed to build on Visual Studio as well, so testing that would be a bonus. Diego

3 3

[PATCH] double free of ptl_mait
by Frédéric Marchal 30 Jan '11

30 Jan '11

Hello, As requested, here is the patch to address the double free of the parental management information buffer that occurs when the country data fail to read. Frederic

2 4

Invalid IFO for title XX (VTS_XX_0.IFO)
by Loïc Minier 09 Dec '10

09 Dec '10

Hey I'm creating ISOs of my DVDs, but I'm getting errors with some of them. I suspect it's a copy protection scheme. When playing the DVD directly, e.g. "vlc /dev/dvd", things "just work". With some DVDs, "dd if=/dev/dvd of=foo.iso && vlc foo.iso" works equally well (I need to run "vlc /dev/dvd" to CSS-unlock the data). But with some DVDs which don't seem particularly scratched, I'll receive exactly one read error during the dd (I'm passing "conv=noerror" to dd to circumvent that); the resulting .iso file is then unusable and shows various errors: libdvdnav: Using dvdnav version 4.1.3 libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdnav: DVD Title: TMS0EUW1 libdvdnav: DVD Serial Number: 3a8e11db [...] libdvdread: Get key for /VIDEO_TS/VTS_15_0.VOB at 0x002f01a5 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_15_1.VOB at 0x002f0258 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_16_0.VOB at 0x002f8be7 libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_16_1.VOB at 0x002f8c9a libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_17_0.VOB at 0x00344d9e libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_17_0.VOB (0x00344d9e) libdvdread: Elapsed time 0 libdvdread: Get key for /VIDEO_TS/VTS_17_1.VOB at 0x00344dae libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_17_1.VOB (0x00344dae)!! libdvdread: Elapsed time 0 libdvdread: Found 17 VTS's libdvdread: Elapsed time 0 Warning: call to srand(309709) libdvdread: Invalid IFO for title 17 (VTS_17_0.IFO). libdvdnav: ifoOpenVTSI failed vlc: /build/buildd/libdvdnav-4.1.3/src/vm/vm.c:1485: process_command: Assertion `0' failed. I'm using Ubuntu 10.10's libdvdnav, libdvdread, and vlc with a self-built libdvdcss. I checked that Ubuntu's libdvdnav doesn't have an embedded libdvdread, and neither does vlc. I cherry-picked SVN r1215 from svn://svn.mplayerhq.hu/dvdnav/trunk into libdvdread, but this didn't help. I also took SVN r237 from svn://svn.videolan.org/libdvdcss/trunk into libdvdcss just in case it was the explanation for the CSS key issues. There seem to be three issues at various levels: - dd fails to read some bytes from /dev/dvd. I'm thinking that this is caused by the copy-protection scheme at the disc mastering level, and that it's an intentional error; maybe this triggers some fallback code pathes in commercial DVD playing software which are not triggered when using a .iso file which has no error - libdvdcss reports that the last title's key can't be cracked when using the .iso file, but it works when using /dev/dvd (almost all the time, albeit there was one case where it didn't work) - libdvdread/libdvdnav are extremely unhappy with ifoOpenVTSI() failing The error seemed similar to the one fixed by the addition of .BUP file support, unfortunately this didn't help. This happens on a range of Walt Disney DVDs Is there some information I can provide on the failure to help track it down? I'm afraid I'm not familiar with the DVD specs. Cheers, -- Loïc Minier

2 3